summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAutomerge <automerge@vaadin.com>2012-04-27 11:39:21 +0000
committerAutomerge <automerge@vaadin.com>2012-04-27 11:39:21 +0000
commit48893c2135d66a0de2c24acec3e7fb659ec85f7f (patch)
tree1628b3c3b15f4a5b71d3c2262138ea8f6f0a4dac /src
parent120237fc9fd64ff2729c635f64806b634befaef0 (diff)
downloadvaadin-framework-48893c2135d66a0de2c24acec3e7fb659ec85f7f.tar.gz
vaadin-framework-48893c2135d66a0de2c24acec3e7fb659ec85f7f.zip
[merge from 6.7] Use equals instead of == to compare item ids (#8712). Using == will fail at least with JPAContainer as the entity provider provides the id instances and it is not guaranteed that the same instance is returned every time (e.g. if using a Long the longs represent the same number but are not the same instance)
svn changeset:23655/svn branch:6.8
Diffstat (limited to 'src')
-rw-r--r--src/com/vaadin/ui/Table.java2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/com/vaadin/ui/Table.java b/src/com/vaadin/ui/Table.java
index e605ec4f6b..7828fdb734 100644
--- a/src/com/vaadin/ui/Table.java
+++ b/src/com/vaadin/ui/Table.java
@@ -1819,7 +1819,7 @@ public class Table extends AbstractSelect implements Action.Container,
if (index < firstIndexNotInCache
&& index >= pageBufferFirstIndex
&& pageBuffer[CELL_GENERATED_ROW][indexInOldBuffer] == null
- && pageBuffer[CELL_ITEMID][indexInOldBuffer] == id) {
+ && id.equals(pageBuffer[CELL_ITEMID][indexInOldBuffer])) {
// we already have data in our cache,
// recycle it instead of fetching it via
// getValue/getPropertyValue