Rename requestRepaint to markAsDirty (#9378)

Also remove some requestRepaint calls that are no longer needed (#9325)

25 files changed, 29 insertions, 35 deletions

diff --git a/tests/server-side/com/vaadin/tests/server/component/textfield/TextFieldWithPropertyFormatter.java b/tests/server-side/com/vaadin/tests/server/component/textfield/TextFieldWithPropertyFormatter.java
index bd6dd6c7b1..4bb0177a18 100644
--- a/tests/server-side/com/vaadin/tests/server/component/textfield/TextFieldWithPropertyFormatter.java
+++ b/tests/server-side/com/vaadin/tests/server/component/textfield/TextFieldWithPropertyFormatter.java
@@ -30,9 +30,9 @@ public class TextFieldWithPropertyFormatter extends TestCase {
 
         field = new TextField() {
             @Override
-            public void requestRepaint() {
+            public void markAsDirty() {
                 repainted++;
-                super.requestRepaint();
+                super.markAsDirty();
             }
         };
 
diff --git a/tests/testbench/com/vaadin/tests/PerformanceTestLabelsAndOrderedLayouts.java b/tests/testbench/com/vaadin/tests/PerformanceTestLabelsAndOrderedLayouts.java
index aa8814ce4c..8002059227 100644
--- a/tests/testbench/com/vaadin/tests/PerformanceTestLabelsAndOrderedLayouts.java
+++ b/tests/testbench/com/vaadin/tests/PerformanceTestLabelsAndOrderedLayouts.java
@@ -62,7 +62,7 @@ public class PerformanceTestLabelsAndOrderedLayouts extends CustomComponent {
                 new ClickListener() {
                     @Override
                     public void buttonClick(ClickEvent event) {
-                        testContainer.requestRepaint();
+                        testContainer.markAsDirty();
                     }
                 }));
 
diff --git a/tests/testbench/com/vaadin/tests/TestSizeableIncomponents.java b/tests/testbench/com/vaadin/tests/TestSizeableIncomponents.java
index 50cbe0778b..f33132a709 100644
--- a/tests/testbench/com/vaadin/tests/TestSizeableIncomponents.java
+++ b/tests/testbench/com/vaadin/tests/TestSizeableIncomponents.java
@@ -78,7 +78,7 @@ public class TestSizeableIncomponents extends Application.LegacyApplication {
                     getMainWindow().showNotification(
                             "Selected test:" + prev.getTestableName());
                     select.setValue(prev);
-                    select.requestRepaint();
+                    select.markAsDirty();
                 }
             }
         });
@@ -94,7 +94,7 @@ public class TestSizeableIncomponents extends Application.LegacyApplication {
                     getMainWindow().showNotification(
                             "Selected test:" + next.getTestableName());
                     select.setValue(next);
-                    select.requestRepaint();
+                    select.markAsDirty();
                 }
             }
         });
diff --git a/tests/testbench/com/vaadin/tests/components/absolutelayout/MoveComponentsFromAbsoluteLayoutToInnerLayout.java b/tests/testbench/com/vaadin/tests/components/absolutelayout/MoveComponentsFromAbsoluteLayoutToInnerLayout.java
index 826b7cee07..c14cda58f1 100644
--- a/tests/testbench/com/vaadin/tests/components/absolutelayout/MoveComponentsFromAbsoluteLayoutToInnerLayout.java
+++ b/tests/testbench/com/vaadin/tests/components/absolutelayout/MoveComponentsFromAbsoluteLayoutToInnerLayout.java
@@ -40,7 +40,7 @@ public class MoveComponentsFromAbsoluteLayoutToInnerLayout extends TestBase {
 
                     @Override
                     public void buttonClick(ClickEvent event) {
-                        vl.requestRepaint();
+                        vl.markAsDirty();
                     }
                 });
 
diff --git a/tests/testbench/com/vaadin/tests/components/datefield/DateFieldRangeValidation.java b/tests/testbench/com/vaadin/tests/components/datefield/DateFieldRangeValidation.java
index 484b9cfee8..c085088917 100644
--- a/tests/testbench/com/vaadin/tests/components/datefield/DateFieldRangeValidation.java
+++ b/tests/testbench/com/vaadin/tests/components/datefield/DateFieldRangeValidation.java
@@ -58,7 +58,7 @@ public class DateFieldRangeValidation extends TestBase {
 
         @Override
         public void valueChange(ValueChangeEvent event) {
-            actualDateField.requestRepaint();
+            actualDateField.markAsDirty();
         }
     };
 
diff --git a/tests/testbench/com/vaadin/tests/components/datefield/DisabledDateFieldWidth.java b/tests/testbench/com/vaadin/tests/components/datefield/DisabledDateFieldWidth.java
index 4e256aa947..403b82a2a7 100644
--- a/tests/testbench/com/vaadin/tests/components/datefield/DisabledDateFieldWidth.java
+++ b/tests/testbench/com/vaadin/tests/components/datefield/DisabledDateFieldWidth.java
@@ -18,7 +18,7 @@ public class DisabledDateFieldWidth extends TestBase {
                 new Button.ClickListener() {
                     @Override
                     public void buttonClick(ClickEvent event) {
-                        dateField1.requestRepaint();
+                        dateField1.markAsDirty();
                     }
                 });
 
diff --git a/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedImageRefresh.java b/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedImageRefresh.java
index e316fcc5ec..3020942844 100644
--- a/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedImageRefresh.java
+++ b/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedImageRefresh.java
@@ -47,7 +47,7 @@ public class EmbeddedImageRefresh extends TestBase {
         button.addListener(new Button.ClickListener() {
             @Override
             public void buttonClick(ClickEvent event) {
-                embedded.requestRepaint();
+                embedded.markAsDirty();
             }
         });
         addComponent(button);
@@ -57,7 +57,7 @@ public class EmbeddedImageRefresh extends TestBase {
             public void buttonClick(ClickEvent event) {
                 ((StreamResource) embedded.getSource()).setFilename(new Date()
                         .getTime() + ".png");
-                embedded.requestRepaint();
+                embedded.markAsDirty();
             }
         });
         addComponent(button);
diff --git a/tests/testbench/com/vaadin/tests/components/gridlayout/MoveComponentsFromGridLayoutToInnerLayout.java b/tests/testbench/com/vaadin/tests/components/gridlayout/MoveComponentsFromGridLayoutToInnerLayout.java
index 1c10b1d9d7..0106f2e218 100644
--- a/tests/testbench/com/vaadin/tests/components/gridlayout/MoveComponentsFromGridLayoutToInnerLayout.java
+++ b/tests/testbench/com/vaadin/tests/components/gridlayout/MoveComponentsFromGridLayoutToInnerLayout.java
@@ -40,7 +40,7 @@ public class MoveComponentsFromGridLayoutToInnerLayout extends TestBase {
 
                     @Override
                     public void buttonClick(ClickEvent event) {
-                        vl.requestRepaint();
+                        vl.markAsDirty();
                     }
                 });
 
diff --git a/tests/testbench/com/vaadin/tests/components/splitpanel/SplitPanelExtraScrollbars.java b/tests/testbench/com/vaadin/tests/components/splitpanel/SplitPanelExtraScrollbars.java
index 05e10397ac..00012522ca 100644
--- a/tests/testbench/com/vaadin/tests/components/splitpanel/SplitPanelExtraScrollbars.java
+++ b/tests/testbench/com/vaadin/tests/components/splitpanel/SplitPanelExtraScrollbars.java
@@ -62,8 +62,8 @@ public class SplitPanelExtraScrollbars extends AbstractTestCase implements
         }
 
         // Sending all changes in one repaint triggers the bug
-        hl.requestRepaint();
-        sp.requestRepaint();
+        hl.markAsDirty();
+        sp.markAsDirty();
     }
 
 }
diff --git a/tests/testbench/com/vaadin/tests/components/table/EditableTableLeak.java b/tests/testbench/com/vaadin/tests/components/table/EditableTableLeak.java
index 88c7c76889..26ac23d5be 100644
--- a/tests/testbench/com/vaadin/tests/components/table/EditableTableLeak.java
+++ b/tests/testbench/com/vaadin/tests/components/table/EditableTableLeak.java
@@ -114,7 +114,7 @@ public class EditableTableLeak extends TestBase {
         addComponent(new Button("Show size of the table", new ClickListener() {
             @Override
             public void buttonClick(ClickEvent event) {
-                table.requestRepaintAll();
+                table.markAsDirtyRecursive();
                 updateSize();
             }
 
diff --git a/tests/testbench/com/vaadin/tests/components/table/TableClickValueChangeInteraction.java b/tests/testbench/com/vaadin/tests/components/table/TableClickValueChangeInteraction.java
index 00df9fa3c3..a37cf48579 100644
--- a/tests/testbench/com/vaadin/tests/components/table/TableClickValueChangeInteraction.java
+++ b/tests/testbench/com/vaadin/tests/components/table/TableClickValueChangeInteraction.java
@@ -63,7 +63,7 @@ public class TableClickValueChangeInteraction extends TestBase {
 
                 @Override
                 public void itemClick(ItemClickEvent event) {
-                    table.requestRepaint();
+                    table.markAsDirty();
                     clickLabel.setValue("Click " + event.getItemId());
                 }
             });
diff --git a/tests/testbench/com/vaadin/tests/components/table/TableColumnResizeContentsWidth.java b/tests/testbench/com/vaadin/tests/components/table/TableColumnResizeContentsWidth.java
index 1895191cc4..0b695b41c7 100644
--- a/tests/testbench/com/vaadin/tests/components/table/TableColumnResizeContentsWidth.java
+++ b/tests/testbench/com/vaadin/tests/components/table/TableColumnResizeContentsWidth.java
@@ -34,14 +34,14 @@ public class TableColumnResizeContentsWidth extends TestBase {
             @Override
             public void buttonClick(ClickEvent event) {
                 table.setColumnWidth(COL1, table.getColumnWidth(COL1) + 20);
-                table.requestRepaint();
+                table.markAsDirty();
             }
         }));
         addComponent(new Button("Decrease width", new Button.ClickListener() {
             @Override
             public void buttonClick(ClickEvent event) {
                 table.setColumnWidth(COL1, table.getColumnWidth(COL1) - 40);
-                table.requestRepaint();
+                table.markAsDirty();
             }
         }));
     }
diff --git a/tests/testbench/com/vaadin/tests/components/tree/TreeFiltering.java b/tests/testbench/com/vaadin/tests/components/tree/TreeFiltering.java
index bd7984cdeb..be65a335be 100644
--- a/tests/testbench/com/vaadin/tests/components/tree/TreeFiltering.java
+++ b/tests/testbench/com/vaadin/tests/components/tree/TreeFiltering.java
@@ -51,7 +51,7 @@ public class TreeFiltering extends TestBase {
             public void valueChange(ValueChangeEvent event) {
                 cont.setIncludeParentsWhenFiltering((Boolean) ((CheckBox) event
                         .getProperty()).getValue());
-                ccTree.requestRepaint();
+                ccTree.markAsDirty();
             }
         });
         addComponent(filterType);
diff --git a/tests/testbench/com/vaadin/tests/components/treetable/KeepAllItemsVisible.java b/tests/testbench/com/vaadin/tests/components/treetable/KeepAllItemsVisible.java
index 799537f923..f444b781dd 100644
--- a/tests/testbench/com/vaadin/tests/components/treetable/KeepAllItemsVisible.java
+++ b/tests/testbench/com/vaadin/tests/components/treetable/KeepAllItemsVisible.java
@@ -40,7 +40,7 @@ public class KeepAllItemsVisible extends TestBase implements ExpandListener,
             @Override
             public void valueChange(ValueChangeEvent event) {
                 recalculatePageLength(tt);
-                tt.requestRepaint();
+                tt.markAsDirty();
             }
         });
         addComponent(tt);
diff --git a/tests/testbench/com/vaadin/tests/dd/NotPaintedAcceptSource.java b/tests/testbench/com/vaadin/tests/dd/NotPaintedAcceptSource.java
index abe8553267..020a6b56c5 100644
--- a/tests/testbench/com/vaadin/tests/dd/NotPaintedAcceptSource.java
+++ b/tests/testbench/com/vaadin/tests/dd/NotPaintedAcceptSource.java
@@ -64,7 +64,7 @@ public class NotPaintedAcceptSource extends TestBase {
                 } else {
                     horizontalLayout.replaceComponent(source2, source1);
                 }
-                target.requestRepaint();
+                target.markAsDirty();
             }
         }));
 
diff --git a/tests/testbench/com/vaadin/tests/extensions/HelloWorldExtension.java b/tests/testbench/com/vaadin/tests/extensions/HelloWorldExtension.java
index de028cf0c3..60db95827c 100644
--- a/tests/testbench/com/vaadin/tests/extensions/HelloWorldExtension.java
+++ b/tests/testbench/com/vaadin/tests/extensions/HelloWorldExtension.java
@@ -39,7 +39,6 @@ public class HelloWorldExtension extends AbstractExtension {
 
     public void setGreeting(String greeting) {
         getState().setGreeting(greeting);
-        requestRepaint();
     }
 
     public String getGreeting() {
diff --git a/tests/testbench/com/vaadin/tests/extensions/SimpleJavaScriptExtensionTest.java b/tests/testbench/com/vaadin/tests/extensions/SimpleJavaScriptExtensionTest.java
index b33162d714..7d4f41cfb3 100644
--- a/tests/testbench/com/vaadin/tests/extensions/SimpleJavaScriptExtensionTest.java
+++ b/tests/testbench/com/vaadin/tests/extensions/SimpleJavaScriptExtensionTest.java
@@ -84,7 +84,6 @@ public class SimpleJavaScriptExtensionTest extends AbstractTestRoot {
 
         public void setPrefix(String prefix) {
             getState().setPrefix(prefix);
-            requestRepaint();
         }
 
         public void greetRpc(String message) {
diff --git a/tests/testbench/com/vaadin/tests/layouts/CssLayoutCustomCss.java b/tests/testbench/com/vaadin/tests/layouts/CssLayoutCustomCss.java
index ed35d39ef7..2f717d2b64 100644
--- a/tests/testbench/com/vaadin/tests/layouts/CssLayoutCustomCss.java
+++ b/tests/testbench/com/vaadin/tests/layouts/CssLayoutCustomCss.java
@@ -85,7 +85,7 @@ public class CssLayoutCustomCss extends TestBase implements ClickListener {
             css.remove(b);
             b.setCaption("not " + b.getCaption());
         }
-        layout.requestRepaint();
+        layout.markAsDirty();
 
     }
 
diff --git a/tests/testbench/com/vaadin/tests/minitutorials/v7a2/ComponentInStateComponent.java b/tests/testbench/com/vaadin/tests/minitutorials/v7a2/ComponentInStateComponent.java
index c6109eebcd..061eb7a23e 100644
--- a/tests/testbench/com/vaadin/tests/minitutorials/v7a2/ComponentInStateComponent.java
+++ b/tests/testbench/com/vaadin/tests/minitutorials/v7a2/ComponentInStateComponent.java
@@ -29,7 +29,6 @@ public class ComponentInStateComponent extends AbstractComponent {
 
     public void setOtherComponent(Component component) {
         getState().setOtherComponent(component);
-        requestRepaint();
     }
 
     public Component getOtherComponent() {
diff --git a/tests/testbench/com/vaadin/tests/minitutorials/v7a2/MyComponent.java b/tests/testbench/com/vaadin/tests/minitutorials/v7a2/MyComponent.java
index b85d49172b..292ac62125 100644
--- a/tests/testbench/com/vaadin/tests/minitutorials/v7a2/MyComponent.java
+++ b/tests/testbench/com/vaadin/tests/minitutorials/v7a2/MyComponent.java
@@ -51,7 +51,6 @@ public class MyComponent extends AbstractComponent {
 
     public void setText(String text) {
         getState().setText(text);
-        requestRepaint();
     }
 
     public String getText() {
diff --git a/tests/testbench/com/vaadin/tests/minitutorials/v7a2/WidgetContainer.java b/tests/testbench/com/vaadin/tests/minitutorials/v7a2/WidgetContainer.java
index 40bb7b68b8..5c519dbdfe 100644
--- a/tests/testbench/com/vaadin/tests/minitutorials/v7a2/WidgetContainer.java
+++ b/tests/testbench/com/vaadin/tests/minitutorials/v7a2/WidgetContainer.java
@@ -15,14 +15,14 @@ public class WidgetContainer extends AbstractComponentContainer {
     public void addComponent(Component c) {
         children.add(c);
         super.addComponent(c);
-        requestRepaint();
+        markAsDirty();
     }
 
     @Override
     public void removeComponent(Component c) {
         children.remove(c);
         super.removeComponent(c);
-        requestRepaint();
+        markAsDirty();
     }
 
     @Override
@@ -33,7 +33,7 @@ public class WidgetContainer extends AbstractComponentContainer {
             children.add(index, newComponent);
             fireComponentDetachEvent(oldComponent);
             fireComponentAttachEvent(newComponent);
-            requestRepaint();
+            markAsDirty();
         }
     }
 
diff --git a/tests/testbench/com/vaadin/tests/minitutorials/v7a3/Flot.java b/tests/testbench/com/vaadin/tests/minitutorials/v7a3/Flot.java
index 99e6418fdc..816c60cfe5 100644
--- a/tests/testbench/com/vaadin/tests/minitutorials/v7a3/Flot.java
+++ b/tests/testbench/com/vaadin/tests/minitutorials/v7a3/Flot.java
@@ -58,8 +58,6 @@ public class Flot extends AbstractJavaScriptComponent {
         }
 
         getState().getSeries().add(pointList);
-
-        requestRepaint();
     }
 
     public void highlight(int seriesIndex, int dataIndex) {
diff --git a/tests/testbench/com/vaadin/tests/tickets/Ticket1834PanelScrolling.java b/tests/testbench/com/vaadin/tests/tickets/Ticket1834PanelScrolling.java
index de91b04c1c..e31748ec2f 100644
--- a/tests/testbench/com/vaadin/tests/tickets/Ticket1834PanelScrolling.java
+++ b/tests/testbench/com/vaadin/tests/tickets/Ticket1834PanelScrolling.java
@@ -66,7 +66,7 @@ public class Ticket1834PanelScrolling extends
         b.addListener(new ClickListener() {
             @Override
             public void buttonClick(ClickEvent event) {
-                p.requestRepaint();
+                p.markAsDirty();
             }
         });
 
diff --git a/tests/testbench/com/vaadin/tests/tickets/Ticket1983.java b/tests/testbench/com/vaadin/tests/tickets/Ticket1983.java
index 4deb5020ab..4db82c3371 100644
--- a/tests/testbench/com/vaadin/tests/tickets/Ticket1983.java
+++ b/tests/testbench/com/vaadin/tests/tickets/Ticket1983.java
@@ -107,7 +107,7 @@ public class Ticket1983 extends Application.LegacyApplication {
                         isLong = true;
                     }
                     // Works the same way with or without repaint request
-                    table.requestRepaint();
+                    table.markAsDirty();
                 }
             });
 
diff --git a/tests/testbench/com/vaadin/tests/tickets/Ticket2060.java b/tests/testbench/com/vaadin/tests/tickets/Ticket2060.java
index 1d7d8bb006..88404b6ef1 100644
--- a/tests/testbench/com/vaadin/tests/tickets/Ticket2060.java
+++ b/tests/testbench/com/vaadin/tests/tickets/Ticket2060.java
@@ -33,9 +33,9 @@ public class Ticket2060 extends Application.LegacyApplication {
 
             @Override
             public void buttonClick(ClickEvent event) {
-                button1.requestRepaint();
-                button2.requestRepaint();
-                button3.requestRepaint();
+                button1.markAsDirty();
+                button2.markAsDirty();
+                button3.markAsDirty();
 
             }