diff options
author | Tarek Oraby <42799254+tarekoraby@users.noreply.github.com> | 2020-05-08 15:46:59 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-08 15:46:59 +0300 |
commit | 8821d64a15c0200d920ac94da844568ed0034306 (patch) | |
tree | b4fb2fc09fcd79ac83c0312bb9c7b357acc11d9f /uitest/src/main | |
parent | 1dcf3dc338fc5587575211d0463721e85b586691 (diff) | |
download | vaadin-framework-8821d64a15c0200d920ac94da844568ed0034306.tar.gz vaadin-framework-8821d64a15c0200d920ac94da844568ed0034306.zip |
Fix RTA's CreateLink in Firefox & IE11 (#11979)
In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted.
This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted.
fixes #11888
Diffstat (limited to 'uitest/src/main')
-rw-r--r-- | uitest/src/main/java/com/vaadin/tests/components/richtextarea/RichTextAreaCreateLink.java | 38 |
1 files changed, 38 insertions, 0 deletions
diff --git a/uitest/src/main/java/com/vaadin/tests/components/richtextarea/RichTextAreaCreateLink.java b/uitest/src/main/java/com/vaadin/tests/components/richtextarea/RichTextAreaCreateLink.java new file mode 100644 index 0000000000..cb89e919e5 --- /dev/null +++ b/uitest/src/main/java/com/vaadin/tests/components/richtextarea/RichTextAreaCreateLink.java @@ -0,0 +1,38 @@ +package com.vaadin.tests.components.richtextarea; + +import com.vaadin.server.VaadinRequest; +import com.vaadin.shared.ui.ContentMode; +import com.vaadin.tests.components.AbstractTestUI; +import com.vaadin.ui.Button; +import com.vaadin.ui.Label; +import com.vaadin.ui.RichTextArea; + +public class RichTextAreaCreateLink extends AbstractTestUI { + + @Override + protected String getTestDescription() { + return "Test the 'Create Link' button of a rich text area in supported browsers."; + } + + @Override + protected Integer getTicketNumber() { + return 11888; + } + + @Override + protected void setup(VaadinRequest request) { + final RichTextArea area = new RichTextArea(); + + final Label label = new Label(area.getValue(), + ContentMode.PREFORMATTED); + label.setCaption("Value recieved from RichTextArea:"); + + final Button button = new Button("get area value", + event -> label.setValue(area.getValue())); + + addComponent(area); + addComponent(button); + addComponent(label); + } + +} |