diff options
author | Artur <artur@vaadin.com> | 2017-07-24 08:43:52 +0300 |
---|---|---|
committer | Henri Sara <henri.sara@gmail.com> | 2017-07-24 08:43:52 +0300 |
commit | 94f2e1f4227c59b21011747ab04ed553cfa235a8 (patch) | |
tree | 52852074a507c5f9dafed71f978883385ba8ecd5 /uitest/src/test | |
parent | 913e55ae4084c1f3e8c41b7620f3d7496710ba03 (diff) | |
download | vaadin-framework-94f2e1f4227c59b21011747ab04ed553cfa235a8.tar.gz vaadin-framework-94f2e1f4227c59b21011747ab04ed553cfa235a8.zip |
Do full connector tracker cleanup when the session lock is released (#9707)
As there is no "request end" call after invoking UI.access() from a background thread,
the connector map was not earlier properly cleaned afterwards. If you toggled visibility of a
component from the background thread, the tracker state became inconsistent.
If this becomes a performance problem, it could probably be optimized to that cleanup
is done in request end and only at the end of access if not inside a request.
Fixes #9654
Diffstat (limited to 'uitest/src/test')
-rw-r--r-- | uitest/src/test/java/com/vaadin/tests/push/PushToggleComponentVisibilityTest.java | 43 |
1 files changed, 43 insertions, 0 deletions
diff --git a/uitest/src/test/java/com/vaadin/tests/push/PushToggleComponentVisibilityTest.java b/uitest/src/test/java/com/vaadin/tests/push/PushToggleComponentVisibilityTest.java new file mode 100644 index 0000000000..831d6a11b2 --- /dev/null +++ b/uitest/src/test/java/com/vaadin/tests/push/PushToggleComponentVisibilityTest.java @@ -0,0 +1,43 @@ +/* + * Copyright 2000-2016 Vaadin Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package com.vaadin.tests.push; + +import org.junit.Assert; +import org.junit.Test; +import org.openqa.selenium.By; + +import com.vaadin.testbench.elements.ButtonElement; +import com.vaadin.testbench.elements.LabelElement; +import com.vaadin.tests.tb3.SingleBrowserTest; + +public class PushToggleComponentVisibilityTest extends SingleBrowserTest { + + private static final String HIDE = "hide"; + + @Test + public void ensureComponentVisible() { + openTestURL(); + + $(ButtonElement.class).id(HIDE).click(); + Assert.assertEquals("Please wait", + $(LabelElement.class).first().getText()); + + waitForElementPresent(By.id(HIDE)); + $(ButtonElement.class).id(HIDE).click(); + Assert.assertEquals("Please wait", + $(LabelElement.class).first().getText()); + } +} |