Fixes a bug in Details being open on freshly retrieved Grid rows (#16644)

Change-Id: Id337dd84ba0b0f09d55b3cdb0d8bfde67313ed21

1 files changed, 26 insertions, 3 deletions

diff --git a/uitest/src/com/vaadin/tests/components/grid/basicfeatures/server/GridDetailsServerTest.java b/uitest/src/com/vaadin/tests/components/grid/basicfeatures/server/GridDetailsServerTest.java
index e9e32cb1ca..e9b5b688d1 100644
--- a/uitest/src/com/vaadin/tests/components/grid/basicfeatures/server/GridDetailsServerTest.java
+++ b/uitest/src/com/vaadin/tests/components/grid/basicfeatures/server/GridDetailsServerTest.java
@@ -17,7 +17,6 @@ package com.vaadin.tests.components.grid.basicfeatures.server;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
@@ -76,8 +75,7 @@ public class GridDetailsServerTest extends GridBasicFeaturesTest {
         selectMenuPath(FIRST_ITEM_DETAILS);
         selectMenuPath(FIRST_ITEM_DETAILS);
 
-        // this will throw before assertNull
-        assertNull(getGridElement().getDetails(0));
+        getGridElement().getDetails(0);
     }
 
     @Test
@@ -120,6 +118,31 @@ public class GridDetailsServerTest extends GridBasicFeaturesTest {
                 details.findElement(By.className("v-widget")));
     }
 
+    @Test(expected = NoSuchElementException.class)
+    public void scrollingDoesNotCreateAFloodOfDetailsRows() {
+        selectMenuPath(CUSTOM_DETAILS_GENERATOR);
+
+        // scroll somewhere to hit uncached rows
+        getGridElement().scrollToRow(101);
+
+        // this should throw
+        getGridElement().getDetails(100);
+    }
+
+    @Test
+    public void openingDetailsOutOfView() {
+        getGridElement().scrollToRow(500);
+
+        selectMenuPath(CUSTOM_DETAILS_GENERATOR);
+        selectMenuPath(FIRST_ITEM_DETAILS);
+
+        getGridElement().scrollToRow(0);
+
+        // if this fails, it'll fail before the assertNotNull
+        assertNotNull("unexpected null details row", getGridElement()
+                .getDetails(0));
+    }
+
     @Test
     public void togglingAVisibleDetailsRowWithOneRoundtrip() {
         selectMenuPath(CUSTOM_DETAILS_GENERATOR);