diff options
| author | Leif Åstrand <leif@vaadin.com> | 2013-11-15 09:46:42 +0000 |
|---|---|---|
| committer | Vaadin Code Review <review@vaadin.com> | 2013-11-15 14:14:28 +0000 |
| commit | 81a1c293f0e407db4a5443b85e57d32cddd397a7 (patch) | |
| tree | 220d54d3653006ffdbea32ab3da36bd8828abd13 /uitest | |
| parent | 642818fef200429d4206403e98aabd54ff3b6dd8 (diff) | |
| download | vaadin-framework-81a1c293f0e407db4a5443b85e57d32cddd397a7.tar.gz vaadin-framework-81a1c293f0e407db4a5443b85e57d32cddd397a7.zip | |
Revert "Fixed lost scrollLeft when row count changed in Table (#12652)."
This reverts commit 533ddcda271b7226b38c035adf3073062c562653.
Seems like the caused regressions are far from trivial to resolve. A new approach might be needed to resolve this issue.
Change-Id: I88cf75608e8d47fffab5a366a8ad1b3b70c1c11f
Diffstat (limited to 'uitest')
2 files changed, 0 insertions, 211 deletions
diff --git a/uitest/src/com/vaadin/tests/components/table/TableHorizontalScrollPositionOnItemSetChange.html b/uitest/src/com/vaadin/tests/components/table/TableHorizontalScrollPositionOnItemSetChange.html deleted file mode 100644 index 6fd54ba0ca..0000000000 --- a/uitest/src/com/vaadin/tests/components/table/TableHorizontalScrollPositionOnItemSetChange.html +++ /dev/null @@ -1,110 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> -<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> -<head profile="http://selenium-ide.openqa.org/profiles/test-case"> -<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> -<link rel="selenium.base" href="http://localhost:8888/" /> -<title>TableHorizontalScrollPositionOnItemSetChange</title> -</head> -<body> - <table cellpadding="1" cellspacing="1" border="1"> - <thead> - <tr> - <td rowspan="1" colspan="3">TableHorizontalScrollPositionOnItemSetChange</td> - </tr> - </thead> - <tbody> - <tr> - <td>open</td> - <td>/run/com.vaadin.tests.components.table.TableHorizontalScrollPositionOnItemSetChange?restartApplication</td> - <td></td> - </tr> - <tr> - <td>scrollLeft</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Shorscrolltable/domChild[1]</td> - <td>326</td> - </tr> - <tr> - <td>pause</td> - <td>500</td> - <td></td> - </tr> - <tr> - <td>click</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Slessitems/domChild[0]/domChild[0]</td> - <td></td> - </tr> - <tr> - <td>pause</td> - <td>500</td> - <td></td> - </tr> - <tr> - <td>screenCapture</td> - <td></td> - <td>left-scroll-position-stays-in-middle-with-fewer-items</td> - </tr> - <tr> - <td>click</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Smoreitems/domChild[0]/domChild[0]</td> - <td></td> - </tr> - <tr> - <td>pause</td> - <td>500</td> - <td></td> - </tr> - <tr> - <td>screenCapture</td> - <td></td> - <td>left-scroll-position-stays-in-middle-with-more-items</td> - </tr> - <tr> - <td>scrollLeft</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Shorscrolltable/domChild[1]</td> - <td>653</td> - </tr> - <tr> - <td>pause</td> - <td>500</td> - <td></td> - </tr> - <tr> - <td>click</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Slessitems/domChild[0]/domChild[0]</td> - <td></td> - </tr> - <tr> - <td>pause</td> - <td>500</td> - <td></td> - </tr> - <tr> - <td>screenCapture</td> - <td></td> - <td>left-scroll-position-stays-max-with-fewer-items</td> - </tr> - <tr> - <td>click</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Smoreitems/domChild[0]/domChild[0]</td> - <td></td> - </tr> - <tr> - <td>pause</td> - <td>500</td> - <td></td> - </tr> - <tr> - <td>screenCapture</td> - <td></td> - <td>left-scroll-position-stays-max-with-more-items</td> - </tr> - <tr> - <td>scrollLeft</td> - <td>vaadin=runcomvaadintestscomponentstableTableHorizontalScrollPositionOnItemSetChange::PID_Shorscrolltable/domChild[1]</td> - <td>0</td> - </tr> - </tbody> - </table> -</body> -</html> diff --git a/uitest/src/com/vaadin/tests/components/table/TableHorizontalScrollPositionOnItemSetChange.java b/uitest/src/com/vaadin/tests/components/table/TableHorizontalScrollPositionOnItemSetChange.java deleted file mode 100644 index 1f59a84428..0000000000 --- a/uitest/src/com/vaadin/tests/components/table/TableHorizontalScrollPositionOnItemSetChange.java +++ /dev/null @@ -1,101 +0,0 @@ -/* - * Copyright 2000-2013 Vaadin Ltd. - * - * Licensed under the Apache License, Version 2.0 (the "License"); you may not - * use this file except in compliance with the License. You may obtain a copy of - * the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT - * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the - * License for the specific language governing permissions and limitations under - * the License. - */ -package com.vaadin.tests.components.table; - -import com.vaadin.server.VaadinRequest; -import com.vaadin.tests.components.AbstractTestUI; -import com.vaadin.ui.Button; -import com.vaadin.ui.Button.ClickEvent; -import com.vaadin.ui.HorizontalLayout; -import com.vaadin.ui.Table; -import com.vaadin.ui.VerticalLayout; - -public class TableHorizontalScrollPositionOnItemSetChange extends - AbstractTestUI { - - @Override - protected void setup(VaadinRequest request) { - VerticalLayout layout = new VerticalLayout(); - layout.setMargin(true); - layout.setSpacing(true); - setContent(layout); - - final Table table = new Table(); - table.setWidth("640px"); - table.setHeight("243px"); - table.setId("horscrolltable"); - layout.addComponent(table); - - for (int i = 0; i < 15; i++) { - table.addContainerProperty("Column " + i, String.class, null); - } - - for (int i = 0; i < 60; i++) { - table.addItem(); - } - - Button lessItems = new Button("Less items", new Button.ClickListener() { - - @Override - public void buttonClick(Button.ClickEvent event) { - table.removeAllItems(); - for (int i = 0; i < 5; i++) { - table.addItem(); - } - } - }); - lessItems.setId("lessitems"); - - Button moreItems = new Button("More items", new Button.ClickListener() { - - @Override - public void buttonClick(Button.ClickEvent event) { - table.removeAllItems(); - for (int i = 0; i < 50; i++) { - table.addItem(); - } - } - }); - moreItems.setId("moreitems"); - - Button clearItems = new Button("Clear all", new Button.ClickListener() { - @Override - public void buttonClick(ClickEvent event) { - table.removeAllItems(); - } - }); - - HorizontalLayout buttonLayout = new HorizontalLayout(); - buttonLayout.setSpacing(true); - layout.addComponent(buttonLayout); - - buttonLayout.addComponent(lessItems); - buttonLayout.addComponent(moreItems); - buttonLayout.addComponent(clearItems); - clearItems.setId("clearitems"); - } - - @Override - protected String getTestDescription() { - return "Horizontal scrolling position should not be lost if amount of items changes in Table."; - } - - @Override - protected Integer getTicketNumber() { - return 12652; - } - -} |