diff options
| author | Johannes Dahlström <johannesd@vaadin.com> | 2013-05-06 15:14:32 +0300 |
|---|---|---|
| committer | Vaadin Code Review <review@vaadin.com> | 2013-05-10 09:58:59 +0000 |
| commit | ffd1c1bff51433440a5ea4f41fd042790b6b897a (patch) | |
| tree | 727ea40c00713c820ffbe9540f80ceea8949a91f /uitest | |
| parent | 3f5d022e7fca887341cc7ffb0ff48ac99ed558b4 (diff) | |
| download | vaadin-framework-ffd1c1bff51433440a5ea4f41fd042790b6b897a.tar.gz vaadin-framework-ffd1c1bff51433440a5ea4f41fd042790b6b897a.zip | |
Don't ignore child component margins in AbstractOrderedLayout (#11553)
Change-Id: I89d8364b97bfe7d072cc7e5221b35ab3cdb3c58b
Diffstat (limited to 'uitest')
| -rw-r--r-- | uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html | 27 | ||||
| -rw-r--r-- | uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java | 85 |
2 files changed, 112 insertions, 0 deletions
diff --git a/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html new file mode 100644 index 0000000000..3132bdd16d --- /dev/null +++ b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html @@ -0,0 +1,27 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> +<head profile="http://selenium-ide.openqa.org/profiles/test-case"> +<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" /> +<link rel="selenium.base" href="http://localhost:8070/" /> +<title>MarginWithExpandRatio</title> +</head> +<body> +<table cellpadding="1" cellspacing="1" border="1"> +<thead> +<tr><td rowspan="1" colspan="3">MarginWithExpandRatio</td></tr> +</thead><tbody> +<tr> + <td>open</td> + <td>/run/MarginWithExpandRatio?restartApplication</td> + <td></td> +</tr> +<tr> + <td>screenCapture</td> + <td></td> + <td>no-overflow</td> +</tr> + +</tbody></table> +</body> +</html> diff --git a/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java new file mode 100644 index 0000000000..f6ee26e86f --- /dev/null +++ b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java @@ -0,0 +1,85 @@ +/* + * Copyright 2000-2013 Vaadin Ltd. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not + * use this file except in compliance with the License. You may obtain a copy of + * the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +package com.vaadin.tests.layouts; + +import com.vaadin.server.VaadinRequest; +import com.vaadin.tests.components.AbstractTestUI; +import com.vaadin.tests.util.TestUtils; +import com.vaadin.ui.GridLayout; +import com.vaadin.ui.HorizontalLayout; +import com.vaadin.ui.Label; +import com.vaadin.ui.Layout; +import com.vaadin.ui.Panel; +import com.vaadin.ui.VerticalLayout; + +public class MarginWithExpandRatio extends AbstractTestUI { + + @Override + protected void setup(VaadinRequest request) { + TestUtils.injectCSS(this, + ".hugemargin { margin: 10px 20px !important; }"); + + HorizontalLayout hl = new HorizontalLayout(); + addLayoutTest(hl); + hl.setExpandRatio(hl.getComponent(0), 1.0f); + hl.setExpandRatio(hl.getComponent(2), 0.5f); + VerticalLayout vl = new VerticalLayout(); + addLayoutTest(vl); + vl.setExpandRatio(vl.getComponent(0), 1.0f); + vl.setExpandRatio(vl.getComponent(2), 0.5f); + + GridLayout gl = new GridLayout(2, 1); + addLayoutTest(gl); + gl.setColumnExpandRatio(0, 1.0f); + gl.setRowExpandRatio(0, 1.0f); + gl.setColumnExpandRatio(1, 0.5f); + gl.setRowExpandRatio(1, 0.5f); + } + + @Override + protected String getTestDescription() { + return "Layout content overflows if CSS margin used with expand ratio"; + } + + @Override + protected Integer getTicketNumber() { + return 11553; + } + + private void addLayoutTest(Layout l) { + l.setSizeFull(); + + Label lbl = new Label("First (expand ratio 1)"); + lbl.setSizeUndefined(); + l.addComponent(lbl); + + lbl = new Label("Second (margin 10px)"); + lbl.setSizeUndefined(); + lbl.addStyleName("hugemargin"); + l.addComponent(lbl); + + lbl = new Label("Third (margin+xr)"); + lbl.setSizeUndefined(); + lbl.addStyleName("hugemargin"); + l.addComponent(lbl); + + Panel p = new Panel(l.getClass().getSimpleName(), l); + p.setWidth("600px"); + p.setHeight("200px"); + addComponent(p); + } +} |