summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Fix an issue with frozen column count and unhiding. (#11929) (#11932)8.10.3Anna Koskinen2020-03-263-1/+81
| | | | | | * Fix an issue with frozen column count and unhiding. Unhiding logic should take into account that there can be hidden frozen columns that are not the column currently getting shown.
* Add setters to Criterion to fix serialization. (#11926) (#11931)Anna Koskinen2020-03-262-4/+103
| | | Fixes #11909
* Tweaked layouttester tests to be more informative. (#11800) (#11813) (#11925)Anna Koskinen2020-03-24132-33/+495
|
* Simplify Grid sidebar handling. (#11920) (#11924)Anna Koskinen2020-03-241-17/+40
| | | | | | | | | | There is no need to reset the sidebar for every column that is set hidable within the same roundtrip. Because no other layouting depends on the sidebar contents, we can safely delay the reset until all columns have got their hidabiity status updated. As a bonus point, when the reset itself is delayed, the headers have time to get populated and the sidebar button's height can be determined immediately at attach. The reset ensures that attach is called every time a column's hidability is changed.
* Prevent a gap within Grid rows in some resize situations. (#11918) (#11923)Anna Koskinen2020-03-241-3/+25
| | | Fixes #11892
* Trigger re-measure after updating ElementResizeListeners. (#11912) (#11922)Anna Koskinen2020-03-243-0/+76
| | | | | | | | | | | Removing ElementResizeListeners from an element makes it unmeasurable and clears any saved measured values. Adding the listeners back makes the element measurable again but doesn't add it to measuring queue. Measuring needs to happen or any updates to expanded components within a layout (without changes that would trigger full re-measuring of the layout itself) lead to broken expand size calculations with any fixed size elements assumed to have no size. Fixes #10734
* Further tweaks to ComboBox popup positioning. (#11910) (#11921)Anna Koskinen2020-03-243-7/+82
| | | | | | | * Further tweaks to ComboBox popup positioning. - Updated a comment and renamed a private method for better clarity. - Blocked unnecessary position updates. - Added a test for #11866 / #11894.
* Picks 8.10.2 (#11908)8.10.2Zhe Sun2020-03-025-19/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Removing code causing the trouble (#11898) * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: https://github.com/vaadin/framework/issues/11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField * Rewrote debouncing of onResize (#11899) * Rewrote debouncing of onResize Fixes https://github.com/vaadin/framework/issues/11892 * Fixing typo in variable name * Adding missing setPopupPosition(left, top); (#11902) * Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes https://github.com/vaadin/framework/issues/11894 Co-authored-by: Tatu Lund <tatu@vaadin.com>
* Added note to DateField#setRangeStart JavaDoc (#11886)8.10.1Tatu Lund2020-02-201-0/+2
| | | | | | | | * Added note to DateField#setRangeStart JavaDoc * Added additional checking of valid startDate * Reverted previous commit
* Update Chrome version (#11891)Tatu Lund2020-02-201-1/+1
|
* Fix logic of lexicographical comparison of DateField range end (#11885)Tatu Lund2020-02-202-2/+64
| | | | | | | | | | | | | | | | | | | | | | * Fix logic of lexicographical comparison of DateField range end Fix logic of lexicographical comparison of DateField range end with large year numbers ( > 9999) Fixes #11881 * Added tests Purpose of dateFieldRangeYearDigitsIncrease() is to test that rangeEnd works correctly on 4 to 5 digits change boundary Purpose of dateFieldRangeYearBigNumbersPopupOpens() is to test that popup opens also when there is more than 4 digits in year * Fixing typo * Add error message * Set the date of the field in test * Fixing
* Update release note template for 8.10 maintenanceZhe Sun2020-02-191-5/+7
|
* Update release-note template for 8.10 final8.10.0Zhe Sun2020-02-061-3/+3
|
* Cherry picks for 8.10 final release (#11883)Zhe Sun2020-02-044-8/+112
| | | | | | | | | | | | | | | | | * Don't reset date to current at DateField state (e.g. read-only) updates. (#11879) - DateFields with month or year resolution should not get their date reset to current date if the field's state is updated (e.g. by changing read-only status or adding a range). Fixes: #11864, #11605 * Update Navigator.getState() JavaDoc to be more accurate (#11876) Fixes: https://github.com/vaadin/framework/issues/11875 Co-authored-by: Anna Koskinen <Ansku@users.noreply.github.com> Co-authored-by: Tatu Lund <tatu@vaadin.com>
* define central with https8.10.0.beta1Zhe Sun2020-01-161-0/+4
|
* close <ul>Zhe Sun2020-01-161-1/+1
|
* Update release-note for 8.10Zhe Sun2020-01-161-6/+7
|
* add missing since tagZheSun882020-01-161-2/+2
|
* Remove alpha mentioned in the releasenoteZhe Sun2020-01-161-1/+1
|
* TreeDataProvider: Apply filters to children (#11868)Tatu Lund2020-01-163-11/+69
| | | | | Fixes: https://github.com/vaadin/framework/issues/9933 Cherry pick from: https://github.com/vaadin/flow/pull/7317
* Ensure value change happens before shortcuts in compatibility components ↵Anna Koskinen2020-01-153-3/+125
| | | | | (#11871) Fixes #10854
* Making setEditable friendlier (#11869)Tatu Lund2020-01-141-3/+9
| | | | | | | | | | * Making setEditable friendlier The current behavior is not buggy, so this PR is an enhancement Fixes https://github.com/vaadin/framework/issues/8718 * Improved JavaDoc
* Convert DateTimeFieldReadOnlyTest to not rely on screenshots. (#11870)Anna Koskinen2020-01-1313-16/+45
|
* Added Note about TextField in Header cell (#11858)Tatu Lund2020-01-131-0/+7
| | | Fixes https://github.com/vaadin/framework/issues/9089
* Convert DateFieldReadOnlyTest to not rely on screenshots. (#11867)Anna Koskinen2020-01-1013-16/+45
|
* Removed outdated spacer height update from removal process. (#11861)Anna Koskinen2020-01-093-2/+115
| | | | | | * Removed outdated spacer height update from removal process. Fixes #11856
* Added notes in JavaDoc of TEXTFIELD_INLINE_ICON (#11860)Tatu Lund2020-01-081-0/+5
| | | | | | * Added notes in JavaDoc of TEXTFIELD_INLINE_ICON Fixes https://github.com/vaadin/framework/issues/10752 and https://github.com/vaadin/framework/issues/9089
* Fix to RadioButtonGroup readOnly handling. (#11855)Anna Koskinen2019-12-233-1/+248
| | | | | | | | | * Fix to RadioButtonGroup readOnly handling. Updated the connector to use the widget's enabled and readOnly handling as intended. Fixes #11843
* Added helper methods for setting only height or width full. (#11854)Anna Koskinen2019-12-202-2/+34
|
* Added documentation of newly added Binder features (#11845)Tatu Lund2019-12-201-0/+13
|
* Test tweaks (#11851)Anna Koskinen2019-12-202-22/+28
| | | | | | | | | * Test tweaks Less fixed waiting times when there are ways to check that the operation has been performed. This will hopefully improve the stability a bit. * Merge branch 'master' into updateTests20191218
* Improvements to popup positioning for ComboBox within HorizontalLayout. (#11846)Anna Koskinen2019-12-182-8/+138
| | | | | | | | Expand ratio and spacing can cause ComboBox to miscalculate its own position while layouting is still ongoing. Popup should not be repositioned in such circumstances in order to avoid incorrect intermediate states. Continues on #11718
* Chrome updated to 79 (#11847)Anna Koskinen2019-12-181-1/+1
|
* Release notes (#11842)8.10.0.alpha1Anna Koskinen2019-12-091-3/+4
|
* Test tweaks (#11841)Anna Koskinen2019-12-0611-10/+25
| | | | | | | | | | | | | | | | - Use BrowserStack workaround for proper sendKeys functionality on IE11. - TreeGridBigDetailsManagerTest: allow two pixel discrepancy in expected scroll position to accommodate IE. - TreeWideContent: switched from raw type to type inference. - ValoColorPickerInputFormatsTest: switched equals comparison to correct way around. - ResponsiveLayoutUpdateTest: updated screenshots for IE - ColumnCollapsingAndColumnExpansionTest: updated screenshots for IE - ClosingWindowWithBrowserFrameShouldntGenerate404Test: test is incompatible with IE driver, excluded from tested browsers. In manual testing IE doesn't get 404 in the logs with or without the fix associated with this test but there are other client-side exceptions related to focus handling in either case. However, those are out of scope for this particular fix and should be investigated separately.
* Close window on ESC, when maximized button is clicked (#11840)Anastasia Smirnova2019-12-053-4/+78
| | | | | | | | | Fixes #11838 Changes: 1. Close a window when maximized button is focused and ESC is pressed 2. Add additional check for a close button to react to the ESC key press 3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
* Added @since tags, some tweaks to formatting. (#11839)Anna Koskinen2019-12-043-18/+34
|
* Make VaadinService.cleanupSession public (#11738)Knoobie2019-12-031-4/+5
| | | | | | | | to allow for better integration of third party applications handling the destruction of the session. Usage example (see https://vaadin.com/directory/component/cleanupservlet-add-on/overview) "It's possible to close a browser window in such way that neither UI cleanup nor session cleanup will happen until the underlying http session timeouts. This can happen because the design idea for heartbeat is to keep the UI alive, not to ensure timely cleanup, and as such the default check is only performed at the end of each request."
* Simplify Grid scroll handling. (#11835)Anna Koskinen2019-12-033-46/+65
| | | | | | | | | | | | If first attempt at scrolling doesn't succeed it's unlikely that continuing to wait is going to make any difference. Cache should be populated before triggering any actions that depend on the row being visible, otherwise it should be enough to trust that scrollToRow actually scrolls to row and once scrolling is done the row is as much in view as it's going to get. This way we don't get into a situation where Editor never opens because it's still waiting for that one last pixel that can't be achieved thanks to browser zoom causing rounding errors. Continues on #11672
* Make asRequired conditional on binding.setAsRequiredEnabled(..) (#11834)Tatu Lund2019-12-022-4/+60
| | | | | It is a very common use case in complex form that whether a field is required or not, it depends on input on other fields. Hypothetical use case sample could be that we have form for a Product and price of the product is needed except in case the Product's type is Sample. So in that kind of scenarios it would be needed to turn off asRequired() validation easily. The purpose of this enhancement and new binding.setAsRequiredEnabled(..) API is to help implementation of this kind of use cases more easily. https://github.com/vaadin/framework/issues/10709
* Add method writeBeanAsDraft(bean) in Binder (#11833)Tatu Lund2019-11-292-0/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add method writeBeanAsDraft(bean) in Binder With current Binder implementation it is not easy to support Forms, which you want to save as draft, i.e. incomplete. For example there can be big text areas, that require time to fill, or lot of fields. Therefore it is needed to that form can be saved, e.g. to other bean in incomplete state when it is not yet passing validation and this other bean can be persisted to draft storage for further editing in the future. This method helps to achieve that easily. * Add test case for Binder.writeBeanAsDraft(bean) Bind a field with validator, set value that does not pass validator and save, assert that value was saved. * Updating test * Fixing logic flaw in test * Further improvement of the test case * Clarification of the JavaDoc * Fixing typo * JavaDoc language check * Fixing whitespace issue * Fixing whitespaces * Fixing whitespaces * Updating JavaDoc
* Delegate enabled handling to Composite root. (#11832)Anna Koskinen2019-11-263-0/+79
| | | | | | | Otherwise the changed state isn't communicated properly to the client-side in the initial round trip, as the client-side uses the child connector's state directly. Fixes #11831
* Add support for excess slashes within static file request path. (#11827)Anna Koskinen2019-11-222-7/+40
|
* Fix issue where Chrome refused to select text in Table (#11709) (#11818)Anna Koskinen2019-11-211-2/+2
| | | Manual cherry-pick from Vaadin 7.
* Updated local screenshot testing configurations. (#11814)Anna Koskinen2019-11-216-28/+40
| | | | | | | | * A separate screenshot module hasn't been in use for a while but local testing configurations and instructions weren't updated to the new model at the time. Could use some further cleanup but this covers the basics. * Some tweaks to ScreenshotBrowser to get it functional again, although the actions for automatically replacing or adding alternative screenshots still require work and have thus been disabled.
* Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823)Anna Koskinen2019-11-214-1/+56
| | | | | | | | | | | | | The attempt gets blocked later down the line in any case and never reaches the server, but sending it messes up TreeGrid's internal state. It gets stuck waiting for the resolution of the blocked call that can then only be resolved by server-side sending its own expand/collapse request programmatically. Until that happens no further expand/collapse attempts will get sent to server even after the TreeGrid has been enabled again. Tree is also affected as it is built upon TreeGrid. Fixes #11822
* Decode path in getStaticFilePath (#11812)Tatu Lund2019-11-192-5/+26
| | | | | * Decode path in getStaticFilePath Some containers do not decode path when using getPathInfo, in case path has not been decoded there is a risk for path traversal vulnerability.
* Fixing issue with TwinColSelect not correctly retaining visible selection ↵Tatu Lund2019-11-191-3/+32
| | | | | | | (#11799) There is a bug in TwinColSelect loging, it retains selection by indexes not by values after being sorted when new item has been added. This is a fixed by changing updateListBox method to retain the selection as it is being called after selection is being done. Fixes: #11287
* Eliminate un-intuitive NPE (#11802)Tatu Lund2019-11-151-2/+5
| | | | | | * Eliminate un-intuitive NPE Fixes https://github.com/vaadin/framework/issues/10947
* Cherry picks of Binder fixes in Flow (#11758)Tatu Lund2019-11-133-21/+184
| | | | | | | | | | * Cherry picks of Binder fixes in Flow Addresses: https://github.com/vaadin/framework/issues/9000 Addresses: https://github.com/vaadin/framework/issues/11109 These changes are adopted from https://github.com/vaadin/flow/pull/4138 and https://github.com/vaadin/flow/pull/6757