summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Test tweaks (#11851)Anna Koskinen2019-12-202-22/+28
| | | | | | | | | * Test tweaks Less fixed waiting times when there are ways to check that the operation has been performed. This will hopefully improve the stability a bit. * Merge branch 'master' into updateTests20191218
* Improvements to popup positioning for ComboBox within HorizontalLayout. (#11846)Anna Koskinen2019-12-182-8/+138
| | | | | | | | Expand ratio and spacing can cause ComboBox to miscalculate its own position while layouting is still ongoing. Popup should not be repositioned in such circumstances in order to avoid incorrect intermediate states. Continues on #11718
* Chrome updated to 79 (#11847)Anna Koskinen2019-12-181-1/+1
|
* Release notes (#11842)8.10.0.alpha1Anna Koskinen2019-12-091-3/+4
|
* Test tweaks (#11841)Anna Koskinen2019-12-0611-10/+25
| | | | | | | | | | | | | | | | - Use BrowserStack workaround for proper sendKeys functionality on IE11. - TreeGridBigDetailsManagerTest: allow two pixel discrepancy in expected scroll position to accommodate IE. - TreeWideContent: switched from raw type to type inference. - ValoColorPickerInputFormatsTest: switched equals comparison to correct way around. - ResponsiveLayoutUpdateTest: updated screenshots for IE - ColumnCollapsingAndColumnExpansionTest: updated screenshots for IE - ClosingWindowWithBrowserFrameShouldntGenerate404Test: test is incompatible with IE driver, excluded from tested browsers. In manual testing IE doesn't get 404 in the logs with or without the fix associated with this test but there are other client-side exceptions related to focus handling in either case. However, those are out of scope for this particular fix and should be investigated separately.
* Close window on ESC, when maximized button is clicked (#11840)Anastasia Smirnova2019-12-053-4/+78
| | | | | | | | | Fixes #11838 Changes: 1. Close a window when maximized button is focused and ESC is pressed 2. Add additional check for a close button to react to the ESC key press 3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
* Added @since tags, some tweaks to formatting. (#11839)Anna Koskinen2019-12-043-18/+34
|
* Make VaadinService.cleanupSession public (#11738)Knoobie2019-12-031-4/+5
| | | | | | | | to allow for better integration of third party applications handling the destruction of the session. Usage example (see https://vaadin.com/directory/component/cleanupservlet-add-on/overview) "It's possible to close a browser window in such way that neither UI cleanup nor session cleanup will happen until the underlying http session timeouts. This can happen because the design idea for heartbeat is to keep the UI alive, not to ensure timely cleanup, and as such the default check is only performed at the end of each request."
* Simplify Grid scroll handling. (#11835)Anna Koskinen2019-12-033-46/+65
| | | | | | | | | | | | If first attempt at scrolling doesn't succeed it's unlikely that continuing to wait is going to make any difference. Cache should be populated before triggering any actions that depend on the row being visible, otherwise it should be enough to trust that scrollToRow actually scrolls to row and once scrolling is done the row is as much in view as it's going to get. This way we don't get into a situation where Editor never opens because it's still waiting for that one last pixel that can't be achieved thanks to browser zoom causing rounding errors. Continues on #11672
* Make asRequired conditional on binding.setAsRequiredEnabled(..) (#11834)Tatu Lund2019-12-022-4/+60
| | | | | It is a very common use case in complex form that whether a field is required or not, it depends on input on other fields. Hypothetical use case sample could be that we have form for a Product and price of the product is needed except in case the Product's type is Sample. So in that kind of scenarios it would be needed to turn off asRequired() validation easily. The purpose of this enhancement and new binding.setAsRequiredEnabled(..) API is to help implementation of this kind of use cases more easily. https://github.com/vaadin/framework/issues/10709
* Add method writeBeanAsDraft(bean) in Binder (#11833)Tatu Lund2019-11-292-0/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add method writeBeanAsDraft(bean) in Binder With current Binder implementation it is not easy to support Forms, which you want to save as draft, i.e. incomplete. For example there can be big text areas, that require time to fill, or lot of fields. Therefore it is needed to that form can be saved, e.g. to other bean in incomplete state when it is not yet passing validation and this other bean can be persisted to draft storage for further editing in the future. This method helps to achieve that easily. * Add test case for Binder.writeBeanAsDraft(bean) Bind a field with validator, set value that does not pass validator and save, assert that value was saved. * Updating test * Fixing logic flaw in test * Further improvement of the test case * Clarification of the JavaDoc * Fixing typo * JavaDoc language check * Fixing whitespace issue * Fixing whitespaces * Fixing whitespaces * Updating JavaDoc
* Delegate enabled handling to Composite root. (#11832)Anna Koskinen2019-11-263-0/+79
| | | | | | | Otherwise the changed state isn't communicated properly to the client-side in the initial round trip, as the client-side uses the child connector's state directly. Fixes #11831
* Add support for excess slashes within static file request path. (#11827)Anna Koskinen2019-11-222-7/+40
|
* Fix issue where Chrome refused to select text in Table (#11709) (#11818)Anna Koskinen2019-11-211-2/+2
| | | Manual cherry-pick from Vaadin 7.
* Updated local screenshot testing configurations. (#11814)Anna Koskinen2019-11-216-28/+40
| | | | | | | | * A separate screenshot module hasn't been in use for a while but local testing configurations and instructions weren't updated to the new model at the time. Could use some further cleanup but this covers the basics. * Some tweaks to ScreenshotBrowser to get it functional again, although the actions for automatically replacing or adding alternative screenshots still require work and have thus been disabled.
* Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823)Anna Koskinen2019-11-214-1/+56
| | | | | | | | | | | | | The attempt gets blocked later down the line in any case and never reaches the server, but sending it messes up TreeGrid's internal state. It gets stuck waiting for the resolution of the blocked call that can then only be resolved by server-side sending its own expand/collapse request programmatically. Until that happens no further expand/collapse attempts will get sent to server even after the TreeGrid has been enabled again. Tree is also affected as it is built upon TreeGrid. Fixes #11822
* Decode path in getStaticFilePath (#11812)Tatu Lund2019-11-192-5/+26
| | | | | * Decode path in getStaticFilePath Some containers do not decode path when using getPathInfo, in case path has not been decoded there is a risk for path traversal vulnerability.
* Fixing issue with TwinColSelect not correctly retaining visible selection ↵Tatu Lund2019-11-191-3/+32
| | | | | | | (#11799) There is a bug in TwinColSelect loging, it retains selection by indexes not by values after being sorted when new item has been added. This is a fixed by changing updateListBox method to retain the selection as it is being called after selection is being done. Fixes: #11287
* Eliminate un-intuitive NPE (#11802)Tatu Lund2019-11-151-2/+5
| | | | | | * Eliminate un-intuitive NPE Fixes https://github.com/vaadin/framework/issues/10947
* Cherry picks of Binder fixes in Flow (#11758)Tatu Lund2019-11-133-21/+184
| | | | | | | | | | * Cherry picks of Binder fixes in Flow Addresses: https://github.com/vaadin/framework/issues/9000 Addresses: https://github.com/vaadin/framework/issues/11109 These changes are adopted from https://github.com/vaadin/flow/pull/4138 and https://github.com/vaadin/flow/pull/6757
* Reduce excess positioning calls for ComboBox popup. (#11808)Anna Koskinen2019-11-131-8/+21
| | | | | | | | | | | | | - If an open popup is reset to its default position on every update from the server before getting adjusted again to the actual expected position, on heavier applications some of those intermediate positions might get rendered. If the ComboBox is positioned at the right edge and the popup contents are longer than the input field (i.e. popup should open to the left, not right) this might cause flickering. - Setting the default position is only actually needed when the popup is opened in order to give it a baseline, otherwise it's better to simply adjust the position if needed. Continues on #11718
* Added missing constructor with scanNestedDefinitions option (#11801)Tatu Lund2019-11-121-1/+19
| | | | | | * Added missing constructor with scanNestedDefinitions option Addresses https://github.com/vaadin/framework/issues/10949
* Use APPLICATION_SCOPE for the session lock (#11792)Tatu Lund2019-11-123-4/+44
| | | | | | | | | | The Vaadin session itself is also stored in APPLICATION_SCOPE. The default scope is PORTLET_SCOPE, so lock would be otherwise not be in sync with the session. To be able to do this, relevant methods in VaadinService are made protected so that VaadinPortletService can override them. Fixes #11611
* Fixing issue with Push stopping working in some circumstances (#11791)Tatu Lund2019-11-052-2/+17
| | | | | | | | | | | | | | * Fixing issue with Push stopping working in some circumstances If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. This PR supercedes https://github.com/vaadin/framework/pull/11786 Fixes #11702, #7719 * Call onResynchronize() in MessageHandler * Optimizing
* Check actual Grid selection instead of relying on allSelected flag. (#11787)Anna Koskinen2019-11-044-9/+153
| | | | | | | | The checkbox for selecting all rows only selects all the rows that have not been filtered out. Changing the filtering does not change the selection or the checkbox state so assuming that all rows are selected simply because the checkbox has been checked cannot work. Fixes #11479
* Removed a duplicated word in a note. (#11785)Anna Koskinen2019-11-041-1/+1
|
* Added note to setTemplateContents JavaDoc (#11752)Tatu Lund2019-11-021-0/+3
| | | Addresses https://github.com/vaadin/framework/issues/1262
* Fix a timing issue in ComboBox filtering via paste using mouse. (#11780)Anna Koskinen2019-10-312-1/+69
| | | | | | The filtering needs to be delayed, otherwise it's performed before the new filter text is available and the old filter text is used instead. Fixes #11779
* Switch from an assert to logging and return in Grid.onBrowserEvent (#11778)Anna Koskinen2019-10-301-2/+5
| | | | | | | | | | | | - If the Grid has frozen columns zooming can cause the regular column cells to be ever so slightly out of sync with their corresponding rows. This difference is not noticeable to naked eye but is big enough that it's possible to hover over the row instead of the cell, which causes an assertion error and a big ugly error popup. Switching to logging retains the information delivered by the assertion error for developer purposes but makes the end user experience smoother. - Can be tested manually with GridColumnFrozenColumn test UI. Fixes #11198
* Added 1px tolerance to ScrollbarBundle's internal sanity check. (#11777)Anna Koskinen2019-10-291-3/+5
| | | | | | | | | | | | | | | * Added 1px tolerance to ScrollbarBundle's internal sanity check. Requiring exact match can cause this check to fail when the browser is zoomed since rounding is involved. This can in turn block some features like opening of Grid Editor from working until some more scrolling happens and the minute inconsistency is fixed. Can be tested manually using GridEditorUI, depending on the environment different amounts of zooming may be required for the problem to manifest. Fixes #11672
* Improvements to ScrollDestination sanity checks (#11772)Anna Koskinen2019-10-282-8/+118
| | | | | | | | - The new top row logical index should always be within the logical range and high enough up to avoid leaving a gap if possible. - Added regression testing for using the different scroll destination types for scrolling to the top and to the bottom by index. Fixes #11732
* Added missing NOTIFICATION_DARK (#11770)Tatu Lund2019-10-281-2/+8
| | | | | And corrected couple of typos Addresses https://github.com/vaadin/framework/issues/11492
* Fix the end limit of the allowed scrollTo rows. (#11771)Anna Koskinen2019-10-281-1/+1
| | | | | - Row index counts up from zero, data provider size counts up from one, as one would expect. If the two match we are already past the available range.
* Made JavaDoc of updateSelection more precise (#11768)Tatu Lund2019-10-281-1/+2
| | | Addresses https://github.com/vaadin/framework/issues/11520
* Tweak a test to open Grid details row by clicking cell instead of row. (#11764)Anna Koskinen2019-10-251-7/+10
|
* Update chrome version to 78 (#11765)Zhe Sun2019-10-251-1/+1
|
* When ComboBox popup opens to the left accommodate margin/border/padding. ↵Anna Koskinen2019-10-233-8/+73
| | | | | (#11755) Fixes #11718
* Make sure expanding/collapsing updates expected cache size. (#11753)Anna Koskinen2019-10-223-0/+165
| | | | | | | | * Make sure expanding/collapsing updates expected cache size. Fixes #11749 * Merge branch 'master' into issue11749
* Make cancellation of uploads work regardless of Push configuration (#11743)Willem Verstraeten2019-10-216-13/+128
| | | | | | | | | | | | | | - Checking the push configuration outside of session lock threw an AssertionError, so the push configuration is not checked anymore. - The original problem with cancelling Upload was due to a subtle ordering issue that depended on the Push configuration. In the case of PushMode.AUTOMATIC, a new StreamVariable was added by the `Upload` component _before_ the `FileUploadHandler` got a chance to remove the old `StreamVariable`. As a result, the `FileUploadHandler` actually removed the fresh `StreamVariable`, breaking future uploads. Fixes #11682
* Add note to setRenderer() JavaDoc about presentation provider (#11751)Tatu Lund2019-10-211-0/+3
| | | Addresses https://github.com/vaadin/framework/issues/10277
* Upload should preserve MIMEType after first selection (#11745)Anastasia Smirnova2019-10-163-0/+162
| | | | | | | | | | | | | | | | * Upload should preserve MIMEType after first selection Fix #11698 Automated test is not run locally, need to continue with it * Remove unused imports * Add sleep time in testing purposes * Getting a new instance of an input, after file is downloaded Exclude IE from tests. Throws https://stackoverflow.com/questions/23883071/unhandled-alert-exception-modal-dialog-present-selenium , but checked manually and it works
* Make sure Firefox for iOS isn't detected as too old to function. (#11739)Felix Fontein2019-10-031-2/+6
| | | Change-Id: Iea13b958356b0246586bcb7e9969bc26db43bb96
* Catch and handle IllegalStateException (#11733)Tatu Lund2019-10-031-11/+18
| | | | | | | | * Catch and handle IllegalStateException Fixes https://github.com/vaadin/framework/issues/11730 * Renaming variables
* Added note in JavaDoc of removeColumn (#11725)Tatu Lund2019-10-031-0/+3
| | | | | | | | | | * Added note in JavaDoc of removeColumn https://github.com/vaadin/framework/issues/11722 * Merge branch 'master' into fix11722 * Merge branch 'master' into fix11722
* Update context menu addon version (#11735)Zhe Sun2019-10-021-1/+1
|
* Update Chrome version to 77 (#11727)Zhe Sun2019-09-2413-1/+1
| | | | | | | | * Update Chrome version to 77 * update screenshots * update screenshots
* Update release note to mention Java 11 support (#11697)Zhe Sun2019-09-091-2/+3
| | | | | | * Update release note to mention Java 11 support * Update explanation about client side code
* Removal of data communicator needs to happen before call to super.remove() ↵Tatu Lund2019-09-091-2/+2
| | | | | | | (#11710) Removal of data communicator needs to happen before call to super.remove() since super.remove() sets parent to null causing the NPE. Fixes https://github.com/vaadin/framework/issues/11617
* Correct usage of String.format(..) (#11704)Tatu Lund2019-09-091-5/+5
| | | Fixes https://github.com/vaadin/framework/issues/11701
* Remove double negation (#11713)eriklumme2019-09-061-1/+1
| | | "doesn't not" should be either "doesn't" or "does not".
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-23 00:55:56 +0000