summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fixing issue with TwinColSelect not correctly retaining visible selection ↵Tatu Lund2019-11-191-3/+32
| | | | | | | (#11799) There is a bug in TwinColSelect loging, it retains selection by indexes not by values after being sorted when new item has been added. This is a fixed by changing updateListBox method to retain the selection as it is being called after selection is being done. Fixes: #11287
* Eliminate un-intuitive NPE (#11802)Tatu Lund2019-11-151-2/+5
| | | | | | * Eliminate un-intuitive NPE Fixes https://github.com/vaadin/framework/issues/10947
* Cherry picks of Binder fixes in Flow (#11758)Tatu Lund2019-11-133-21/+184
| | | | | | | | | | * Cherry picks of Binder fixes in Flow Addresses: https://github.com/vaadin/framework/issues/9000 Addresses: https://github.com/vaadin/framework/issues/11109 These changes are adopted from https://github.com/vaadin/flow/pull/4138 and https://github.com/vaadin/flow/pull/6757
* Reduce excess positioning calls for ComboBox popup. (#11808)Anna Koskinen2019-11-131-8/+21
| | | | | | | | | | | | | - If an open popup is reset to its default position on every update from the server before getting adjusted again to the actual expected position, on heavier applications some of those intermediate positions might get rendered. If the ComboBox is positioned at the right edge and the popup contents are longer than the input field (i.e. popup should open to the left, not right) this might cause flickering. - Setting the default position is only actually needed when the popup is opened in order to give it a baseline, otherwise it's better to simply adjust the position if needed. Continues on #11718
* Added missing constructor with scanNestedDefinitions option (#11801)Tatu Lund2019-11-121-1/+19
| | | | | | * Added missing constructor with scanNestedDefinitions option Addresses https://github.com/vaadin/framework/issues/10949
* Use APPLICATION_SCOPE for the session lock (#11792)Tatu Lund2019-11-123-4/+44
| | | | | | | | | | The Vaadin session itself is also stored in APPLICATION_SCOPE. The default scope is PORTLET_SCOPE, so lock would be otherwise not be in sync with the session. To be able to do this, relevant methods in VaadinService are made protected so that VaadinPortletService can override them. Fixes #11611
* Fixing issue with Push stopping working in some circumstances (#11791)Tatu Lund2019-11-052-2/+17
| | | | | | | | | | | | | | * Fixing issue with Push stopping working in some circumstances If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. This PR supercedes https://github.com/vaadin/framework/pull/11786 Fixes #11702, #7719 * Call onResynchronize() in MessageHandler * Optimizing
* Check actual Grid selection instead of relying on allSelected flag. (#11787)Anna Koskinen2019-11-044-9/+153
| | | | | | | | The checkbox for selecting all rows only selects all the rows that have not been filtered out. Changing the filtering does not change the selection or the checkbox state so assuming that all rows are selected simply because the checkbox has been checked cannot work. Fixes #11479
* Removed a duplicated word in a note. (#11785)Anna Koskinen2019-11-041-1/+1
|
* Added note to setTemplateContents JavaDoc (#11752)Tatu Lund2019-11-021-0/+3
| | | Addresses https://github.com/vaadin/framework/issues/1262
* Fix a timing issue in ComboBox filtering via paste using mouse. (#11780)Anna Koskinen2019-10-312-1/+69
| | | | | | The filtering needs to be delayed, otherwise it's performed before the new filter text is available and the old filter text is used instead. Fixes #11779
* Switch from an assert to logging and return in Grid.onBrowserEvent (#11778)Anna Koskinen2019-10-301-2/+5
| | | | | | | | | | | | - If the Grid has frozen columns zooming can cause the regular column cells to be ever so slightly out of sync with their corresponding rows. This difference is not noticeable to naked eye but is big enough that it's possible to hover over the row instead of the cell, which causes an assertion error and a big ugly error popup. Switching to logging retains the information delivered by the assertion error for developer purposes but makes the end user experience smoother. - Can be tested manually with GridColumnFrozenColumn test UI. Fixes #11198
* Added 1px tolerance to ScrollbarBundle's internal sanity check. (#11777)Anna Koskinen2019-10-291-3/+5
| | | | | | | | | | | | | | | * Added 1px tolerance to ScrollbarBundle's internal sanity check. Requiring exact match can cause this check to fail when the browser is zoomed since rounding is involved. This can in turn block some features like opening of Grid Editor from working until some more scrolling happens and the minute inconsistency is fixed. Can be tested manually using GridEditorUI, depending on the environment different amounts of zooming may be required for the problem to manifest. Fixes #11672
* Improvements to ScrollDestination sanity checks (#11772)Anna Koskinen2019-10-282-8/+118
| | | | | | | | - The new top row logical index should always be within the logical range and high enough up to avoid leaving a gap if possible. - Added regression testing for using the different scroll destination types for scrolling to the top and to the bottom by index. Fixes #11732
* Added missing NOTIFICATION_DARK (#11770)Tatu Lund2019-10-281-2/+8
| | | | | And corrected couple of typos Addresses https://github.com/vaadin/framework/issues/11492
* Fix the end limit of the allowed scrollTo rows. (#11771)Anna Koskinen2019-10-281-1/+1
| | | | | - Row index counts up from zero, data provider size counts up from one, as one would expect. If the two match we are already past the available range.
* Made JavaDoc of updateSelection more precise (#11768)Tatu Lund2019-10-281-1/+2
| | | Addresses https://github.com/vaadin/framework/issues/11520
* Tweak a test to open Grid details row by clicking cell instead of row. (#11764)Anna Koskinen2019-10-251-7/+10
|
* Update chrome version to 78 (#11765)Zhe Sun2019-10-251-1/+1
|
* When ComboBox popup opens to the left accommodate margin/border/padding. ↵Anna Koskinen2019-10-233-8/+73
| | | | | (#11755) Fixes #11718
* Make sure expanding/collapsing updates expected cache size. (#11753)Anna Koskinen2019-10-223-0/+165
| | | | | | | | * Make sure expanding/collapsing updates expected cache size. Fixes #11749 * Merge branch 'master' into issue11749
* Make cancellation of uploads work regardless of Push configuration (#11743)Willem Verstraeten2019-10-216-13/+128
| | | | | | | | | | | | | | - Checking the push configuration outside of session lock threw an AssertionError, so the push configuration is not checked anymore. - The original problem with cancelling Upload was due to a subtle ordering issue that depended on the Push configuration. In the case of PushMode.AUTOMATIC, a new StreamVariable was added by the `Upload` component _before_ the `FileUploadHandler` got a chance to remove the old `StreamVariable`. As a result, the `FileUploadHandler` actually removed the fresh `StreamVariable`, breaking future uploads. Fixes #11682
* Add note to setRenderer() JavaDoc about presentation provider (#11751)Tatu Lund2019-10-211-0/+3
| | | Addresses https://github.com/vaadin/framework/issues/10277
* Upload should preserve MIMEType after first selection (#11745)Anastasia Smirnova2019-10-163-0/+162
| | | | | | | | | | | | | | | | * Upload should preserve MIMEType after first selection Fix #11698 Automated test is not run locally, need to continue with it * Remove unused imports * Add sleep time in testing purposes * Getting a new instance of an input, after file is downloaded Exclude IE from tests. Throws https://stackoverflow.com/questions/23883071/unhandled-alert-exception-modal-dialog-present-selenium , but checked manually and it works
* Make sure Firefox for iOS isn't detected as too old to function. (#11739)Felix Fontein2019-10-031-2/+6
| | | Change-Id: Iea13b958356b0246586bcb7e9969bc26db43bb96
* Catch and handle IllegalStateException (#11733)Tatu Lund2019-10-031-11/+18
| | | | | | | | * Catch and handle IllegalStateException Fixes https://github.com/vaadin/framework/issues/11730 * Renaming variables
* Added note in JavaDoc of removeColumn (#11725)Tatu Lund2019-10-031-0/+3
| | | | | | | | | | * Added note in JavaDoc of removeColumn https://github.com/vaadin/framework/issues/11722 * Merge branch 'master' into fix11722 * Merge branch 'master' into fix11722
* Update context menu addon version (#11735)Zhe Sun2019-10-021-1/+1
|
* Update Chrome version to 77 (#11727)Zhe Sun2019-09-2413-1/+1
| | | | | | | | * Update Chrome version to 77 * update screenshots * update screenshots
* Update release note to mention Java 11 support (#11697)Zhe Sun2019-09-091-2/+3
| | | | | | * Update release note to mention Java 11 support * Update explanation about client side code
* Removal of data communicator needs to happen before call to super.remove() ↵Tatu Lund2019-09-091-2/+2
| | | | | | | (#11710) Removal of data communicator needs to happen before call to super.remove() since super.remove() sets parent to null causing the NPE. Fixes https://github.com/vaadin/framework/issues/11617
* Correct usage of String.format(..) (#11704)Tatu Lund2019-09-091-5/+5
| | | Fixes https://github.com/vaadin/framework/issues/11701
* Remove double negation (#11713)eriklumme2019-09-061-1/+1
| | | "doesn't not" should be either "doesn't" or "does not".
* Fix scrollTo for destination START and END and add regression testing. (#11707)Anna Koskinen2019-09-053-48/+356
| | | | | | | | | | | - Initial implementation erroneously assumed that ScrollDestination.START would only be used for scrolling up and ScrollDestination.END for scrolling down. That's obviously not what they are for, otherwise everyone would be using ScrollDestination.ANY. - Moved actual scrolling to within the helper method that originally only calculated the new scroll position. Parent method became too long otherwise. Fixes #11706
* Updated row and spacer handling for Escalator (#11438)Anna Koskinen2019-08-2917-1078/+3277
| | | | | | | | | | | | | | | | | | | | | | | Updated row and spacer handling for Escalator. Main changes: - Spacers are only maintained and checked for rows that have DOM representation, and not at all if there is no details generator. This gives notable performance improvements to some particularly large Grids - Escalator no longer tries to trim away any rows that don't fit within the viewport just because a details row gets opened in Grid. This leads to some increase in simultaneous DOM elements, but simplifies the logic considerably. For example opening or closing details rows doesn't require checking the overall content validity beyond the details row itself anymore, but some repositioning at most. There are also no longer any orphaned spacers without corresponding DOM rows. - Spacers are better integrated into the overall position calculations. - Some public methods that are no longer used by Escalator or have changed functionality or order of operations. Any extending classes that tap into row, spacer, or scroll position handling are likely to need reworking after this update. - Auto-detecting row height is delayed until Escalator is both attached and displayed.
* Read-only styles shouldn't override borderless background styles. (#11692)Anna Koskinen2019-08-1614-14/+179
| | | | | | | | | | | * Read-only styles shouldn't override borderless background styles. - Fixed for ComboBox and DateField styles, other tested components already do it right. Fixes #11671 * Merge branch 'master' into issue11671
* Add explicit handling of ctrl-a (#11693)Tatu Lund2019-08-123-0/+65
| | | | | | | | * Add explicit handling of ctrl-a Fixes https://github.com/vaadin/framework/issues/11678 * Adds test case and formatting the code
* Update Chrome version, snapshots and fix tests (#11684)Zhe Sun2019-08-05199-42/+73
|
* Add a missing letter (#11676)Anastasia Smirnova2019-07-301-1/+1
| | | Fixes https://github.com/vaadin/framework/issues/11409
* Update the since tag (#11675)Zhe Sun2019-07-306-6/+6
| | | | * Update the since tag
* Update Spring addon to 3.2.1 (#11670)Zhe Sun2019-07-301-1/+1
|
* Update screenshot (#11669)Zhe Sun2019-07-301-0/+0
|
* Apply offset to column index depending on presense of selection column (#11667)Tatu Lund2019-07-302-1/+72
| | | | | | | | * Apply offset to column index depending on presense of selection column After testing this manually I noticed that offset correction needs to be negative * Add the testing UI
* Ensure the upload button has been disabled when set Enabled calling from ↵Zhe Sun2019-07-293-0/+306
| | | | | | | | | succeedL… (#11655) * Ensure the upload button has been disabled when calling from succeedListener with Push enabled * Add Tests to verify
* Prevent excessive getLogger() calls from markAsDirty() (#11664)Leif Åstrand2019-07-291-15/+24
| | | Fixes #10339
* Update to 8.10-SNAPSHOT (#11657)Zhe Sun2019-07-2966-73/+73
|
* Use https for Maven repositories (#11668)Stéphane Nicoll2019-07-2912-16/+16
| | | | * Use https for Maven repositories
* Ensure that VComboBox.selectedOptionKey gets initial selection. (#11665)Anna Koskinen2019-07-243-2/+91
| | | Fixes #10741
* Improvements to detail row index handling. (#11345)Anna Koskinen2019-07-1611-11/+1233
| | | | | | - Escalator should notify when an existing details row is moved to a new index. - Grid and DetailsManagerConnector should update their internal indexing when details manager index changes in Escalator.
* 11642 refresh pagelength 0 combobox items after dataprovider update (#11653)Olli Tietäväinen2019-07-126-6/+223
| | | | | | * Fixes #11642. ComboBox with pageLength 0 should be updated if DataProvider changes * added comments, fixed imports
generated by cgit v1.2.3 (git 2.39.1) at 2025-03-24 08:40:21 +0000