aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add support for excess slashes within static file request path. (#11827) ↵8.9.3Anna Koskinen2019-11-222-7/+40
| | | | (#11829)
* Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823) ↵Anna Koskinen2019-11-224-1/+56
| | | | | | | | | | | | | | | (#11828) The attempt gets blocked later down the line in any case and never reaches the server, but sending it messes up TreeGrid's internal state. It gets stuck waiting for the resolution of the blocked call that can then only be resolved by server-side sending its own expand/collapse request programmatically. Until that happens no further expand/collapse attempts will get sent to server even after the TreeGrid has been enabled again. Tree is also affected as it is built upon TreeGrid. Fixes #11822
* Comment out the beta version statements (#11825)Zhe Sun2019-11-211-1/+1
|
* Decode path in getStaticFilePath (#11812) (#11817)Anna Koskinen2019-11-192-5/+26
| | | | Some containers do not decode path when using getPathInfo, in case path has not been decoded there is a risk for path traversal vulnerability.
* Fix for TwinColSelect not correctly retaining visible selection (#11799) ↵Anna Koskinen2019-11-191-3/+32
| | | | | | | (#11816) There is a bug in TwinColSelect loging, it retains selection by indexes not by values after being sorted when new item has been added. This is a fixed by changing updateListBox method to retain the selection as it is being called after selection is being done. Fixes: #11287
* Eliminate un-intuitive NPE (#11802) (#11815)Anna Koskinen2019-11-151-2/+5
| | | | | * Eliminate un-intuitive NPE Fixes https://github.com/vaadin/framework/issues/10947
* Reduce excess positioning calls for ComboBox popup. (#11808) (#11809)Anna Koskinen2019-11-141-8/+21
| | | | | | | | | | | | | - If an open popup is reset to its default position on every update from the server before getting adjusted again to the actual expected position, on heavier applications some of those intermediate positions might get rendered. If the ComboBox is positioned at the right edge and the popup contents are longer than the input field (i.e. popup should open to the left, not right) this might cause flickering. - Setting the default position is only actually needed when the popup is opened in order to give it a baseline, otherwise it's better to simply adjust the position if needed. Continues on #11718
* Use APPLICATION_SCOPE for the session lock (#11792) (#11803)Anna Koskinen2019-11-123-4/+44
| | | | | | | | | | The Vaadin session itself is also stored in APPLICATION_SCOPE. The default scope is PORTLET_SCOPE, so lock would otherwise not be in sync with the session. To be able to do this, relevant methods in VaadinService are made protected so that VaadinPortletService can override them. Fixes #11611
* Fixing issue with Push stopping working in some circumstances (#11791) (#11795)Anna Koskinen2019-11-062-2/+17
| | | | | | | * Fixing issue with Push stopping working in some circumstances If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. Fixes #11702, #7719
* Check actual Grid selection instead of relying on allSelected flag. (#11787) ↵Anna Koskinen2019-11-064-9/+153
| | | | | | | | | | (#11790) The checkbox for selecting all rows only selects all the rows that have not been filtered out. Changing the filtering does not change the selection or the checkbox state so assuming that all rows are selected simply because the checkbox has been checked cannot work. Fixes #11479
* Added note to setTemplateContents JavaDoc (#11752) (#11788)Anna Koskinen2019-11-051-0/+3
| | | Addresses https://github.com/vaadin/framework/issues/1262
* Removed a duplicated word in a note. (#11785) (#11789)Anna Koskinen2019-11-041-1/+1
|
* Fix a timing issue in ComboBox filtering via paste using mouse. (#11780) ↵Anna Koskinen2019-11-012-1/+69
| | | | | | | | (#11784) The filtering needs to be delayed, otherwise it's performed before the new filter text is available and the old filter text is used instead. Fixes #11779
* Switch from an assert to logging and return in Grid.onBrowserEvent (#11778) ↵Anna Koskinen2019-10-311-2/+5
| | | | | | | | | | | | | | (#11782) - If the Grid has frozen columns zooming can cause the regular column cells to be ever so slightly out of sync with their corresponding rows. This difference is not noticeable to naked eye but is big enough that it's possible to hover over the row instead of the cell, which causes an assertion error and a big ugly error popup. Switching to logging retains the information delivered by the assertion error for developer purposes but makes the end user experience smoother. - Can be tested manually with GridColumnFrozenColumn test UI. Fixes #11198
* Added 1px tolerance to ScrollbarBundle's internal sanity check. (#11777) ↵Anna Koskinen2019-10-311-3/+5
| | | | | | | | | | | | | | | | (#11781) * Added 1px tolerance to ScrollbarBundle's internal sanity check. Requiring exact match can cause this check to fail when the browser is zoomed since rounding is involved. This can in turn block some features like opening of Grid Editor from working until some more scrolling happens and the minute inconsistency is fixed. Can be tested manually using GridEditorUI, depending on the environment different amounts of zooming may be required for the problem to manifest. Fixes #11672
* Improvements to ScrollDestination sanity checks (#11772) (#11776)8.9.2Anna Koskinen2019-10-282-8/+118
| | | | | | | | - The new top row logical index should always be within the logical range and high enough up to avoid leaving a gap if possible. - Added regression testing for using the different scroll destination types for scrolling to the top and to the bottom by index. Fixes #11732
* Made JavaDoc of updateSelection more precise (#11768) (#11773)Anna Koskinen2019-10-281-1/+2
| | | Addresses https://github.com/vaadin/framework/issues/11520
* Added missing NOTIFICATION_DARK (#11770) (#11775)Anna Koskinen2019-10-281-2/+8
| | | | | And corrected couple of typos Addresses https://github.com/vaadin/framework/issues/11492
* Fix the end limit of the allowed scrollTo rows. (#11771) (#11774)Anna Koskinen2019-10-281-1/+1
| | | | | | | | * Fix the end limit of the allowed scrollTo rows. (#11771) - Row index counts up from zero, data provider size counts up from one, as one would expect. If the two match we are already past the available range.
* Add note to setRenderer() JavaDoc about presentation provider (#11751) (#11763)Anna Koskinen2019-10-251-0/+3
| | | Addresses https://github.com/vaadin/framework/issues/10277
* Tweak a test to open Grid details row by clicking cell instead of row. (#11767)Anna Koskinen2019-10-251-7/+10
|
* Update chrome version to 78 (#11765) (#11766)Anna Koskinen2019-10-251-1/+1
|
* When ComboBox popup opens to the left accommodate margin/border/padding. ↵Anna Koskinen2019-10-243-8/+73
| | | | | (#11755) (#11762) Fixes #11718
* Make cancellation of uploads work regardless of Push configuration (#11743) ↵Anna Koskinen2019-10-246-13/+128
| | | | | | | | | | | | | | | | (#11760) - Checking the push configuration outside of session lock threw an AssertionError, so the push configuration is not checked anymore. - The original problem with cancelling Upload was due to a subtle ordering issue that depended on the Push configuration. In the case of PushMode.AUTOMATIC, a new StreamVariable was added by the `Upload` component _before_ the `FileUploadHandler` got a chance to remove the old `StreamVariable`. As a result, the `FileUploadHandler` actually removed the fresh `StreamVariable`, breaking future uploads. Fixes #11682
* Make sure expanding/collapsing updates expected cache size. (#11753) (#11761)Anna Koskinen2019-10-243-0/+165
| | | Fixes #11749
* Upload should preserve MIMEType after first selection (#11745) (#11759)Anna Koskinen2019-10-243-0/+162
| | | | | | | | | | | | | * Upload should preserve MIMEType after first selection Fix #11698 * Remove unused imports * Add sleep time in testing purposes * Getting a new instance of an input, after file is downloaded Exclude IE from tests. Throws https://stackoverflow.com/questions/23883071/unhandled-alert-exception-modal-dialog-present-selenium , but checked manually and it works
* Update release-note for maintenance8.9.1Zhe Sun2019-10-041-2/+2
|
* Correct usage of String.format(..) (#11704)Tatu Lund2019-10-041-5/+5
| | | Fixes https://github.com/vaadin/framework/issues/11701
* Removal of data communicator needs to happen before call to super.remove() ↵Tatu Lund2019-10-041-2/+2
| | | | | | | (#11710) Removal of data communicator needs to happen before call to super.remove() since super.remove() sets parent to null causing the NPE. Fixes https://github.com/vaadin/framework/issues/11617
* Added note in JavaDoc of removeColumn (#11725)Tatu Lund2019-10-041-0/+3
| | | | | | | | | | * Added note in JavaDoc of removeColumn https://github.com/vaadin/framework/issues/11722 * Merge branch 'master' into fix11722 * Merge branch 'master' into fix11722
* Catch and handle IllegalStateException (#11733)Tatu Lund2019-10-041-11/+18
| | | | | | | | * Catch and handle IllegalStateException Fixes https://github.com/vaadin/framework/issues/11730 * Renaming variables
* Make sure Firefox for iOS isn't detected as too old to function. (#11739)Felix Fontein2019-10-041-2/+6
| | | Change-Id: Iea13b958356b0246586bcb7e9969bc26db43bb96
* Update context menu addon version (#11735) (#11740)Zhe Sun2019-10-031-1/+1
| | | | * Update context menu addon version (#11735)
* Update release note to mention Java 11 support (#11697) (#11728)Zhe Sun2019-10-021-2/+3
| | | | * Update release note to mention Java 11 support
* Update Chrome version to 77 (#11727) (#11731)Zhe Sun2019-09-258-1/+1
| | | | | * Update Chrome version to 77 (#11727)
* print8.9.0Zhe Sun2019-09-111-0/+1
|
* Print the errors (#11717)Zhe Sun2019-09-111-0/+3
|
* Fix scrollTo for destination START and END and add regression testing. (#11711)Anna Koskinen2019-09-053-48/+356
| | | | | | | | | | | - Initial implementation erroneously assumed that ScrollDestination.START would only be used for scrolling up and ScrollDestination.END for scrolling down. That's obviously not what they are for, otherwise everyone would be using ScrollDestination.ANY. - Moved actual scrolling to within the helper method that originally only calculated the new scroll position. Parent method became too long otherwise. Fixes #11706
* Updated row and spacer handling for Escalator (#11438)8.9.0.beta3Anna Koskinen2019-08-3017-1078/+3277
| | | | | | | | | | | | | | | | | | | | | | | Updated row and spacer handling for Escalator. Main changes: - Spacers are only maintained and checked for rows that have DOM representation, and not at all if there is no details generator. This gives notable performance improvements to some particularly large Grids - Escalator no longer tries to trim away any rows that don't fit within the viewport just because a details row gets opened in Grid. This leads to some increase in simultaneous DOM elements, but simplifies the logic considerably. For example opening or closing details rows doesn't require checking the overall content validity beyond the details row itself anymore, but some repositioning at most. There are also no longer any orphaned spacers without corresponding DOM rows. - Spacers are better integrated into the overall position calculations. - Some public methods that are no longer used by Escalator or have changed functionality or order of operations. Any extending classes that tap into row, spacer, or scroll position handling are likely to need reworking after this update. - Auto-detecting row height is delayed until Escalator is both attached and displayed.
* Update release note for final release (#11689)Zhe Sun2019-08-061-2/+2
|
* Exclude element screenshot tests from IE11 (#11681)Zhe Sun2019-08-066-2/+57
|
* Additional updates and fixes for 8.9 branch (#11679)Zhe Sun2019-08-069-23/+35
| | | | | | | | * Release note update for 8.9 * Fix unstable tests in the branch * Code formatting
* Docs fixes and enlarge toleranceZheSun882019-08-052-5/+5
|
* Chrome 76 and update screenshotZheSun882019-08-05189-1/+1
|
* Update since tag8.9.0.beta2ZheSun882019-07-306-6/+6
|
* Update Spring addon to 3.2.1 (#11670)Zhe Sun2019-07-301-1/+1
|
* Update screenshot (#11669)Zhe Sun2019-07-301-0/+0
|
* Apply offset to column index depending on presense of selection column (#11667)Tatu Lund2019-07-302-1/+72
| | | | | | | | * Apply offset to column index depending on presense of selection column After testing this manually I noticed that offset correction needs to be negative * Add the testing UI
* Ensure the upload button has been disabled when set Enabled calling from ↵Zhe Sun2019-07-303-0/+306
| | | | | | | | | succeedL… (#11655) * Ensure the upload button has been disabled when calling from succeedListener with Push enabled * Add Tests to verify
* Prevent excessive getLogger() calls from markAsDirty() (#11664)Leif Åstrand2019-07-301-15/+24
| | | Fixes #10339
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-20 15:33:23 +0000