summaryrefslogtreecommitdiffstats
path: root/client/src
Commit message (Collapse)AuthorAgeFilesLines
* MenuBar: Don't set openRootOnHover when on Android or IOS. (#12135) (#12166)Anna Koskinen2020-12-031-2/+9
| | | | | Fixes #5873 Authored-by: Martin Vysny <martin@vysny.me>
* Ensure Composite's contents gets re-measured on resize. (#12154) (#12162)Anna Koskinen2020-12-021-0/+2
| | | Fixes: #12153
* Tweaks to Grid/Escalator column size handling (#12145) (#12157)Anna Koskinen2020-12-014-93/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | - ScrollbarBundle: removed delays in scroll handling that were only needed for IE8, added possibility to update offsetSize and scrollSize at the same time in order to avoid triggering unnecessary scrollbar visibility change events during the intermediate state. - ColumnConfigurator: added new method that allows setting column widths without triggering element size recalculations. - EscalatorProxy: added implementation of the new method to ColumnConfigurationProxy. - Escalator: switched to use new methods in ScrollbarBundle and ColumnConfigurator, added a pixel to a scrollbar offsetSize calculation that was for some reason consistently one pixel too low, removed duplicate method calls from sectionHeightCalculated handling as those are already handled by the calling method and can cause incorrect intermediate state and unnecessary scrollbar visibility change events, added implementation of the new method to ColumnConfigurationImpl with the element size recalculations made optional. - Grid: updated column minimum width calculations to take into account the potential presence of a resize handle, updated expand ratio handling to not trigger element size recalculations until the entire handling is finished. - Test for column width handling when there are multiple columns with setMinimumWidthFromContent(false) Fixes #12139
* Use generated id of the menu item to help testing of the menubar (#12124) ↵Anna Koskinen2020-12-011-0/+5
| | | | | | | | | (#12156) Use generated IDs for MenuItems when an ID is set for MenuBar. Tying the ID to MenuBar's ID helps with the possible case of having multiple MenuBars on the same view and avoids to have excess id's when not needed. Fixes: https://github.com/vaadin/framework/issues/8186 Authored-by: Tatu Lund <tatu@vaadin.com>
* Take border into account in Grid editor position when it opens upwards. ↵Anna Koskinen2020-10-201-3/+4
| | | | (#12118) (#12129)
* When a Grid gets scroll-locked, cancel the scrollInProgress handler. ↵Anna Koskinen2020-10-201-3/+10
| | | | | | | | | (#12116) (#12127) Otherwise opening a Grid editor can cause ApplicationConnection to get stuck in 'active' state even if no actual scroll position processing is ongoing, which in turn causes TestBench delays when it tries to wait until ApplicationConnection indicates that everything necessary has been processed.
* Open details rows shouldn't get removed when a new row is added to Grid (#12109)7.7.22Anna Koskinen2020-10-061-6/+0
| | | Fixes: #12106
* fix for #12079 - recalculate Composite layout inside Window (#12082)Olli Tietäväinen2020-08-261-2/+2
| | | Co-authored-by: Anna Koskinen <anna@vaadin.com>
* Fix typo in error message (#12077)Anna Koskinen2020-08-171-1/+1
|
* Add 1px buffer to Escalator column natural widths. (#12075)Anna Koskinen2020-08-171-7/+7
| | | | | | | | | | | | * Add 1px buffer to Escalator column natural widths. The purpose of the buffer is to avoid subpixel handling issues, especially when zoomed in or out. In case fractions need to be adjusted for browser compatibility, round up to ensure the contents have the space they need. Fixes #12048
* Add enabled check to Column#isResizable (#12063)Tatu Lund2020-08-061-1/+3
|
* Use queue for resync requests. (#12043)Anna Koskinen2020-07-301-7/+13
| | | | | | | | | There might be pending requests in the queue when a resync request is made (e.g. through a theme change). This can cause conflicts if the resync request is handled immediately. Therefore the resync request should also be added to the queue and only get resolved when doSendInvocationsToServer() gets triggered again. Fixes #11954
* Add column width recalculation when vertical scrollbar hidden/shown. (#12058)Anna Koskinen2020-07-233-3/+150
| | | | | - If the Grid has any columns with non-fixed widths, the presence of a vertical scrollbar affects the column width calculations. Horizontal scrollbar should only be shown when actually needed.
* Revert 'Rewrote debouncing of onResize (#11899)' (#12051)Anna Koskinen2020-07-091-33/+15
| | | Fixes #12049
* All updates to Escalator size should get reported to LayoutManager. (#12050)Anna Koskinen2020-07-083-0/+134
| | | | Delayed size changes caused by added or removed scrollbars should be taken into account.
* Add support for "ww" in date format (#12037)Tatu Lund2020-07-031-0/+49
| | | | | Calculate number of the week in the year based on Date. Note, support for "ww" is missing from GWT DateTimeFormat and java.util.Calendar is not supported in GWT, hence DIY method is needed. Fixes: #10603
* Update ComboBox popup position comparison to use correct top value. (#12041)Anna Koskinen2020-06-261-2/+2
| | | Fixes #12029
* Fix rendering of TreeGrid's frozen columns after hierarchy-column reset (#12028)Tarek Oraby2020-06-181-1/+9
| | | | | * Add tests * Fix getVisibleFrozenColumnCount() if SelectionMode is multi
* Fix ComboBox in read-only mode allowing value change by user (#12022)Tarek Oraby2020-05-251-0/+3
| | | | | | | | | * Fix ComboBox in read-only mode allowing value change by user Fixes #12021 * Fix popup hiding condition Co-authored-by: Tatu Lund <tatu@vaadin.com>
* Moving disableBrowserAutocomplete to WidgetUtil and change widgets to use it ↵Tatu Lund2020-05-253-18/+26
| | | | | | | | | | | | | | | | | | | | | | (#12020) * Add autocomplete prevention to DateField Autocomplete popup will interfere DateField's own popup * Adding disableBrowserAutocomplete(..) in WidgetUtil * Change VComboBox to use WidgetUtil.disableBrowserAutocomplete(..) * Change to use WidgetUtil.disableBrowserAutocomplete(..) * Change VFilterSelect to use WidgetUtil.disableBrowserAutocomplete(..) * Adding WidgetUtil.disableBrowserAutocomplete to VTextualDate * Adding missing import * Adding missing import
* Fix RTA's CreateLink in Firefox & IE11 (#11979)Tarek Oraby2020-05-081-1/+25
| | | | | | | In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted. This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted. fixes #11888
* Take overlays into account in getConnectorForElement. (#11980)Anna Koskinen2020-05-051-7/+24
| | | | | | * Take overlays into account in getConnectorForElement. Fixes #11212
* Allow replacing all columns at once when some of them are frozen. (#11978)Anna Koskinen2020-04-301-2/+11
| | | Fixes #11824
* Fix the column width calculations for full width cell contents. (#11974)Anna Koskinen2020-04-291-0/+40
| | | Fixes #11973
* Fix hiding / un-hiding with frozen columns in multiselect mode (#11972)Tatu Lund2020-04-281-4/+4
| | | | | | | The previous patch https://github.com/vaadin/framework/pull/11951 did fix the problem (frozen column indicator wrongly positioned) it was meant to, but caused a regression in hiding / un-hiding. This new fix addresses both problems, i.e. it applies multiselect column compensation in other way, without causing problem in hiding / un-hiding logic Fixes https://github.com/vaadin/framework/issues/11970
* Don't center a window that has already been removed. (#11956)Anna Koskinen2020-04-241-2/+8
| | | | | | * Don't center a window that has already been removed. Fixes #11942
* Fix incorrect position of column selector in MPR (#11953)Tatu Lund2020-04-211-0/+2
| | | | Cherry pick from https://github.com/vaadin/framework/pull/11946
* Add multiselect column compensation (#11951)Tatu Lund2020-04-201-1/+5
|
* Expired session: use 403 Forbidden instead of 410 Gone (#11859)Felix Fontein2020-04-081-1/+1
| | | Use 403 Forbidden instead of 410 Gone when session expired. Also prevent caching in more cases.
* Fix sanitization of empty RTA input for Firefox & IE (#11937)Tarek Oraby2020-04-061-2/+2
| | | | | | | Browsers differ in what they return as the content of a visually empty rich text area (RTA). Accordingly, RTA sanitizes these different values ensuring an empty string is returned to the framework. However, existing sanitization criteria doesn't work for Firefox 74 and Internet Explorer 11. This fix appends the sanitization criteria of Firefox 74 and IE 11, ensuring an empty string is returned to the framework for a a visually empty RTA. Closes #10338
* Allow setting Upload button caption as HTML, move data to SharedState. (#11940)Anna Koskinen2020-04-061-11/+24
| | | Fixes #11810
* Prevent upload if no file is selected. (#11939)Anna Koskinen2020-04-032-22/+54
| | | Fixes #10419
* Ensure ChangeListener still works after first upload. (#11936)Anna Koskinen2020-04-011-0/+11
| | | Fixes #10420
* Ensure recalculateColumnWidths works with refreshAll. (#11934)Anna Koskinen2020-03-312-16/+77
| | | | | | | | Column widths shouldn't be calculated between the clearing of cache and re-populating it, but be delayed until the cache has some content again. The calculations should only be triggered immediately if no rows are expected. Fixes #9996
* Fix an issue with frozen column count and unhiding. (#11929)Anna Koskinen2020-03-261-1/+3
| | | | | | | * Fix an issue with frozen column count and unhiding. Unhiding logic should take into account that there can be hidden frozen columns that are not the column currently getting shown.
* Simplify Grid sidebar handling. (#11920)Anna Koskinen2020-03-231-17/+40
| | | | | | | | | | There is no need to reset the sidebar for every column that is set hidable within the same roundtrip. Because no other layouting depends on the sidebar contents, we can safely delay the reset until all columns have got their hidabiity status updated. As a bonus point, when the reset itself is delayed, the headers have time to get populated and the sidebar button's height can be determined immediately at attach. The reset ensures that attach is called every time a column's hidability is changed.
* Prevent a gap within Grid rows in some resize situations. (#11918)Anna Koskinen2020-03-171-3/+25
| | | Fixes #11892
* Trigger re-measure after updating ElementResizeListeners. (#11912)Anna Koskinen2020-03-091-0/+10
| | | | | | | | | | | Removing ElementResizeListeners from an element makes it unmeasurable and clears any saved measured values. Adding the listeners back makes the element measurable again but doesn't add it to measuring queue. Measuring needs to happen or any updates to expanded components within a layout (without changes that would trigger full re-measuring of the layout itself) lead to broken expand size calculations with any fixed size elements assumed to have no size. Fixes #10734
* Further tweaks to ComboBox popup positioning. (#11910)Anna Koskinen2020-03-061-7/+15
| | | | | | | | * Further tweaks to ComboBox popup positioning. - Updated a comment and renamed a private method for better clarity. - Blocked unnecessary position updates. - Added a test for #11866 / #11894.
* Adding missing setPopupPosition(left, top); (#11902)Tatu Lund2020-03-021-0/+1
| | | | | | | | * Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes https://github.com/vaadin/framework/issues/11894
* Rewrote debouncing of onResize (#11899)Tatu Lund2020-02-271-15/+33
| | | | | | | | * Rewrote debouncing of onResize Fixes https://github.com/vaadin/framework/issues/11892 * Fixing typo in variable name
* Removing code causing the trouble (#11898)Tatu Lund2020-02-241-4/+0
| | | | | | | | | | | | | | | | | | * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: https://github.com/vaadin/framework/issues/11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField
* Fix logic of lexicographical comparison of DateField range end (#11885)Tatu Lund2020-02-131-2/+18
| | | | | | | | | | | | | | | | | | | | | | * Fix logic of lexicographical comparison of DateField range end Fix logic of lexicographical comparison of DateField range end with large year numbers ( > 9999) Fixes #11881 * Added tests Purpose of dateFieldRangeYearDigitsIncrease() is to test that rangeEnd works correctly on 4 to 5 digits change boundary Purpose of dateFieldRangeYearBigNumbersPopupOpens() is to test that popup opens also when there is more than 4 digits in year * Fixing typo * Add error message * Set the date of the field in test * Fixing
* Don't reset date to current at DateField state (e.g. read-only) updates. ↵Anna Koskinen2020-01-281-8/+20
| | | | | | | | | (#11879) - DateFields with month or year resolution should not get their date reset to current date if the field's state is updated (e.g. by changing read-only status or adding a range). Fixes: #11864, #11605
* Ensure value change happens before shortcuts in compatibility components ↵Anna Koskinen2020-01-151-3/+39
| | | | | (#11871) Fixes #10854
* Removed outdated spacer height update from removal process. (#11861)Anna Koskinen2020-01-091-2/+0
| | | | | | * Removed outdated spacer height update from removal process. Fixes #11856
* Fix to RadioButtonGroup readOnly handling. (#11855)Anna Koskinen2019-12-231-1/+6
| | | | | | | | | * Fix to RadioButtonGroup readOnly handling. Updated the connector to use the widget's enabled and readOnly handling as intended. Fixes #11843
* Improvements to popup positioning for ComboBox within HorizontalLayout. (#11846)Anna Koskinen2019-12-181-8/+61
| | | | | | | | Expand ratio and spacing can cause ComboBox to miscalculate its own position while layouting is still ongoing. Popup should not be repositioned in such circumstances in order to avoid incorrect intermediate states. Continues on #11718
* Close window on ESC, when maximized button is clicked (#11840)Anastasia Smirnova2019-12-051-4/+10
| | | | | | | | | Fixes #11838 Changes: 1. Close a window when maximized button is focused and ESC is pressed 2. Add additional check for a close button to react to the ESC key press 3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
* Simplify Grid scroll handling. (#11835)Anna Koskinen2019-12-033-46/+65
| | | | | | | | | | | | If first attempt at scrolling doesn't succeed it's unlikely that continuing to wait is going to make any difference. Cache should be populated before triggering any actions that depend on the row being visible, otherwise it should be enough to trust that scrollToRow actually scrolls to row and once scrolling is done the row is as much in view as it's going to get. This way we don't get into a situation where Editor never opens because it's still waiting for that one last pixel that can't be achieved thanks to browser zoom causing rounding errors. Continues on #11672
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-23 20:40:52 +0000