aboutsummaryrefslogtreecommitdiffstats
path: root/client/src
Commit message (Collapse)AuthorAgeFilesLines
* Split too long method in two. (#12351)Anna Koskinen2021-07-271-63/+69
|
* Checkstyle fixes. (#12349)Anna Koskinen2021-07-2717-17/+342
| | | | | - Added and completed JavaDocs. - Fixed a typo in logging. - Removed an unused parameter in a private method.
* Deprecating Flash component. (#12348)Anna Koskinen2021-07-262-0/+106
| | | Also added missing JavaDocs.
* Divide too long Grid and Escalator methods into smaller units. (#12340)Anna Koskinen2021-07-232-259/+348
|
* Checkstyle fixes (#12347)Anna Koskinen2021-07-2382-139/+1638
| | | | | | | | | | | | - Added, completed, and corrected JavaDocs. - Added an assert to enforce a condition that has always been required. - Added default sections to switch blocks. - Added wildcards. - Deprecated unused methods and variables. - Removed inner assignments. - Removed unused private variables and calls that do nothing. - Updated deprecated calls to use currently recommended versions. - Updated warning suppressions. - ...and some auto-formatting.
* Ensure Grid details rows get a full refresh when a column is sorted. (#12342)Anna Koskinen2021-07-211-1/+2
| | | Fixes #12341
* Checkstyle fixes (#12339)Anna Koskinen2021-07-1551-85/+1177
| | | | | | | | | | | | | | - Added missing default sections to switch blocks. - Added missing JavaDocs and JavaDoc parameters. - Added wildcards where possible. - Deprecated unused method. - Fixed JavaDoc formatting. - Removed inner assignments. - Removed unused imports. - Removed unused variables. - Removed warning suppressions that were unnecessary or about boxing (not tracked by coding conventions). - Suppressed warnings about rawtypes, deprecation, and unchecked where couldn't be avoided.
* Code cleanup (#12333)Anna Koskinen2021-07-0810-89/+91
| | | | | | | | | | | | | | | | - removed unused private methods - removed unused private variables - removed unnecessary initializations - removed unnecessary substring(0) - removed inner assignments - renamed private methods that started with upper case - renamed static final variables to use upper case - converted to use non-deprecated options - suppressed unavoidable warnings - divided long Strings to multiple lines - added missing types - added missing JavaDoc parameters - formatting - updated comments & JavaDocs
* Ensure removing a row does not cause exceptions in detail row handling. (#12330)Anna Koskinen2021-06-301-0/+23
| | | Fixes: #12328
* Trigger repositioning after full refresh of current details. (#12312)Anna Koskinen2021-05-201-0/+6
| | | Fixes #12310
* Ensure large tooltips can be closed on touch devices. (#12282)Anna Koskinen2021-04-301-1/+1
| | | Fixes #10435
* Fix validation in non-buffered Grid editor (#12281)Tarek Oraby2021-04-284-8/+91
| | | | | Handle possible race condition by disabling the editor's widget while awaiting validation from the server. Fixes #12270
* Add browser specific handling in setRows (#12141)Tatu Lund2021-04-191-1/+3
| | | | | | | | | | | * Add browser specific handling in setRows Fixes: https://github.com/vaadin/framework/issues/10138 Fixes: https://github.com/vaadin/framework/issues/7878 * Enforced minimum height to 1 rows and added a test. Co-authored-by: Anna Koskinen <anna@vaadin.com>
* Fix Window dragging on touch screen. (#12260)Anna Koskinen2021-03-311-2/+2
| | | | | | | | | - Added check for touch move event in order to allow the same flow for both mouse and touch events when dragging a Window by its header. - Can be tested with SubwindowDraggability class. Fixes #12257 Co-authored-by: Jakub Antoniak <j.antoniak8@gmail.com>
* Add missing 8.13 since tag (#12236)Zhe Sun2021-03-113-3/+3
|
* Optimized #12211 fix. (#12234)Anna Koskinen2021-03-101-19/+6
|
* Remove outdated comment (#12233)Anna Koskinen2021-03-091-1/+0
|
* Fix updating Escalator's physical row index. (#12232)Anna Koskinen2021-03-081-1/+4
| | | | | | | | | | | | * Fix updating Escalator's physical row index. - Physical index should take into account that more than one row can have a spacer. Physical index has no practical effect on how Grid looks like or behaves, since Escalator by design operates independently of it and the visual positioning of elements is based on the logical and visual indices. Physical index only affects the order of elements within the DOM tree, where a mismatch can cause confusion during debugging.
* Fix updating Grid's item set when details rows are open. (#12231)Anna Koskinen2021-03-084-3/+51
| | | | | | | | | | - Old details should close. - New details should open. - If some row has details in both old and new item set, the details row contents should get updated. - Updating details row contents should not break the positioning of the rows and details below. Fixes #12211
* Update copyright year range. (#12215)Anna Koskinen2021-03-04523-523/+523
| | | | * Update copyright year range.
* Fix displaying checkboxes within Grid editor row. (#12212)Anna Koskinen2021-03-031-0/+7
| | | | | | | | * Fix displaying checkboxes within Grid editor row. - Checkbox margins should match regular row content margins. - Multiselect checkbox label should only be visible for assistive devices.
* Fixed input to ensureAvailabilty (#12208)Oliver Buchien2021-02-261-2/+2
|
* fix: Focus-activated shortcut listener in compatibility TextField (#12203)Tatu Lund2021-02-161-5/+23
|
* Re-use ComputedStyles in Escalator when possible. (#12186)Anna Koskinen2021-02-052-9/+38
|
* Remove outdated IE10 compatibility class (#12193)Anna Koskinen2021-02-021-34/+0
| | | Leftover from https://github.com/vaadin/framework/commit/0081286c8d05c3751803181230092bd4b1e769f7
* Move call to getMessageHandler().onResynchronize(); to right place (#12178)Tatu Lund2021-01-071-1/+1
| | | | | https://github.com/vaadin/framework/pull/12043 changed resync message sending to be deferred to queue. Now also the setting of the semaphor in message handler needs to be deferred to its right place. Otherwise there is possibility for a timing glitch. I.e. MessageHandler is set to resync handling mode before message is actually send. Fixes: https://github.com/vaadin/framework/issues/12151
* Fix to LayoutManager size calculations during transform. (#12138)Anna Koskinen2020-12-183-13/+93
| | | | | | | | | | | | | | | | | | | | | | | * Fix to LayoutManager size calculations during transform. - ComputedStyle is slower but more reliable than using getBoundingClientRect, which does not work as expected if a transform has been applied to the element or one of its parents. This is a problem e.g. with PopupView, where getBoundingClientRect will return too small size (or even zero size) for all the popup contents while the opening animation is active. ComputedStyle ignores the transform and returns the expected value. - The presence of the element in DOM must be checked before the size is requested from ComputedStyle, if the element has disappeared from DOM without a warning and calculation is attempted anyway, the browser gets stuck. - Possibility to configure LayoutManager to use the less reliable calculations for applications where the slight performance difference is more important than layout issues within elements that have transform animations. - Manual test, problem isn't reproducible by TestBench. Fixes: #11187
* MenuBar: Don't set openRootOnHover when on Android or IOS. (#12135)Martin Vysny2020-12-031-2/+9
| | | Fixes #5873
* Ensure Composite's contents gets re-measured on resize. (#12154)Anna Koskinen2020-12-011-0/+2
| | | Fixes: #12153
* Tweaks to Grid/Escalator column size handling (#12145)Anna Koskinen2020-11-104-93/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | - ScrollbarBundle: removed delays in scroll handling that were only needed for IE8, added possibility to update offsetSize and scrollSize at the same time in order to avoid triggering unnecessary scrollbar visibility change events during the intermediate state. - ColumnConfigurator: added new method that allows setting column widths without triggering element size recalculations. - EscalatorProxy: added implementation of the new method to ColumnConfigurationProxy. - Escalator: switched to use new methods in ScrollbarBundle and ColumnConfigurator, added a pixel to a scrollbar offsetSize calculation that was for some reason consistently one pixel too low, removed duplicate method calls from sectionHeightCalculated handling as those are already handled by the calling method and can cause incorrect intermediate state and unnecessary scrollbar visibility change events, added implementation of the new method to ColumnConfigurationImpl with the element size recalculations made optional. - Grid: updated column minimum width calculations to take into account the potential presence of a resize handle, updated expand ratio handling to not trigger element size recalculations until the entire handling is finished. - Test for column width handling when there are multiple columns with setMinimumWidthFromContent(false) Fixes #12139
* Use generated id of the menu item to help testing of the menubar (#12124)Tatu Lund2020-10-221-0/+5
| | | | | Use generated IDs for MenuItems when an ID is set for MenuBar. Tying the ID to MenuBar's ID helps with the possible case of having multiple MenuBars on the same view and avoids to have excess id's when not needed. Fixes: https://github.com/vaadin/framework/issues/8186
* Take border into account in Grid editor position when it opens upwards. (#12118)Anna Koskinen2020-10-131-3/+4
|
* When a Grid gets scroll-locked, cancel the scrollInProgress handler. (#12116)Anna Koskinen2020-10-121-3/+10
| | | | | | | Otherwise opening a Grid editor can cause ApplicationConnection to get stuck in 'active' state even if no actual scroll position processing is ongoing, which in turn causes TestBench delays when it tries to wait until ApplicationConnection indicates that everything necessary has been processed.
* Open details rows shouldn't get removed when a new row is added to Grid (#12109)7.7.22Anna Koskinen2020-10-061-6/+0
| | | Fixes: #12106
* fix for #12079 - recalculate Composite layout inside Window (#12082)Olli Tietäväinen2020-08-261-2/+2
| | | Co-authored-by: Anna Koskinen <anna@vaadin.com>
* Fix typo in error message (#12077)Anna Koskinen2020-08-171-1/+1
|
* Add 1px buffer to Escalator column natural widths. (#12075)Anna Koskinen2020-08-171-7/+7
| | | | | | | | | | | | * Add 1px buffer to Escalator column natural widths. The purpose of the buffer is to avoid subpixel handling issues, especially when zoomed in or out. In case fractions need to be adjusted for browser compatibility, round up to ensure the contents have the space they need. Fixes #12048
* Add enabled check to Column#isResizable (#12063)Tatu Lund2020-08-061-1/+3
|
* Use queue for resync requests. (#12043)Anna Koskinen2020-07-301-7/+13
| | | | | | | | | There might be pending requests in the queue when a resync request is made (e.g. through a theme change). This can cause conflicts if the resync request is handled immediately. Therefore the resync request should also be added to the queue and only get resolved when doSendInvocationsToServer() gets triggered again. Fixes #11954
* Add column width recalculation when vertical scrollbar hidden/shown. (#12058)Anna Koskinen2020-07-233-3/+150
| | | | | - If the Grid has any columns with non-fixed widths, the presence of a vertical scrollbar affects the column width calculations. Horizontal scrollbar should only be shown when actually needed.
* Revert 'Rewrote debouncing of onResize (#11899)' (#12051)Anna Koskinen2020-07-091-33/+15
| | | Fixes #12049
* All updates to Escalator size should get reported to LayoutManager. (#12050)Anna Koskinen2020-07-083-0/+134
| | | | Delayed size changes caused by added or removed scrollbars should be taken into account.
* Add support for "ww" in date format (#12037)Tatu Lund2020-07-031-0/+49
| | | | | Calculate number of the week in the year based on Date. Note, support for "ww" is missing from GWT DateTimeFormat and java.util.Calendar is not supported in GWT, hence DIY method is needed. Fixes: #10603
* Update ComboBox popup position comparison to use correct top value. (#12041)Anna Koskinen2020-06-261-2/+2
| | | Fixes #12029
* Fix rendering of TreeGrid's frozen columns after hierarchy-column reset (#12028)Tarek Oraby2020-06-181-1/+9
| | | | | * Add tests * Fix getVisibleFrozenColumnCount() if SelectionMode is multi
* Fix ComboBox in read-only mode allowing value change by user (#12022)Tarek Oraby2020-05-251-0/+3
| | | | | | | | | * Fix ComboBox in read-only mode allowing value change by user Fixes #12021 * Fix popup hiding condition Co-authored-by: Tatu Lund <tatu@vaadin.com>
* Moving disableBrowserAutocomplete to WidgetUtil and change widgets to use it ↵Tatu Lund2020-05-253-18/+26
| | | | | | | | | | | | | | | | | | | | | | (#12020) * Add autocomplete prevention to DateField Autocomplete popup will interfere DateField's own popup * Adding disableBrowserAutocomplete(..) in WidgetUtil * Change VComboBox to use WidgetUtil.disableBrowserAutocomplete(..) * Change to use WidgetUtil.disableBrowserAutocomplete(..) * Change VFilterSelect to use WidgetUtil.disableBrowserAutocomplete(..) * Adding WidgetUtil.disableBrowserAutocomplete to VTextualDate * Adding missing import * Adding missing import
* Fix RTA's CreateLink in Firefox & IE11 (#11979)Tarek Oraby2020-05-081-1/+25
| | | | | | | In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted. This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted. fixes #11888
* Take overlays into account in getConnectorForElement. (#11980)Anna Koskinen2020-05-051-7/+24
| | | | | | * Take overlays into account in getConnectorForElement. Fixes #11212
* Allow replacing all columns at once when some of them are frozen. (#11978)Anna Koskinen2020-04-301-2/+11
| | | Fixes #11824