summaryrefslogtreecommitdiffstats
path: root/client
Commit message (Collapse)AuthorAgeFilesLines
* Fix sanitization of empty RTA input for Firefox & IE (#11937) (#11989)Anna Koskinen2020-05-111-2/+2
| | | | | | | | | Browsers differ in what they return as the content of a visually empty rich text area (RTA). Accordingly, RTA sanitizes these different values ensuring an empty string is returned to the framework. However, existing sanitization criteria doesn't work for Firefox 74 and Internet Explorer 11. This fix appends the sanitization criteria of Firefox 74 and IE 11, ensuring an empty string is returned to the framework for a a visually empty RTA. Closes #10338 Authored-by: Tarek Oraby <42799254+tarekoraby@users.noreply.github.com>
* Fix RTA's CreateLink in Firefox & IE11 (#11979) (#11987)Anna Koskinen2020-05-081-1/+25
| | | | | | | | | | * Fix RTA's CreateLink in Firefox & IE11 (#11979) In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted. This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted. fixes #11888
* Take overlays into account in getConnectorForElement. (#11980) (#11983)Anna Koskinen2020-05-051-7/+24
| | | | | | * Take overlays into account in getConnectorForElement. (#11980) Fixes #11212
* Allow replacing all columns at once when some of them are frozen. (#11982)Anna Koskinen2020-05-051-2/+11
| | | | | | * Allow replacing all columns at once when some of them are frozen. (#11978) Fixes #11824
* Fix hiding / un-hiding with frozen columns in multiselect mode (#11972) (#11975)Anna Koskinen2020-04-281-4/+4
| | | | | | | The previous patch https://github.com/vaadin/framework/pull/11951 did fix the problem (frozen column indicator wrongly positioned) it was meant to, but caused a regression in hiding / un-hiding. This new fix addresses both problems, i.e. it applies multiselect column compensation in other way, without causing problem in hiding / un-hiding logic Fixes https://github.com/vaadin/framework/issues/11970
* Don't center a window that has already been removed. (#11956) (#11969)8.10.4Anna Koskinen2020-04-241-2/+8
| | | | | | | | * Don't center a window that has already been removed. (#11956) * Don't center a window that has already been removed. Fixes #11942
* Fix incorrect position of column selector in MPR (#11953) (#11968)Anna Koskinen2020-04-241-0/+2
| | | | | | | * Fix incorrect position of column selector in MPR (#11953) Cherry pick from https://github.com/vaadin/framework/pull/11946
* Add multiselect column compensation (#11951) (#11967)Anna Koskinen2020-04-241-1/+5
| | | | * Add multiselect column compensation (#11951)
* Expired session: use 403 Forbidden instead of 410 Gone (#11859) (#11964)Anna Koskinen2020-04-241-1/+1
| | | | | | * Expired session: use 403 Forbidden instead of 410 Gone (#11859) Use 403 Forbidden instead of 410 Gone when session expired. Also prevent caching in more cases.
* Ensure ChangeListener still works after first upload. (#11936) (#11960)Anna Koskinen2020-04-241-0/+11
| | | | | | * Ensure ChangeListener still works after first upload. (#11936) Fixes #10420
* Ensure recalculateColumnWidths works with refreshAll. (#11934) (#11959)Anna Koskinen2020-04-242-16/+77
| | | | | | | | Column widths shouldn't be calculated between the clearing of cache and re-populating it, but be delayed until the cache has some content again. The calculations should only be triggered immediately if no rows are expected. Fixes #9996
* Fix an issue with frozen column count and unhiding. (#11929) (#11932)8.10.3Anna Koskinen2020-03-261-1/+3
| | | | | | * Fix an issue with frozen column count and unhiding. Unhiding logic should take into account that there can be hidden frozen columns that are not the column currently getting shown.
* Simplify Grid sidebar handling. (#11920) (#11924)Anna Koskinen2020-03-241-17/+40
| | | | | | | | | | There is no need to reset the sidebar for every column that is set hidable within the same roundtrip. Because no other layouting depends on the sidebar contents, we can safely delay the reset until all columns have got their hidabiity status updated. As a bonus point, when the reset itself is delayed, the headers have time to get populated and the sidebar button's height can be determined immediately at attach. The reset ensures that attach is called every time a column's hidability is changed.
* Prevent a gap within Grid rows in some resize situations. (#11918) (#11923)Anna Koskinen2020-03-241-3/+25
| | | Fixes #11892
* Trigger re-measure after updating ElementResizeListeners. (#11912) (#11922)Anna Koskinen2020-03-241-0/+10
| | | | | | | | | | | Removing ElementResizeListeners from an element makes it unmeasurable and clears any saved measured values. Adding the listeners back makes the element measurable again but doesn't add it to measuring queue. Measuring needs to happen or any updates to expanded components within a layout (without changes that would trigger full re-measuring of the layout itself) lead to broken expand size calculations with any fixed size elements assumed to have no size. Fixes #10734
* Further tweaks to ComboBox popup positioning. (#11910) (#11921)Anna Koskinen2020-03-241-7/+15
| | | | | | | * Further tweaks to ComboBox popup positioning. - Updated a comment and renamed a private method for better clarity. - Blocked unnecessary position updates. - Added a test for #11866 / #11894.
* Picks 8.10.2 (#11908)8.10.2Zhe Sun2020-03-023-19/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Removing code causing the trouble (#11898) * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: https://github.com/vaadin/framework/issues/11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField * Rewrote debouncing of onResize (#11899) * Rewrote debouncing of onResize Fixes https://github.com/vaadin/framework/issues/11892 * Fixing typo in variable name * Adding missing setPopupPosition(left, top); (#11902) * Adding missing setPopupPosition(left, top); setPopupPosition(left, top); needs to be called in order to top position to be set Fixes https://github.com/vaadin/framework/issues/11894 Co-authored-by: Tatu Lund <tatu@vaadin.com>
* Fix logic of lexicographical comparison of DateField range end (#11885)Tatu Lund2020-02-201-2/+18
| | | | | | | | | | | | | | | | | | | | | | * Fix logic of lexicographical comparison of DateField range end Fix logic of lexicographical comparison of DateField range end with large year numbers ( > 9999) Fixes #11881 * Added tests Purpose of dateFieldRangeYearDigitsIncrease() is to test that rangeEnd works correctly on 4 to 5 digits change boundary Purpose of dateFieldRangeYearBigNumbersPopupOpens() is to test that popup opens also when there is more than 4 digits in year * Fixing typo * Add error message * Set the date of the field in test * Fixing
* Cherry picks for 8.10 final release (#11883)Zhe Sun2020-02-041-8/+20
| | | | | | | | | | | | | | | | | * Don't reset date to current at DateField state (e.g. read-only) updates. (#11879) - DateFields with month or year resolution should not get their date reset to current date if the field's state is updated (e.g. by changing read-only status or adding a range). Fixes: #11864, #11605 * Update Navigator.getState() JavaDoc to be more accurate (#11876) Fixes: https://github.com/vaadin/framework/issues/11875 Co-authored-by: Anna Koskinen <Ansku@users.noreply.github.com> Co-authored-by: Tatu Lund <tatu@vaadin.com>
* Ensure value change happens before shortcuts in compatibility components ↵Anna Koskinen2020-01-151-3/+39
| | | | | (#11871) Fixes #10854
* Removed outdated spacer height update from removal process. (#11861)Anna Koskinen2020-01-091-2/+0
| | | | | | * Removed outdated spacer height update from removal process. Fixes #11856
* Fix to RadioButtonGroup readOnly handling. (#11855)Anna Koskinen2019-12-231-1/+6
| | | | | | | | | * Fix to RadioButtonGroup readOnly handling. Updated the connector to use the widget's enabled and readOnly handling as intended. Fixes #11843
* Improvements to popup positioning for ComboBox within HorizontalLayout. (#11846)Anna Koskinen2019-12-181-8/+61
| | | | | | | | Expand ratio and spacing can cause ComboBox to miscalculate its own position while layouting is still ongoing. Popup should not be repositioned in such circumstances in order to avoid incorrect intermediate states. Continues on #11718
* Close window on ESC, when maximized button is clicked (#11840)Anastasia Smirnova2019-12-051-4/+10
| | | | | | | | | Fixes #11838 Changes: 1. Close a window when maximized button is focused and ESC is pressed 2. Add additional check for a close button to react to the ESC key press 3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
* Simplify Grid scroll handling. (#11835)Anna Koskinen2019-12-033-46/+65
| | | | | | | | | | | | If first attempt at scrolling doesn't succeed it's unlikely that continuing to wait is going to make any difference. Cache should be populated before triggering any actions that depend on the row being visible, otherwise it should be enough to trust that scrollToRow actually scrolls to row and once scrolling is done the row is as much in view as it's going to get. This way we don't get into a situation where Editor never opens because it's still waiting for that one last pixel that can't be achieved thanks to browser zoom causing rounding errors. Continues on #11672
* Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823)Anna Koskinen2019-11-211-1/+1
| | | | | | | | | | | | | The attempt gets blocked later down the line in any case and never reaches the server, but sending it messes up TreeGrid's internal state. It gets stuck waiting for the resolution of the blocked call that can then only be resolved by server-side sending its own expand/collapse request programmatically. Until that happens no further expand/collapse attempts will get sent to server even after the TreeGrid has been enabled again. Tree is also affected as it is built upon TreeGrid. Fixes #11822
* Fixing issue with TwinColSelect not correctly retaining visible selection ↵Tatu Lund2019-11-191-3/+32
| | | | | | | (#11799) There is a bug in TwinColSelect loging, it retains selection by indexes not by values after being sorted when new item has been added. This is a fixed by changing updateListBox method to retain the selection as it is being called after selection is being done. Fixes: #11287
* Reduce excess positioning calls for ComboBox popup. (#11808)Anna Koskinen2019-11-131-8/+21
| | | | | | | | | | | | | - If an open popup is reset to its default position on every update from the server before getting adjusted again to the actual expected position, on heavier applications some of those intermediate positions might get rendered. If the ComboBox is positioned at the right edge and the popup contents are longer than the input field (i.e. popup should open to the left, not right) this might cause flickering. - Setting the default position is only actually needed when the popup is opened in order to give it a baseline, otherwise it's better to simply adjust the position if needed. Continues on #11718
* Fixing issue with Push stopping working in some circumstances (#11791)Tatu Lund2019-11-052-2/+17
| | | | | | | | | | | | | | * Fixing issue with Push stopping working in some circumstances If new request is attempted when resynchronization is ongoing, the Push will stop working. This patch fixes the issue by aborting handleJson if resynch is already ongoing. This PR supercedes https://github.com/vaadin/framework/pull/11786 Fixes #11702, #7719 * Call onResynchronize() in MessageHandler * Optimizing
* Check actual Grid selection instead of relying on allSelected flag. (#11787)Anna Koskinen2019-11-041-1/+1
| | | | | | | | The checkbox for selecting all rows only selects all the rows that have not been filtered out. Changing the filtering does not change the selection or the checkbox state so assuming that all rows are selected simply because the checkbox has been checked cannot work. Fixes #11479
* Fix a timing issue in ComboBox filtering via paste using mouse. (#11780)Anna Koskinen2019-10-311-1/+3
| | | | | | The filtering needs to be delayed, otherwise it's performed before the new filter text is available and the old filter text is used instead. Fixes #11779
* Switch from an assert to logging and return in Grid.onBrowserEvent (#11778)Anna Koskinen2019-10-301-2/+5
| | | | | | | | | | | | - If the Grid has frozen columns zooming can cause the regular column cells to be ever so slightly out of sync with their corresponding rows. This difference is not noticeable to naked eye but is big enough that it's possible to hover over the row instead of the cell, which causes an assertion error and a big ugly error popup. Switching to logging retains the information delivered by the assertion error for developer purposes but makes the end user experience smoother. - Can be tested manually with GridColumnFrozenColumn test UI. Fixes #11198
* Added 1px tolerance to ScrollbarBundle's internal sanity check. (#11777)Anna Koskinen2019-10-291-3/+5
| | | | | | | | | | | | | | | * Added 1px tolerance to ScrollbarBundle's internal sanity check. Requiring exact match can cause this check to fail when the browser is zoomed since rounding is involved. This can in turn block some features like opening of Grid Editor from working until some more scrolling happens and the minute inconsistency is fixed. Can be tested manually using GridEditorUI, depending on the environment different amounts of zooming may be required for the problem to manifest. Fixes #11672
* Improvements to ScrollDestination sanity checks (#11772)Anna Koskinen2019-10-281-8/+26
| | | | | | | | - The new top row logical index should always be within the logical range and high enough up to avoid leaving a gap if possible. - Added regression testing for using the different scroll destination types for scrolling to the top and to the bottom by index. Fixes #11732
* When ComboBox popup opens to the left accommodate margin/border/padding. ↵Anna Koskinen2019-10-231-8/+10
| | | | | (#11755) Fixes #11718
* Make sure expanding/collapsing updates expected cache size. (#11753)Anna Koskinen2019-10-221-0/+12
| | | | | | | | * Make sure expanding/collapsing updates expected cache size. Fixes #11749 * Merge branch 'master' into issue11749
* Upload should preserve MIMEType after first selection (#11745)Anastasia Smirnova2019-10-161-0/+6
| | | | | | | | | | | | | | | | * Upload should preserve MIMEType after first selection Fix #11698 Automated test is not run locally, need to continue with it * Remove unused imports * Add sleep time in testing purposes * Getting a new instance of an input, after file is downloaded Exclude IE from tests. Throws https://stackoverflow.com/questions/23883071/unhandled-alert-exception-modal-dialog-present-selenium , but checked manually and it works
* Catch and handle IllegalStateException (#11733)Tatu Lund2019-10-031-11/+18
| | | | | | | | * Catch and handle IllegalStateException Fixes https://github.com/vaadin/framework/issues/11730 * Renaming variables
* Fix scrollTo for destination START and END and add regression testing. (#11707)Anna Koskinen2019-09-051-48/+32
| | | | | | | | | | | - Initial implementation erroneously assumed that ScrollDestination.START would only be used for scrolling up and ScrollDestination.END for scrolling down. That's obviously not what they are for, otherwise everyone would be using ScrollDestination.ANY. - Moved actual scrolling to within the helper method that originally only calculated the new scroll position. Parent method became too long otherwise. Fixes #11706
* Updated row and spacer handling for Escalator (#11438)Anna Koskinen2019-08-295-973/+2605
| | | | | | | | | | | | | | | | | | | | | | | Updated row and spacer handling for Escalator. Main changes: - Spacers are only maintained and checked for rows that have DOM representation, and not at all if there is no details generator. This gives notable performance improvements to some particularly large Grids - Escalator no longer tries to trim away any rows that don't fit within the viewport just because a details row gets opened in Grid. This leads to some increase in simultaneous DOM elements, but simplifies the logic considerably. For example opening or closing details rows doesn't require checking the overall content validity beyond the details row itself anymore, but some repositioning at most. There are also no longer any orphaned spacers without corresponding DOM rows. - Spacers are better integrated into the overall position calculations. - Some public methods that are no longer used by Escalator or have changed functionality or order of operations. Any extending classes that tap into row, spacer, or scroll position handling are likely to need reworking after this update. - Auto-detecting row height is delayed until Escalator is both attached and displayed.
* Add explicit handling of ctrl-a (#11693)Tatu Lund2019-08-121-0/+8
| | | | | | | | * Add explicit handling of ctrl-a Fixes https://github.com/vaadin/framework/issues/11678 * Adds test case and formatting the code
* Update Chrome version, snapshots and fix tests (#11684)Zhe Sun2019-08-052-4/+6
|
* Update the since tag (#11675)Zhe Sun2019-07-304-4/+4
| | | | * Update the since tag
* Apply offset to column index depending on presense of selection column (#11667)Tatu Lund2019-07-301-1/+5
| | | | | | | | * Apply offset to column index depending on presense of selection column After testing this manually I noticed that offset correction needs to be negative * Add the testing UI
* Ensure the upload button has been disabled when set Enabled calling from ↵Zhe Sun2019-07-291-0/+11
| | | | | | | | | succeedL… (#11655) * Ensure the upload button has been disabled when calling from succeedListener with Push enabled * Add Tests to verify
* Update to 8.10-SNAPSHOT (#11657)Zhe Sun2019-07-291-1/+1
|
* Ensure that VComboBox.selectedOptionKey gets initial selection. (#11665)Anna Koskinen2019-07-241-2/+9
| | | Fixes #10741
* Improvements to detail row index handling. (#11345)Anna Koskinen2019-07-166-11/+212
| | | | | | - Escalator should notify when an existing details row is moved to a new index. - Grid and DetailsManagerConnector should update their internal indexing when details manager index changes in Escalator.
* 11642 refresh pagelength 0 combobox items after dataprovider update (#11653)Olli Tietäväinen2019-07-121-1/+16
| | | | | | * Fixes #11642. ComboBox with pageLength 0 should be updated if DataProvider changes * added comments, fixed imports
* Ensure the selection has been changed before updating . (#11658)Anna Koskinen2019-07-121-11/+7
| | | | | | | - Initial fix attempt interfered with selection events, added regression testing for those and found a better way to ensure shift selection works on IE11 also with Windows 7. Fixes #11608
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-11 01:50:32 +0000