| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Automatic removal of trailing whitespaces in Eclipse does not work even
in a nearly consistent way across platforms, versions or even on the same
maching within the same workspaces. Saving the same file multiple times
even alternates between adding and removing a whitespace on empty block
comment lines when saving.
Change-Id: I0efd307fd48869ea688eb79aa77c9ba38de5a4a6
|
|
|
|
| |
Change-Id: I9c39db5c2ccafd495a1ecc8b28687eeeebe3b6c2
|
|
|
|
|
|
|
| |
Listen to MouseUp event on the <textarea> and notify the state with the width and height if changed.
Add com.vaadin.client.Util.Size to manipulates the css width/height.
Change-Id: I96a308658d2877f1f6c05feaa7840a268bb06709
|
|
|
|
| |
Change-Id: Icdac51322a90c32c122a182bc692c4eff3d8285b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Doing two times session.accessSynchronously is unnecessary effort in
multiple aspects:
* The session will be locked twice.
* CurrentInstances are set twice.
* CurrentInstances are restored twice.
* VaadinSession being checked for being the current via
VaadinService.verifyNoOtherSessionLocked(this);
When we leave requestEnd we unset all CurrentInstances. There is no need
to just restore them before doing so.
When we are in requestEnd, VaadinSession is set to "current" by
PushHandler.callWithUi() or VaadinService.handleRequest().
Also, the cleanupSession code does not need any of these thread locals,
so not having them set would also not hurt.
having an extra accessSynchronously call for just setting the duration
does not make a lot of sense. While it somehow wants to make the previous
accessSynchronously call to be counted completely into the duration it
invests an the same time that would have been left out additionally.
VaadinService removeClosedUIs is a cleanup which also locks and sets
CurrentInstances just to figure out that the UI it is checking is not
closing. This change moves that check out of ui.accessSynchronously.
In the end, the resulting code is a tiny bit less robust, however it
eliminates over 50% response time on trivial push request/responses.
Change-Id: If71d1dbbae5d1fd57d3d4e735c592fd263261a81
|
|
|
|
| |
Change-Id: Ib16d4b8922a139b37d551797ada163b6d6b5e720
|
|
|
|
| |
Change-Id: I5b6298be367e4fe820320a5e3fd6bf5aaa7e2047
|
|
|
|
|
|
|
| |
Atmosphere 2.1.2.vaadin3 includes fix for:
https://github.com/Atmosphere/atmosphere/issues/1643
Change-Id: I67c07dc3b32ebb3b0eed634bf143bac9a7e5efe2
|
|
|
|
| |
Change-Id: I14d782843684f623a2cf671f14d0ab062829ebac
|
|
|
|
|
|
|
| |
If the server sends no token and the client value remains "init" then
it's not sent back to the server.
Change-Id: I74fc470c5c22d57c4a48eab3e4476ae4cc2dd242
|
|
|
|
|
|
|
|
|
| |
There are a few places in frequently used core classes which could
initialize collection classes with the correct (or slightly oversized)
length.
Maps are initialized with 2x the size due to its load factor.
Change-Id: I3aee5a60602937a8550ca5a200ec2a529ff36fe9
|
|
|
|
|
|
|
|
|
| |
This change reduces the amount of intermediate steps taken to initialize
the thread locals for a given ui or vaadin session.
It mainly takes advantage of reusing the old values from the map in set()
instead of creating new ones to put into the "old" map which is returned.
Change-Id: I4dbaff973f46e73f8f3a0c285b14c97603f2d5a4
|
|
|
|
|
|
|
|
|
| |
The setCurrent call on VaadinSession is not needed. the one extra call
can be saved because service.findVaadinSession will already set it.
Added a comment like it is done for UI (service.findUI will also set the
UI).
Change-Id: Ic24d922554d1316aae310813ef5d00a0bbfd418a
|
|
|
|
|
|
|
|
|
|
| |
Non obvious problem before. "config" is a property of AtmosphereFramework
which also has getInitParameter(String) method. So it compiles but does
not do what is intended: to check against the user defined web.xml
servlet init-prams.
(the variableName servletConfig has the same problem :-))
Change-Id: Ib02f0b94312327d482775456c2d63a904b1e8104
|
|
|
|
| |
Change-Id: I5ce36a5c3beffe7b686a8754b6f7311d83b00f87
|
|
|
|
|
|
|
|
|
|
|
|
| |
API change from:
public static Iterable<ClientConnector> getAllChildrenIterable(final ClientConnector connector)
to
public static Iterable<? extends ClientConnector> getAllChildrenIterable(final ClientConnector connector)
avoids creating wrappers in case the component has either no subcomponents
or no extensions. This covers the vast majority of components.
Change-Id: I48ffd2f26f09c265fae6e1aaabdbaa655d52ffb8
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 1b73b00b2875c5eafa3c641b77f5d9efc2f7d929 as
well as the related changes to @since, release notes etc.
Conflicts:
client/src/com/vaadin/client/ResourceLoader.java
client/src/com/vaadin/client/communication/TranslatedURLReference.java
client/src/com/vaadin/client/ui/ui/UIConnector.java
server/src/com/vaadin/ui/UI.java
shared/src/com/vaadin/shared/ui/ui/UIState.java
uitest/src/com/vaadin/tests/tb3/AbstractTB3Test.java
Change-Id: Id882dc730f51055f6d17200964bcaf8a1f87a35f
|
|
|
|
| |
Change-Id: I62610ef647fbbb5a7cfae25ac5c7628f78f2c6ff
|
|
|
|
|
|
| |
Fixed issue with SplitPanels which were not marking sets as dirty.
Change-Id: I23bb8bfca87a825aef132f249e05871cf7b36a34
|
|
|
|
| |
Change-Id: If3fcc88e69d797b219f5af5906853a42d81f693c
|
|
|
|
| |
Change-Id: Iad73c44852c207f29381d59bea25275ac8f24dbd
|
|\
| |
| |
| | |
Change-Id: Ifeb36e6c0acd156b7714f96f32ad7d4ff8416100
|
| |
| |
| |
| | |
Change-Id: I80029235997e29e0d430bccfd3a7b050598e4031
|
|\|
| |
| |
| | |
Change-Id: Iffe877e047ee29dbd4e5b3a6098f82da3d0a47cc
|
| |
| |
| |
| | |
Change-Id: I70c153c4109428686002f985bfe1cb7cba2c9b31
|
|\|
| |
| |
| | |
Change-Id: I9f804f3ba10922a3d59999df06a23f2daa4cd4e8
|
| |
| |
| |
| | |
Change-Id: I351d256230a5cd674a5e1b8066d3e2aef07ff3bf
|
| |
| |
| |
| | |
Change-Id: I51c0722bda9941d16a5f6aad0ce7dfd4a4753587
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Added Automatic Testcase. The testcase needs a default constructor,
which has been added.
The test also found an edge case in Form.java which has been corrected,
as well as one missing getState(false) in AbstractMedia.
Change-Id: Id764c9e1596123015a84f6c2a9507f03bde383b1
|
| |
| |
| |
| |
| |
| |
| | |
Adding 3 getStates() which were missed in
https://github.com/vaadin/vaadin/commit/0c229ae91460fedaeb557bdc5a646433658b0dfb
Change-Id: Ide7949046e4cc3f36c08f419f3010a98e348642c
|
| |
| |
| |
| |
| |
| |
| |
| | |
Many core vaadin components did incorrectly mark the state as dirty when
reading from them. This patch fixes the problem, which should reduce the
amount of server->client state updates significantly.
Change-Id: I342d74129e2985a7f407e9b53a802dc0146d9992
|
| |
| |
| |
| |
| |
| | |
(#14003)
Change-Id: Ia2c3b8331f1ae34effceb0bb624cfaa7ba8578ed
|
| |
| |
| |
| | |
Change-Id: Iee9d5be9208ff54cd0e4a58c19daaa3a917f9b9d
|
|/
|
|
|
|
|
| |
Most style names documented. Some still missing, and a few with TODO
placeholders.
Change-Id: I9388e3b8fb9c23a8f25f47e963a896e0a0606a95
|
|
|
|
|
|
|
|
|
|
| |
If row has no elements or only invisible elements, its size will be set to zero.
When row expand ratio was set, its size will be assigned to the value according to an expand ratio.
If component takes several rows of the gridLayout, these rows are considered as non-empty and won't be removed.
Change-Id: I10ddd22a6c9535b9978769bab7b496e11a28b78a
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JsonCodec#encode() is a frequently called (hot) method. However in its
current form it is too long to be inlined.
This review reduces the length of the method from 454 bytes instructions
to 311 and optimises flow of common calls.
It however has a behaviour change for esoteric edge cases where the
order would matter. Like a custom collection which extends JSONArray and
implements collection. Previously it would have been handled by the
collection case, now its the JSONArray case. However it can be assumed
that the result: serialized to valid JSON is the same.
Change-Id: Ia552eec6322d0760581336b8b038fa03761c1d69
|
|
|
|
| |
Change-Id: I82c77edf5c17c712350cb64831b305b4c8363cf7
|
|
|
|
| |
Change-Id: Ie5c0a00b65d27f65522a14c4fbcd05fe21814cc0
|
|
|
|
| |
Change-Id: I50094bc2d236f6dbb02a8b82d6cc9b5f7e4733a5
|
|
|
|
|
|
|
|
|
|
| |
The UI.pushConnection field is transient no longer; instead PushConnection
implementations must take care of serialization internally. When a session
is serialized, the client should notice that push was disconnected and
try to reconnect. A deserialized PushConnection should be in a "disconnected"
state so the eventual client reconnection works correctly.
Change-Id: I38cfc5a5cdbd3643311f830f8d580458dcd85c56
|
|
|
|
|
|
| |
This reverts commit ce1764fb1bad1b82462d73fbfe293b676c2a9c00.
Change-Id: I897e0f3a0876eaea4b68f0e3b75671ccb1398242
|
|
|
|
| |
Change-Id: I58c89f6c8b2c72e233b1d9e5413da1d6cbc36285
|
|
|
|
| |
Change-Id: I5d400a05071844729d68abb1ba0c31c33e32e9c7
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cleanConnectorMap is a hot method.
This change improves multiple code paths:
1) The global resource handler is no longer get()ed from the session for
each connector (was in two loops).
2) The ConnectorTracker is no longer get()ed from the UI for each
connector (was in one loop).
3) values() iterator for ClientConnectors replaces
keySet() iterator + get(key) call
4) use getUI() from ClientConnector instead manual method.
5) moved removeUnregisteredConnectors to ease inlining and readability.
Change-Id: I25ff5bc32d27d30ecd8d354922ec6e4a02b05921
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
getAllChildrenIterable() is invoked frequently, its used by
attach/detach and markAsDirty.
Because of the implementation detail in CombinedIterator, on every call
all iterators are checked. This means that on every component which has
multiple childs, each next() call will first check the extension
iterator, before advancing in the child iterator.
By having the childs first, this overhead is reduced. If no extensions
are existing (which is quite common) the iterator is not added at all.
(creating an iterator on an empty UnmodifiableCollection is waste of
time and memory)
Change-Id: I23bb91464052ad4282963ec4b5be8a52c6847d4f
|
|
|
|
| |
Change-Id: I9b7b43f176e88d9edca591001297b94475a31854
|
|
|
|
| |
Change-Id: I8698a9ecf691adde9a3bc2e92047be5f3036df1e
|
|
|
|
| |
Change-Id: Ieebe48c75370c0744a2a2619e1ed81dbd090a544
|
|
|
|
| |
Change-Id: I050553b233fb7024049c31d9495d90f4d88239c8
|
|
|
|
|
|
|
|
| |
This fix adds support for typing in color values according to
http://www.w3schools.com/cssref/css_colors_legal.asp into the
colorpicker popup input textfield.
Change-Id: If14ead791725c3052c05aa31e12e237e90c32348
|