| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
* Sanitize input used in Grid header
|
|
|
|
|
|
|
|
| |
osgi-integration (#11335)
* Made VaadinResourceService a OSGi component, removed static access of OsgiVaadinResources
|
|
|
|
|
|
|
|
|
|
| |
* Fixing upload handler error handling
For some reason stream variable cleanup did not use UI.getCurrent(), despite current UI was set earlier in handleRequest, what I see specifically for this purpose. So I chanted this. This will address also issue #7289
Furthermore there was TODO in handle request about error handling. I interpreted this to refer to possible corner case, that UI is not found via session. In this case it is more appropriate throw UploadException and abort, than lat NPE happen.
* Fixing exception type
|
|
|
|
|
|
|
|
| |
* add test case
* Limit the workaround for non-push mode
Fixes #11616
|
|
|
|
|
|
|
|
| |
* Using @Delayed annotation for DateField Rpc
* Separate a rpc for handling the time change in DateTimeField
* Add test case for wrong event order
|
|
|
|
|
|
|
|
|
|
| |
* #11614: Added test which demonstrates that the fix is incomplete
* #11614: UI.doRefresh() only calls navigator when the navigation state actually changes
* Added javadoc to Navigator.getCurrentNavigationState()
* Minor: Removed accidental star imports
|
|
|
|
|
|
|
|
|
|
|
| |
(#11615)
* Fix regression that broke PreserveOnRefresh functionality with Navigator
Fixes https://github.com/vaadin/framework/issues/11614
Old patch https://github.com/vaadin/framework/issues/11416 calls navigateTo allways when Navigator is present, which is wrong, since it is needed only when navigation state has truly changed.
* Add test to the fix
|
|
|
|
|
|
|
|
| |
* Fix duplicate grid column visibility change event
Toggle a column visibility through UI will fire 2 event. There should be only 1.
* Add Test
|
|
|
|
|
|
| |
- limit DataCommunicator workaround from #11320 to ComboBox only
- don't reset DataCommunicator before modifying all sorting data
Fixes #11532
|
|
|
| |
Change so that liferay 7.2 can run Vaadin portlets
|
| |
|
|
|
|
|
|
|
| |
added the no-cache parameter to the reply. (#11556)
* Changed the handleSessionExpired logic to return a 404 instead of a 410. Also added the no-cache parameter to the reply.
See https://github.com/vaadin/framework/issues/4417 for discussion.
|
|
|
|
|
|
| |
* Code format
* Merge branch 'master' into code-format
|
|
|
| |
Spring add-on needs to use these added methods in order to fix #10922
|
|
|
|
|
|
|
|
|
|
| |
issue in #11343 and #11385 is not reproducible on top this patch
Three different bugs are involved in this fix:
we bring the old fix(#11094) back and fixed the other related issues:
1) allow adding the same new item after dataProvider got reset, This is cause by the client side parameter `LastNewItemString`, it saves the value added before resetting.
2) clear the pending newItem eagerly, so that the same value will not be added again.
|
|
|
|
|
|
| |
* Update to 8.9-SNAPSHOT
* update in bom module
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* Create StringToUuidConverter.java
Implements the `Converter` interface, to support converting back-and-forth between `String` and `UUID` (a type built into Java 5 and later).
See Issue # 11,051.
https://github.com/vaadin/framework/issues/11051
* Formatting cleanup, remove sinces
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Clicking on slider makes handler move
Fixes #1496
* Introducing control over clicking behaviour
- User will have to enable process of the click event on handle calling `slider.setEnableClickHandler(true);`
- Clean-up the handler logic in VSlider.java
- Renaming the property to `updateValueOnClick`
- Added JavaDocs
- Fixing tests
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Reset selection on DataProvider change in RadioButtonGroup
Fixes #11454
Other components needing the same fix are ListSelect,NativeSelect,Combobox (The ones implementing HasDataProvider and extending AbstractSingleSelect. Grid is not affected as it extends AbstractListing and hadles selection differently)
* Added test case
Verify that ValueChangeListener is actually fired after value is reset setting new DataProvider
|
|
|
| |
Fixes #11489
|
|
|
|
|
|
|
|
| |
(#11512)
Documents the possibility to use vaadin:// and theme:// in JavaScript and StyleSheet annotations.
Fixes #8675
|
|
|
| |
If BrowserWindowOpener is used with constructor using Class<? extends UI> as parameter, it will have UI provider with generated url. This will not match UI beans in contextual storage and hence newly created UI will not be managed bean. Due this, injection to new UI instance will not happen. If you are using CDI , BrowserWindowOpener(String) constructor needs to be used.
|
| |
|
|
|
|
|
|
|
|
| |
* Fixing NPE when ItemCaptionGenerator returns null
Adding similar logic in setDataProvider(...) as used elsewhere in ComboBox.java (e.g. generateData(..) see line 314)
fixes issue #11434
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* add accessor methods for CUSTOM_SERIALIZERS in JsonCodec
* javadoc
* removed removeCustomSerializer method, renamed putCustomSerializer to addCustomSerializer, added sanity checks and JavaDocs
* refactored addCustomJsonSerializer to set, added test UI
* move enums to be parsed after custom serializers
* move adding custom serializer to static block
* throw an exception if multiple serializers are registered for class
* updated javadocs
* changed CustomJSONSerializerTest to a SingleBrowserTest
* moved CustomJSONSerializerTest to server/ and it's now not a browser test
* removed CustomJSONSerializerTest
|
|
|
|
|
|
| |
IllegalArgumentException (#11461)
|
|
|
|
| |
Fixes #11451
|
|
|
|
|
|
|
|
|
|
| |
* Fix an NPE caused by the previous fix to Grid's frozen columns (#10653)
If the user managed to get two frozen column count changes into a single server round-trip before the component had been attached, the previous fix #11346 lead to a null pointer exception since there was no diff state available.
This fix adds a null check before removing the frozen column count value from the diff state so that this will not happen.
Closes #10653
|
| |
|
|
|
|
|
| |
Navigation needs to be done also in doRefresh(..) in similar fashion as in doInit(..)
Fixes https://github.com/vaadin/framework/issues/11416
|
|
|
|
| |
* Add Javadoc to the ScrollTo methods in TreeGrid
|
| |
|
|
|
|
|
|
|
|
| |
* add possibility to configure nested null behavior to Grid.Column
* added addColumn method that allows configuring the nested null handling behavior of the column
* added uitest for nested null value handling, implements #11137
|
| |
|
|
|
|
| |
* Some formatting changes
|
|
|
|
|
|
|
|
|
| |
* add client side integration for custom styles for checkbox.label and checkbox.input
* add server side integration for checkbox element styling
* add server side tests
* add client side test
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Improve VMenuBar click handling logic
During `updateFromUIDL` inside MenuBarConnector we empty and re-instantiate the components of MenuBar. When we are modifying the Menubar from the BlurEventListener of another component, we ,by this, remove widgets, therefore clickEvent is not fired and the action of the MenuItem is not proceed as a result. (The BlurEvent is fired before the click event in the chain of events. )
To improve the situation, we catch onMouseDown event , which is fired before BlurEvent,by assigning mouseDown flag to true. Then if no click event has yet happened, we delay the execution of update inside `updateFromUIDL` by default 500 ms. Then if click event occurs, it proceeds normally. The time can be increased/decreased using setter.
There is no delay, if we are clicking on the MenuBar as usual or no Blur listener is set.
This change allows setting descriptions
* Remove accidentally committed comment
* Don't update the state on the getDelayMs call
|
|
|
|
| |
* Complete the empty since tag
|
|
|
|
|
|
|
|
|
| |
* Request data update before client response
* fix the accidental commit
* add tests
fixes #11320
|
|
|
|
|
|
|
|
|
| |
* Add missing FocusShortcutListener
Was removed from 8.0 and not readded.
Fixes #8297
* Update Release note for this change
|
|
|
|
|
| |
7.1. (#11156)
* This the range might be necessary to increase when Liferay 7.2 or
newer has been released.
|
|
|
|
|
|
|
| |
In certain cases setting the frozen columns didn't produce the expected result in the client side widget state. This happened if the frozen columns value was set to be the same it was before removeAllColumns was called.
This fix removes the frozen column value from the diff state so that the value gets properly set in the client side.
Closes #10653
|
| |
|
|
|
|
|
|
|
|
| |
* Revert "Update ComboBox internal state on new item added (#11094)"
This reverts commit 56ce91c6160a252ddcd952bca6eb7037120ebf59.
* Add tests to verify the issue
|
|
|
|
| |
* Add javadoc for validate() call in Binder
|
|
|
|
|
|
|
| |
This refactoring addresses two issues cased by dropping updatedData before it was processed. Issues arise , when visibility has change.
Fixes #11274 and similar issue within RadioButton
There is no reliable way to test automatically NativeSelects in Grid, but adding UI test, at least
|
|
|
|
|
|
|
|
| |
Fixes #11276
Refactor the code and correct the logic for validation
Rename an internal variable, as it contains more than one type of messages
|
|
|
| |
Fix upload issue
|
| |
|