aboutsummaryrefslogtreecommitdiffstats
path: root/uitest/src/main
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix indexing issue in Compatibility Grid resize when scrolled to bottom. ↵Anna Koskinen2020-05-131-0/+34
| | | | | (#12003) Issue #11893, cherry-pick from #11984
* Fix RTA's CreateLink in Firefox & IE11 (#11979)Tarek Oraby2020-05-081-0/+38
| | | | | | | In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted. This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted. fixes #11888
* Take overlays into account in getConnectorForElement. (#11980)Anna Koskinen2020-05-051-0/+120
| | | | | | * Take overlays into account in getConnectorForElement. Fixes #11212
* Allow replacing all columns at once when some of them are frozen. (#11978)Anna Koskinen2020-04-301-0/+44
| | | Fixes #11824
* Fix the column width calculations for full width cell contents. (#11974)Anna Koskinen2020-04-291-0/+79
| | | Fixes #11973
* Don't center a window that has already been removed. (#11956)Anna Koskinen2020-04-241-0/+122
| | | | | | * Don't center a window that has already been removed. Fixes #11942
* Allow AbstractDateField to provide DST zone names over custom ranges (#11927)Tarek Oraby2020-04-211-0/+185
| | | | | | | | | DateTimeField and DateField currently implement a hardcoded logic by which they adjust their time zone names to display daylight-saving time (DST) zone names. Specifically, this hardcoded logic only adjusts the displayed date to DST format if that date falls in one of the years between 1980 and the following 20 years in the future from the current date (that is, until 2040 at the time of this commit). For some use cases, this is problematic because it is desirable to display proper DST-adjusted time zones beyond the 20 years limit (and possibly also before 1980). Rather than choosing another arbitrary, hardcoded threshold, this commit extends the AbstractDateField API to allow the user to choose the range (start and end years) between which the DST transition dates are calculated (and hence displayed properly). If the user doesn't invoke this new API, DateTimeField and DateField will default to behave according the existing logic (i.e. display DST zone names between 1980 and 20 years into the future). Closes #11919
* Allow setting Upload button caption as HTML, move data to SharedState. (#11940)Anna Koskinen2020-04-061-0/+40
| | | Fixes #11810
* Prevent upload if no file is selected. (#11939)Anna Koskinen2020-04-034-1/+58
| | | Fixes #10419
* Ensure ChangeListener still works after first upload. (#11936)Anna Koskinen2020-04-011-0/+31
| | | Fixes #10420
* Ensure recalculateColumnWidths works with refreshAll. (#11934)Anna Koskinen2020-03-311-0/+64
| | | | | | | | Column widths shouldn't be calculated between the clearing of cache and re-populating it, but be delayed until the cache has some content again. The calculations should only be triggered immediately if no rows are expected. Fixes #9996
* Fix an issue with frozen column count and unhiding. (#11929)Anna Koskinen2020-03-261-0/+40
| | | | | | | * Fix an issue with frozen column count and unhiding. Unhiding logic should take into account that there can be hidden frozen columns that are not the column currently getting shown.
* Add setters to Criterion to fix serialization. (#11926)Anna Koskinen2020-03-261-0/+59
| | | Fixes #11909
* Tweaked layouttester tests to be more informative. (#11800) (#11813)Anna Koskinen2020-03-2325-30/+297
|
* Trigger re-measure after updating ElementResizeListeners. (#11912)Anna Koskinen2020-03-091-0/+37
| | | | | | | | | | | Removing ElementResizeListeners from an element makes it unmeasurable and clears any saved measured values. Adding the listeners back makes the element measurable again but doesn't add it to measuring queue. Measuring needs to happen or any updates to expanded components within a layout (without changes that would trigger full re-measuring of the layout itself) lead to broken expand size calculations with any fixed size elements assumed to have no size. Fixes #10734
* Further tweaks to ComboBox popup positioning. (#11910)Anna Koskinen2020-03-061-0/+38
| | | | | | | | * Further tweaks to ComboBox popup positioning. - Updated a comment and renamed a private method for better clarity. - Blocked unnecessary position updates. - Added a test for #11866 / #11894.
* Removing code causing the trouble (#11898)Tatu Lund2020-02-241-0/+7
| | | | | | | | | | | | | | | | | | * Removing code causing the trouble Removing code that was apparently not needed in previous fix and caused regression Fixes: https://github.com/vaadin/framework/issues/11895 * Added feature to test UI * Added test case * Adding missing import * Fixing test UI * Enable DateField
* Don't reset date to current at DateField state (e.g. read-only) updates. ↵Anna Koskinen2020-01-281-0/+49
| | | | | | | | | (#11879) - DateFields with month or year resolution should not get their date reset to current date if the field's state is updated (e.g. by changing read-only status or adding a range). Fixes: #11864, #11605
* Ensure value change happens before shortcuts in compatibility components ↵Anna Koskinen2020-01-151-0/+47
| | | | | (#11871) Fixes #10854
* Removed outdated spacer height update from removal process. (#11861)Anna Koskinen2020-01-091-0/+76
| | | | | | * Removed outdated spacer height update from removal process. Fixes #11856
* Fix to RadioButtonGroup readOnly handling. (#11855)Anna Koskinen2019-12-231-0/+36
| | | | | | | | | * Fix to RadioButtonGroup readOnly handling. Updated the connector to use the widget's enabled and readOnly handling as intended. Fixes #11843
* Improvements to popup positioning for ComboBox within HorizontalLayout. (#11846)Anna Koskinen2019-12-181-0/+77
| | | | | | | | Expand ratio and spacing can cause ComboBox to miscalculate its own position while layouting is still ongoing. Popup should not be repositioned in such circumstances in order to avoid incorrect intermediate states. Continues on #11718
* Test tweaks (#11841)Anna Koskinen2019-12-061-1/+1
| | | | | | | | | | | | | | | | - Use BrowserStack workaround for proper sendKeys functionality on IE11. - TreeGridBigDetailsManagerTest: allow two pixel discrepancy in expected scroll position to accommodate IE. - TreeWideContent: switched from raw type to type inference. - ValoColorPickerInputFormatsTest: switched equals comparison to correct way around. - ResponsiveLayoutUpdateTest: updated screenshots for IE - ColumnCollapsingAndColumnExpansionTest: updated screenshots for IE - ClosingWindowWithBrowserFrameShouldntGenerate404Test: test is incompatible with IE driver, excluded from tested browsers. In manual testing IE doesn't get 404 in the logs with or without the fix associated with this test but there are other client-side exceptions related to focus handling in either case. However, those are out of scope for this particular fix and should be investigated separately.
* Close window on ESC, when maximized button is clicked (#11840)Anastasia Smirnova2019-12-051-0/+41
| | | | | | | | | Fixes #11838 Changes: 1. Close a window when maximized button is focused and ESC is pressed 2. Add additional check for a close button to react to the ESC key press 3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
* Delegate enabled handling to Composite root. (#11832)Anna Koskinen2019-11-261-0/+51
| | | | | | | Otherwise the changed state isn't communicated properly to the client-side in the initial round trip, as the client-side uses the child connector's state directly. Fixes #11831
* Updated local screenshot testing configurations. (#11814)Anna Koskinen2019-11-211-21/+32
| | | | | | | | * A separate screenshot module hasn't been in use for a while but local testing configurations and instructions weren't updated to the new model at the time. Could use some further cleanup but this covers the basics. * Some tweaks to ScreenshotBrowser to get it functional again, although the actions for automatically replacing or adding alternative screenshots still require work and have thus been disabled.
* Don't attempt to send expand/collapse events for disabled TreeGrid. (#11823)Anna Koskinen2019-11-211-0/+9
| | | | | | | | | | | | | The attempt gets blocked later down the line in any case and never reaches the server, but sending it messes up TreeGrid's internal state. It gets stuck waiting for the resolution of the blocked call that can then only be resolved by server-side sending its own expand/collapse request programmatically. Until that happens no further expand/collapse attempts will get sent to server even after the TreeGrid has been enabled again. Tree is also affected as it is built upon TreeGrid. Fixes #11822
* Check actual Grid selection instead of relying on allSelected flag. (#11787)Anna Koskinen2019-11-041-0/+71
| | | | | | | | The checkbox for selecting all rows only selects all the rows that have not been filtered out. Changing the filtering does not change the selection or the checkbox state so assuming that all rows are selected simply because the checkbox has been checked cannot work. Fixes #11479
* Fix a timing issue in ComboBox filtering via paste using mouse. (#11780)Anna Koskinen2019-10-311-0/+66
| | | | | | The filtering needs to be delayed, otherwise it's performed before the new filter text is available and the old filter text is used instead. Fixes #11779
* When ComboBox popup opens to the left accommodate margin/border/padding. ↵Anna Koskinen2019-10-231-0/+36
| | | | | (#11755) Fixes #11718
* Make sure expanding/collapsing updates expected cache size. (#11753)Anna Koskinen2019-10-221-0/+112
| | | | | | | | * Make sure expanding/collapsing updates expected cache size. Fixes #11749 * Merge branch 'master' into issue11749
* Make cancellation of uploads work regardless of Push configuration (#11743)Willem Verstraeten2019-10-215-6/+112
| | | | | | | | | | | | | | - Checking the push configuration outside of session lock threw an AssertionError, so the push configuration is not checked anymore. - The original problem with cancelling Upload was due to a subtle ordering issue that depended on the Push configuration. In the case of PushMode.AUTOMATIC, a new StreamVariable was added by the `Upload` component _before_ the `FileUploadHandler` got a chance to remove the old `StreamVariable`. As a result, the `FileUploadHandler` actually removed the fresh `StreamVariable`, breaking future uploads. Fixes #11682
* Upload should preserve MIMEType after first selection (#11745)Anastasia Smirnova2019-10-161-0/+51
| | | | | | | | | | | | | | | | * Upload should preserve MIMEType after first selection Fix #11698 Automated test is not run locally, need to continue with it * Remove unused imports * Add sleep time in testing purposes * Getting a new instance of an input, after file is downloaded Exclude IE from tests. Throws https://stackoverflow.com/questions/23883071/unhandled-alert-exception-modal-dialog-present-selenium , but checked manually and it works
* Fix scrollTo for destination START and END and add regression testing. (#11707)Anna Koskinen2019-09-051-0/+33
| | | | | | | | | | | - Initial implementation erroneously assumed that ScrollDestination.START would only be used for scrolling up and ScrollDestination.END for scrolling down. That's obviously not what they are for, otherwise everyone would be using ScrollDestination.ANY. - Moved actual scrolling to within the helper method that originally only calculated the new scroll position. Parent method became too long otherwise. Fixes #11706
* Updated row and spacer handling for Escalator (#11438)Anna Koskinen2019-08-293-8/+102
| | | | | | | | | | | | | | | | | | | | | | | Updated row and spacer handling for Escalator. Main changes: - Spacers are only maintained and checked for rows that have DOM representation, and not at all if there is no details generator. This gives notable performance improvements to some particularly large Grids - Escalator no longer tries to trim away any rows that don't fit within the viewport just because a details row gets opened in Grid. This leads to some increase in simultaneous DOM elements, but simplifies the logic considerably. For example opening or closing details rows doesn't require checking the overall content validity beyond the details row itself anymore, but some repositioning at most. There are also no longer any orphaned spacers without corresponding DOM rows. - Spacers are better integrated into the overall position calculations. - Some public methods that are no longer used by Escalator or have changed functionality or order of operations. Any extending classes that tap into row, spacer, or scroll position handling are likely to need reworking after this update. - Auto-detecting row height is delayed until Escalator is both attached and displayed.
* Read-only styles shouldn't override borderless background styles. (#11692)Anna Koskinen2019-08-1612-14/+167
| | | | | | | | | | | * Read-only styles shouldn't override borderless background styles. - Fixed for ComboBox and DateField styles, other tested components already do it right. Fixes #11671 * Merge branch 'master' into issue11671
* Add explicit handling of ctrl-a (#11693)Tatu Lund2019-08-121-0/+27
| | | | | | | | * Add explicit handling of ctrl-a Fixes https://github.com/vaadin/framework/issues/11678 * Adds test case and formatting the code
* Apply offset to column index depending on presense of selection column (#11667)Tatu Lund2019-07-301-0/+67
| | | | | | | | * Apply offset to column index depending on presense of selection column After testing this manually I noticed that offset correction needs to be negative * Add the testing UI
* Ensure the upload button has been disabled when set Enabled calling from ↵Zhe Sun2019-07-291-0/+65
| | | | | | | | | succeedL… (#11655) * Ensure the upload button has been disabled when calling from succeedListener with Push enabled * Add Tests to verify
* Ensure that VComboBox.selectedOptionKey gets initial selection. (#11665)Anna Koskinen2019-07-241-0/+55
| | | Fixes #10741
* Improvements to detail row index handling. (#11345)Anna Koskinen2019-07-163-0/+216
| | | | | | - Escalator should notify when an existing details row is moved to a new index. - Grid and DetailsManagerConnector should update their internal indexing when details manager index changes in Escalator.
* 11642 refresh pagelength 0 combobox items after dataprovider update (#11653)Olli Tietäväinen2019-07-121-0/+116
| | | | | | * Fixes #11642. ComboBox with pageLength 0 should be updated if DataProvider changes * added comments, fixed imports
* Clicking on DateField pop-up should select Month/Year (#11531)Anastasia Smirnova2019-06-251-0/+56
| | | | | | | | | * Clicking on DateField pop-up should select Month/Year In Year/Month Resolution DateField should select the value, when user clicks on pop-up Fixes #8447
* Limit previous solution for non-push mode UI (#11629)Zhe Sun2019-06-241-0/+18
| | | | | | | | * add test case * Limit the workaround for non-push mode Fixes #11616
* Separates a rpc for handling the client event order in DateTimeField (#11574)Zhe Sun2019-06-141-0/+54
| | | | | | | | * Using @Delayed annotation for DateField Rpc * Separate a rpc for handling the time change in DateTimeField * Add test case for wrong event order
* Improved fix for #11614 (#11618)Martin Vysny2019-06-131-0/+17
| | | | | | | | | | * #11614: Added test which demonstrates that the fix is incomplete * #11614: UI.doRefresh() only calls navigator when the navigation state actually changes * Added javadoc to Navigator.getCurrentNavigationState() * Minor: Removed accidental star imports
* Fix regression that broke PreserveOnRefresh functionality with Navigator ↵Tatu Lund2019-06-071-0/+29
| | | | | | | | | | | (#11615) * Fix regression that broke PreserveOnRefresh functionality with Navigator Fixes https://github.com/vaadin/framework/issues/11614 Old patch https://github.com/vaadin/framework/issues/11416 calls navigateTo allways when Navigator is present, which is wrong, since it is needed only when navigation state has truly changed. * Add test to the fix
* Recalculate the column widths before the first row is added (#11609)Zhe Sun2019-06-061-0/+49
| | | | | | | * Recalculate the column widths before the first row is added Fixes #11607
* Grid Editor: make Tab key skip read-only/disabled fields (#11586)Martin Vysny2019-06-031-2/+23
| | | | | | | | | | | | | | | | * Grid Editor: make Tab key skip read-only/disabled fields Closes #11584 * Extracted DefaultEditorEventHandler.getDeltaFromKeyDownEvent() which allows for easy further Grid Editor customization * Make DefaultEditorEventHandler.Delta public so that getDeltaFromKeyDownEvent() can be overridden * Fixed exception in isEditable() if the widget was not a Field * Refactored DefaultEditorEventHandler.Delta to CursorMoveDelta which expresses the intent more clearly * Merge branch 'master' into master
* Fix Grid reordering when there are hidden columnscuong-phan2019-05-201-0/+76
| | | | | | | | * Fix grid column reordering Fix grid column reordering when there are hidden columns and footerRow.join * Add test
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-03 21:27:34 +0000