| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
| |
Adapted from V7 fix #10999
|
|
|
|
|
| |
(#12003)
Issue #11893, cherry-pick from #11984
|
| |
|
| |
|
|
|
|
|
|
|
| |
In Firefox and IE11, the 'Create Link' button of the RichTextArea (RTA) only works by turning some highlighted text into a link (by adding the inserted URI as the href property of the text). In that, the RTA in these two browsers behave similarly to the way it does in Chrome and Edge. However, in Firefox and IE11, clicking the 'Create Link' button has no effect if no text is pre-selected by the user. This is different from the button's behavior in Chrome and Edge where the user's provided URI is inserted, both, as the displayed text and its href property if no text is highlighted.
This fix enables the RTA's 'Create Link' button to work consistently across the supported browsers. Specifically, (and in addition to enabling adding the href property of a highlighted text), this fix enables Firefox and IE11 to also insert a new Uri as a text and its href property if no text is already highlighted.
fixes #11888
|
|
|
|
|
|
| |
* Take overlays into account in getConnectorForElement.
Fixes #11212
|
|
|
| |
Fixes #11824
|
|
|
| |
Fixes #11973
|
|
|
|
|
|
| |
* Don't center a window that has already been removed.
Fixes #11942
|
|
|
|
| |
Cherry pick from
https://github.com/vaadin/framework/pull/11946
|
|
|
|
|
|
|
|
|
| |
DateTimeField and DateField currently implement a hardcoded logic by which they adjust their time zone names to display daylight-saving time (DST) zone names. Specifically, this hardcoded logic only adjusts the displayed date to DST format if that date falls in one of the years between 1980 and the following 20 years in the future from the current date (that is, until 2040 at the time of this commit).
For some use cases, this is problematic because it is desirable to display proper DST-adjusted time zones beyond the 20 years limit (and possibly also before 1980).
Rather than choosing another arbitrary, hardcoded threshold, this commit extends the AbstractDateField API to allow the user to choose the range (start and end years) between which the DST transition dates are calculated (and hence displayed properly). If the user doesn't invoke this new API, DateTimeField and DateField will default to behave according the existing logic (i.e. display DST zone names between 1980 and 20 years into the future).
Closes #11919
|
| |
|
|
|
| |
Fixes #11108
|
|
|
| |
Fixes #11810
|
|
|
| |
Fixes #10419
|
|
|
| |
Fixes #10420
|
|
|
|
|
|
|
|
| |
Column widths shouldn't be calculated between the clearing of cache and
re-populating it, but be delayed until the cache has some content again.
The calculations should only be triggered immediately if no rows are
expected.
Fixes #9996
|
|
|
|
| |
* Updated LayoutTester screenshots for IE and FF.
|
|
|
|
|
|
|
| |
* Fix an issue with frozen column count and unhiding.
Unhiding logic should take into account that there can be hidden frozen
columns that are not the column currently getting shown.
|
|
|
| |
Fixes #11909
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Removing ElementResizeListeners from an element makes it unmeasurable
and clears any saved measured values. Adding the listeners back makes
the element measurable again but doesn't add it to measuring queue.
Measuring needs to happen or any updates to expanded components within a
layout (without changes that would trigger full re-measuring of the
layout itself) lead to broken expand size calculations with any fixed
size elements assumed to have no size.
Fixes #10734
|
|
|
|
|
|
|
|
| |
* Further tweaks to ComboBox popup positioning.
- Updated a comment and renamed a private method for better clarity.
- Blocked unnecessary position updates.
- Added a test for #11866 / #11894.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Removing code causing the trouble
Removing code that was apparently not needed in previous fix and caused regression
Fixes: https://github.com/vaadin/framework/issues/11895
* Added feature to test UI
* Added test case
* Adding missing import
* Fixing test UI
* Enable DateField
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix logic of lexicographical comparison of DateField range end
Fix logic of lexicographical comparison of DateField range end with large year numbers ( > 9999)
Fixes #11881
* Added tests
Purpose of dateFieldRangeYearDigitsIncrease() is to test that rangeEnd works correctly on 4 to 5 digits change boundary
Purpose of dateFieldRangeYearBigNumbersPopupOpens() is to test that popup opens also when there is more than 4 digits in year
* Fixing typo
* Add error message
* Set the date of the field in test
* Fixing
|
|
|
|
|
|
|
|
|
| |
(#11879)
- DateFields with month or year resolution should not get their date
reset to current date if the field's state is updated (e.g. by changing
read-only status or adding a range).
Fixes: #11864, #11605
|
|
|
|
|
| |
* Update to 8.11-SNAPSHOT
|
|
|
|
|
| |
(#11871)
Fixes #10854
|
| |
|
| |
|
|
|
|
|
|
| |
* Removed outdated spacer height update from removal process.
Fixes #11856
|
|
|
|
|
|
|
|
|
| |
* Fix to RadioButtonGroup readOnly handling.
Updated the connector to use the widget's enabled and readOnly handling
as intended.
Fixes #11843
|
|
|
|
|
|
|
|
|
| |
* Test tweaks
Less fixed waiting times when there are ways to check that the operation
has been performed. This will hopefully improve the stability a bit.
* Merge branch 'master' into updateTests20191218
|
|
|
|
|
|
|
|
| |
Expand ratio and spacing can cause ComboBox to miscalculate its own
position while layouting is still ongoing. Popup should not be
repositioned in such circumstances in order to avoid incorrect
intermediate states.
Continues on #11718
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use BrowserStack workaround for proper sendKeys functionality on IE11.
- TreeGridBigDetailsManagerTest: allow two pixel discrepancy in expected
scroll position to accommodate IE.
- TreeWideContent: switched from raw type to type inference.
- ValoColorPickerInputFormatsTest: switched equals comparison to correct
way around.
- ResponsiveLayoutUpdateTest: updated screenshots for IE
- ColumnCollapsingAndColumnExpansionTest: updated screenshots for IE
- ClosingWindowWithBrowserFrameShouldntGenerate404Test: test is
incompatible with IE driver, excluded from tested browsers. In manual
testing IE doesn't get 404 in the logs with or without the fix
associated with this test but there are other client-side exceptions
related to focus handling in either case. However, those are out of
scope for this particular fix and should be investigated separately.
|
|
|
|
|
|
|
|
|
| |
Fixes #11838
Changes:
1. Close a window when maximized button is focused and ESC is pressed
2. Add additional check for a close button to react to the ESC key press
3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
|
|
|
|
|
|
|
| |
Otherwise the changed state isn't communicated properly to the
client-side in the initial round trip, as the client-side uses the child
connector's state directly.
Fixes #11831
|
|
|
|
|
|
|
|
| |
* A separate screenshot module hasn't been in use for a while but local
testing configurations and instructions weren't updated to the new model
at the time. Could use some further cleanup but this covers the basics.
* Some tweaks to ScreenshotBrowser to get it functional again, although
the actions for automatically replacing or adding alternative
screenshots still require work and have thus been disabled.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The attempt gets blocked later down the line in any case and never
reaches the server, but sending it messes up TreeGrid's internal state.
It gets stuck waiting for the resolution of the blocked call that can
then only be resolved by server-side sending its own expand/collapse
request programmatically. Until that happens no further expand/collapse
attempts will get sent to server even after the TreeGrid has been
enabled again.
Tree is also affected as it is built upon TreeGrid.
Fixes #11822
|
|
|
|
|
|
|
|
| |
The checkbox for selecting all rows only selects all the rows that have
not been filtered out. Changing the filtering does not change the
selection or the checkbox state so assuming that all rows are selected
simply because the checkbox has been checked cannot work.
Fixes #11479
|
|
|
|
|
|
| |
The filtering needs to be delayed, otherwise it's performed before the
new filter text is available and the old filter text is used instead.
Fixes #11779
|
|
|
|
|
|
|
|
| |
- The new top row logical index should always be within the logical
range and high enough up to avoid leaving a gap if possible.
- Added regression testing for using the different scroll destination
types for scrolling to the top and to the bottom by index.
Fixes #11732
|
| |
|
| |
|
|
|
|
|
| |
(#11755)
Fixes #11718
|
|
|
|
|
|
|
|
| |
* Make sure expanding/collapsing updates expected cache size.
Fixes #11749
* Merge branch 'master' into issue11749
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Checking the push configuration outside of session lock threw
an AssertionError, so the push configuration is not checked anymore.
- The original problem with cancelling Upload was due to a subtle
ordering issue that depended on the Push configuration.
In the case of PushMode.AUTOMATIC, a new StreamVariable was
added by the `Upload` component _before_ the `FileUploadHandler`
got a chance to remove the old `StreamVariable`. As a result, the
`FileUploadHandler` actually removed the fresh `StreamVariable`,
breaking future uploads.
Fixes #11682
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Upload should preserve MIMEType after first selection
Fix #11698
Automated test is not run locally, need to continue with it
* Remove unused imports
* Add sleep time in testing purposes
* Getting a new instance of an input, after file is downloaded
Exclude IE from tests. Throws https://stackoverflow.com/questions/23883071/unhandled-alert-exception-modal-dialog-present-selenium , but checked manually and it works
|