From 98207e5a3b98f8e257ebf87608331f01dee909ed Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Fri, 3 Aug 2012 12:45:26 +0000 Subject: Longer pause to make test more reliable svn changeset:24056/svn branch:6.8 --- tests/testbench/com/vaadin/tests/components/embedded/EmbeddedPdf.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedPdf.html b/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedPdf.html index 758a004445..c550b0f5d9 100644 --- a/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedPdf.html +++ b/tests/testbench/com/vaadin/tests/components/embedded/EmbeddedPdf.html @@ -20,7 +20,7 @@ pause - 4000 + 8000 screenCapture -- cgit v1.2.3 From fcee628c1292fe0c32de9036ab97be15f2d9823f Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Fri, 3 Aug 2012 12:45:39 +0000 Subject: Throw IllegalArgumentException from addParameter for null parameters instead of silently ignoring them (#9147) svn changeset:24057/svn branch:6.8 --- .../data/util/sqlcontainer/query/generator/StatementHelper.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/com/vaadin/data/util/sqlcontainer/query/generator/StatementHelper.java b/src/com/vaadin/data/util/sqlcontainer/query/generator/StatementHelper.java index f9458609c3..b012ce7685 100644 --- a/src/com/vaadin/data/util/sqlcontainer/query/generator/StatementHelper.java +++ b/src/com/vaadin/data/util/sqlcontainer/query/generator/StatementHelper.java @@ -47,6 +47,10 @@ public class StatementHelper implements Serializable { if (parameter != null) { parameters.add(parameter); dataTypes.put(parameters.size() - 1, parameter.getClass()); + } else { + throw new IllegalArgumentException( + "You cannot add null parameters using addParamaters(Object). " + + "Use addParameters(Object,Class) instead"); } } -- cgit v1.2.3 From 082985c68ad0b6c7f8c155cce2a5a79070176c09 Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Fri, 3 Aug 2012 12:45:45 +0000 Subject: Shim iframe should not have tabindex (#6219) svn changeset:24058/svn branch:6.8 --- src/com/vaadin/terminal/gwt/client/ui/VOverlay.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/com/vaadin/terminal/gwt/client/ui/VOverlay.java b/src/com/vaadin/terminal/gwt/client/ui/VOverlay.java index 31ed3ebb5d..f385aa0676 100644 --- a/src/com/vaadin/terminal/gwt/client/ui/VOverlay.java +++ b/src/com/vaadin/terminal/gwt/client/ui/VOverlay.java @@ -236,6 +236,7 @@ public class VOverlay extends PopupPanel implements CloseHandler { // shim behind the shadow due to its transparency. shimElement.getStyle().setPosition(Position.ABSOLUTE); shimElement.getStyle().setBorderStyle(BorderStyle.NONE); + shimElement.setTabIndex(-1); shimElement.setFrameBorder(0); shimElement.setMarginHeight(0); } -- cgit v1.2.3 From 197e7ce782968dfda2fd7849547ffdec59a387f5 Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Fri, 3 Aug 2012 13:54:15 +0000 Subject: Do not submit TextArea value on enter in IE (#9139) svn changeset:24060/svn branch:6.8 --- src/com/vaadin/terminal/gwt/client/ui/VTextArea.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/com/vaadin/terminal/gwt/client/ui/VTextArea.java b/src/com/vaadin/terminal/gwt/client/ui/VTextArea.java index c6107e3b0e..0ed5887442 100644 --- a/src/com/vaadin/terminal/gwt/client/ui/VTextArea.java +++ b/src/com/vaadin/terminal/gwt/client/ui/VTextArea.java @@ -5,6 +5,7 @@ package com.vaadin.terminal.gwt.client.ui; import com.google.gwt.core.client.Scheduler; +import com.google.gwt.event.dom.client.KeyDownEvent; import com.google.gwt.user.client.Command; import com.google.gwt.user.client.DOM; import com.google.gwt.user.client.Element; @@ -76,4 +77,11 @@ public class VTextArea extends VTextField { // detected in a different way. return getImpl().getTextAreaCursorPos(getElement()); } + + @Override + public void onKeyDown(KeyDownEvent event) { + // Overridden to avoid submitting TextArea value on enter in IE. This is + // another reason why widgets should inherit a common abstract + // class instead of directly each other. + } } -- cgit v1.2.3