From 53a4b2c77a6af86c157884c62e6193911242a7f9 Mon Sep 17 00:00:00 2001 From: Teemu Suo-Anttila Date: Mon, 6 Jul 2015 10:01:17 +0300 Subject: Refactor Grid SelectionModels as extensions (#18624) This patch removes all selection related variables and API from several core parts of Grid. Change-Id: Idb7aa48fda69ded1ef58a69c1f7dbc78b7f52a54 --- WebContent/release-notes.html | 2 + .../AbstractSelectionModelConnector.java | 82 +++++ .../vaadin/client/connectors/GridConnector.java | 207 ------------ .../connectors/MultiSelectionModelConnector.java | 360 +++++++++++++++++++++ .../connectors/NoSelectionModelConnector.java | 42 +++ .../client/connectors/RpcDataSourceConnector.java | 6 +- .../connectors/SingleSelectionModelConnector.java | 148 +++++++++ client/src/com/vaadin/client/widgets/Grid.java | 12 +- .../com/vaadin/data/RpcDataProviderExtension.java | 25 +- server/src/com/vaadin/ui/Grid.java | 317 +++++++++--------- .../com/vaadin/shared/data/DataProviderRpc.java | 12 +- .../com/vaadin/shared/ui/grid/GridClientRpc.java | 11 - .../com/vaadin/shared/ui/grid/GridServerRpc.java | 4 - .../src/com/vaadin/shared/ui/grid/GridState.java | 15 +- .../selection/MultiSelectionModelServerRpc.java | 55 ++++ .../grid/selection/MultiSelectionModelState.java | 31 ++ .../selection/SingleSelectionModelServerRpc.java | 35 ++ .../grid/selection/SingleSelectionModelState.java | 30 ++ .../components/grid/GridCustomSelectionModel.java | 37 +++ .../grid/GridCustomSelectionModelTest.java | 58 ++++ .../client/grid/MySelectionModelConnector.java | 61 ++++ 21 files changed, 1135 insertions(+), 415 deletions(-) create mode 100644 client/src/com/vaadin/client/connectors/AbstractSelectionModelConnector.java create mode 100644 client/src/com/vaadin/client/connectors/MultiSelectionModelConnector.java create mode 100644 client/src/com/vaadin/client/connectors/NoSelectionModelConnector.java create mode 100644 client/src/com/vaadin/client/connectors/SingleSelectionModelConnector.java create mode 100644 shared/src/com/vaadin/shared/ui/grid/selection/MultiSelectionModelServerRpc.java create mode 100644 shared/src/com/vaadin/shared/ui/grid/selection/MultiSelectionModelState.java create mode 100644 shared/src/com/vaadin/shared/ui/grid/selection/SingleSelectionModelServerRpc.java create mode 100644 shared/src/com/vaadin/shared/ui/grid/selection/SingleSelectionModelState.java create mode 100644 uitest/src/com/vaadin/tests/components/grid/GridCustomSelectionModel.java create mode 100644 uitest/src/com/vaadin/tests/components/grid/GridCustomSelectionModelTest.java create mode 100644 uitest/src/com/vaadin/tests/widgetset/client/grid/MySelectionModelConnector.java diff --git a/WebContent/release-notes.html b/WebContent/release-notes.html index 61511b3002..e9b4a24ce1 100644 --- a/WebContent/release-notes.html +++ b/WebContent/release-notes.html @@ -119,6 +119,8 @@ This may interfere with custom response compression solutions that do not respect the Content-Encoding response header.
  • Unused methods related to the "out of sync" message have been removed from SystemMessages class.
  • All notifications use the WAI-ARIA alert role to be compatible with Jaws
  • +
  • Grid SelectionModels are now Extensions. This update removes all selection related variables and API from + GridConnector, GridState, GridServerRpc and GridClientRpc
  • Known Issues and Limitations