From 548650bfe02f6e2582f06cecee2333099d951718 Mon Sep 17 00:00:00 2001 From: Leif Åstrand Date: Thu, 18 May 2017 13:36:11 +0300 Subject: Rename findAndFilterDependencies to findDependencies (#9366) The old findDependencies method is made private since it's only an implementation detail and should not be used from outside the class. At the same time, the new findAndFilterDependencies method is renamed to findDependencies since there's no longer necessary to have a name that distinguishes it from the variant that doesn't do any filtering. --- server/src/main/java/com/vaadin/server/BootstrapHandler.java | 8 ++++---- .../src/main/java/com/vaadin/server/communication/UidlWriter.java | 4 ++-- server/src/main/java/com/vaadin/ui/Dependency.java | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/server/src/main/java/com/vaadin/server/BootstrapHandler.java b/server/src/main/java/com/vaadin/server/BootstrapHandler.java index bd091c6cc1..01fd2bf880 100644 --- a/server/src/main/java/com/vaadin/server/BootstrapHandler.java +++ b/server/src/main/java/com/vaadin/server/BootstrapHandler.java @@ -577,10 +577,10 @@ public abstract class BootstrapHandler extends SynchronizedRequestHandler { .attr("href", themeUri + "/favicon.ico"); } - Collection deps = Dependency - .findAndFilterDependencies(Collections.singletonList(uiClass), - context.getSession().getCommunicationManager(), - new FilterContext(context.getSession())); + Collection deps = Dependency.findDependencies( + Collections.singletonList(uiClass), + context.getSession().getCommunicationManager(), + new FilterContext(context.getSession())); for (Dependency dependency : deps) { Type type = dependency.getType(); String url = context.getUriResolver() diff --git a/server/src/main/java/com/vaadin/server/communication/UidlWriter.java b/server/src/main/java/com/vaadin/server/communication/UidlWriter.java index ee25a95f8a..c6c2d77fcb 100644 --- a/server/src/main/java/com/vaadin/server/communication/UidlWriter.java +++ b/server/src/main/java/com/vaadin/server/communication/UidlWriter.java @@ -285,8 +285,8 @@ public class UidlWriter implements Serializable { List dependencies = new ArrayList<>(); dependencies.addAll(ui.getPage().getPendingDependencies()); - dependencies.addAll(Dependency.findAndFilterDependencies( - newConnectorTypes, manager, new FilterContext(session))); + dependencies.addAll(Dependency.findDependencies(newConnectorTypes, + manager, new FilterContext(session))); // Include dependencies in output if there are any if (!dependencies.isEmpty()) { diff --git a/server/src/main/java/com/vaadin/ui/Dependency.java b/server/src/main/java/com/vaadin/ui/Dependency.java index 537887a9f2..6557590c08 100644 --- a/server/src/main/java/com/vaadin/ui/Dependency.java +++ b/server/src/main/java/com/vaadin/ui/Dependency.java @@ -158,7 +158,7 @@ public class Dependency implements Serializable { * @return the list of found dependencies */ @SuppressWarnings("deprecation") - public static List findDependencies( + private static List findDependencies( List> connectorTypes, LegacyCommunicationManager manager) { List dependencies = new ArrayList<>(); @@ -191,7 +191,7 @@ public class Dependency implements Serializable { * the context information for the filtering operation * @return the list of found and filtered dependencies */ - public static List findAndFilterDependencies( + public static List findDependencies( List> connectorTypes, LegacyCommunicationManager manager, FilterContext context) { List dependencies = findDependencies(connectorTypes, -- cgit v1.2.3