From 7143ac15789848269d00024ed9dc68b77402fbb9 Mon Sep 17 00:00:00 2001 From: Pekka Hyvönen Date: Thu, 22 Dec 2016 16:04:48 +0200 Subject: Remove unused caption from Column constructor (#8077) * Remove unused caption from Column constructor Fixes #8063 --- server/src/main/java/com/vaadin/ui/Grid.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/server/src/main/java/com/vaadin/ui/Grid.java b/server/src/main/java/com/vaadin/ui/Grid.java index 8b07501f07..592a811f21 100644 --- a/server/src/main/java/com/vaadin/ui/Grid.java +++ b/server/src/main/java/com/vaadin/ui/Grid.java @@ -796,8 +796,7 @@ public class Grid extends AbstractListing implements HasComponents, * @param renderer * the type of value */ - protected Column(String caption, - ValueProvider valueProvider, + protected Column(ValueProvider valueProvider, Renderer renderer) { Objects.requireNonNull(valueProvider, "Value provider can't be null"); @@ -1882,8 +1881,7 @@ public class Grid extends AbstractListing implements HasComponents, ValueProvider valueProvider, AbstractRenderer renderer) { String generatedIdentifier = getGeneratedIdentifier(); - Column column = new Column<>("Column " + generatedIdentifier, - valueProvider, renderer); + Column column = new Column<>(valueProvider, renderer); addColumn(generatedIdentifier, column); return column; } @@ -3023,7 +3021,7 @@ public class Grid extends AbstractListing implements HasComponents, String id = DesignAttributeHandler.readAttribute("column-id", col.attributes(), null, String.class); DeclarativeValueProvider provider = new DeclarativeValueProvider<>(); - Column column = new Column<>("", provider, + Column column = new Column<>(provider, new HtmlRenderer()); addColumn(getGeneratedIdentifier(), column); if (id != null) { -- cgit v1.2.3