From b7e184e30f8e5f1456344f3360c7e8e326c5ad2b Mon Sep 17 00:00:00 2001 From: Juho Nurminen Date: Wed, 20 Nov 2013 17:08:16 +0200 Subject: Cleaned up the implementation of VTabsheet.selectPreviousTab() Change-Id: I8e7fef3005173d7647b4dfda31f60978cbf5972a --- client/src/com/vaadin/client/ui/VTabsheet.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/client/src/com/vaadin/client/ui/VTabsheet.java b/client/src/com/vaadin/client/ui/VTabsheet.java index 68a685965b..85c28218f7 100644 --- a/client/src/com/vaadin/client/ui/VTabsheet.java +++ b/client/src/com/vaadin/client/ui/VTabsheet.java @@ -1164,12 +1164,9 @@ public class VTabsheet extends VTabsheetBase implements Focusable, activeTabIndex = newTabIndex; if (isScrolledTabs()) { // Scroll until the new active tab is visible - int newScrollerIndex = scrollerIndex; - while (tb.getTab(activeTabIndex).getAbsoluteLeft() < getAbsoluteLeft() - && newScrollerIndex != -1) { - newScrollerIndex = tb.scrollLeft(newScrollerIndex); + while (!tb.getTab(activeTabIndex).isVisible()) { + scrollerIndex = tb.scrollLeft(scrollerIndex); } - scrollerIndex = newScrollerIndex; updateTabScroller(); } } -- cgit v1.2.3