From d213a4244341f52846505aa430677ae58954d04e Mon Sep 17 00:00:00 2001 From: Tatu Lund Date: Wed, 10 Apr 2019 13:07:43 +0300 Subject: Fixing autocompletion issue with ComboBox on newer Chrome versions (#11472) * Fixing autocompletion issue with ComboBox on newer Chrome versions Newer Chrome versions do not work with random number hack to prevent auto completion, but it finally supports autocomplete=off. * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 * Merge branch 'master' into fix11437 --- client/src/main/java/com/vaadin/client/ui/VComboBox.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/client/src/main/java/com/vaadin/client/ui/VComboBox.java b/client/src/main/java/com/vaadin/client/ui/VComboBox.java index 95e4505d68..fbac85c2af 100644 --- a/client/src/main/java/com/vaadin/client/ui/VComboBox.java +++ b/client/src/main/java/com/vaadin/client/ui/VComboBox.java @@ -1372,7 +1372,12 @@ public class VComboBox extends Composite implements Field, KeyDownHandler, * way, and they might be useful in a combo box where new items are * allowed. */ - getElement().setAttribute("autocomplete", Math.random() + ""); + if (BrowserInfo.get().isChrome()) { + // Chrome supports "off" and random number does not work with Chrome + getElement().setAttribute("autocomplete", "off"); + } else { + getElement().setAttribute("autocomplete", Math.random() + ""); + } } /** -- cgit v1.2.3