From db19b40724d0012697d04e3e70311347a563e9ee Mon Sep 17 00:00:00 2001 From: Maciej PrzepioĢra Date: Thu, 28 Apr 2016 16:34:33 +0300 Subject: Throw IAE in setExpandRatio() if given ratio is less than 0 Change-Id: Ie7f92edea210c54400f6dce38e1376e3c0eae575 --- server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java b/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java index f517ab0af5..d6df3f372a 100644 --- a/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java +++ b/server/src/main/java/com/vaadin/ui/AbstractOrderedLayout.java @@ -328,6 +328,10 @@ public abstract class AbstractOrderedLayout extends AbstractLayout implements * @param component * the component in this layout which expand ratio is to be set * @param ratio + * new expand ratio (greater or equal to 0) + * @throws IllegalArgumentException + * if the expand ratio is negative or the component is not a + * direct child of the layout */ public void setExpandRatio(Component component, float ratio) { ChildComponentData childData = getState().childData.get(component); @@ -335,6 +339,10 @@ public abstract class AbstractOrderedLayout extends AbstractLayout implements throw new IllegalArgumentException( "The given component is not a child of this layout"); } + if (ratio < 0.0f) { + throw new IllegalArgumentException( + "Expand ratio can't be less than 0.0"); + } childData.expandRatio = ratio; } -- cgit v1.2.3