From f6a9a9ad489be81bb7327096b038cc6b63cfa39a Mon Sep 17 00:00:00 2001 From: Hk-tang Date: Mon, 6 Apr 2020 08:38:29 -0600 Subject: Change to using StringBuilder (#11941) Should use a StringBuilder to accumulate strings in a loop, to avoid the performance cost of repeatedly constructing strings. --- server/src/main/java/com/vaadin/ui/declarative/Design.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/src/main/java/com/vaadin/ui/declarative/Design.java b/server/src/main/java/com/vaadin/ui/declarative/Design.java index 0b78a9cbde..a2c698c6bd 100644 --- a/server/src/main/java/com/vaadin/ui/declarative/Design.java +++ b/server/src/main/java/com/vaadin/ui/declarative/Design.java @@ -234,14 +234,14 @@ public class Design implements Serializable { throw new DesignException("Unknown tag: " + tagName); } String[] classNameParts = parts[1].split("-"); - String className = ""; + StringBuilder className = new StringBuilder(); for (String classNamePart : classNameParts) { // Split will ignore trailing and multiple dashes but that // should be // ok // will be resolved to // will be resolved to - className += SharedUtil.capitalize(classNamePart); + className.append(SharedUtil.capitalize(classNamePart)); } String qualifiedClassName = packageName + "." + className; -- cgit v1.2.3