From dee87e1172cee9be7c4d2b22e3974babecc30906 Mon Sep 17 00:00:00 2001
From: Jouni Koivuviita <jouni@vaadin.com>
Date: Thu, 7 Aug 2014 14:42:46 +0300
Subject: Empty rows in Table are badly styles (#14112)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Reduced padding around widgets inside table cells also.

Set z-index for drag’n’drop styles to set the above any relative
positioned widgets inside table cells.

Change-Id: I512c61428aa88678261f276148d3ba39134a6411
---
 WebContent/VAADIN/themes/valo/components/_table.scss | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

(limited to 'WebContent/VAADIN/themes/valo/components/_table.scss')

diff --git a/WebContent/VAADIN/themes/valo/components/_table.scss b/WebContent/VAADIN/themes/valo/components/_table.scss
index deef084561..2335c59873 100644
--- a/WebContent/VAADIN/themes/valo/components/_table.scss
+++ b/WebContent/VAADIN/themes/valo/components/_table.scss
@@ -162,6 +162,7 @@ $v-table-background-color: null !default;
   .#{$primary-stylename}-cell-content {
     border-left: $v-table-border-width solid $border-color;
     overflow: hidden;
+    height: $v-table-row-height;
 
     &:first-child {
       border-left: none;
@@ -181,6 +182,10 @@ $v-table-background-color: null !default;
     padding: $vertical-padding $v-table-cell-padding-horizontal;
     @include box-sizing(border-box);
     margin-right: 0 !important;
+
+    > .v-widget {
+      margin: round($vertical-padding / -2) round($v-table-cell-padding-horizontal / -2);
+    }
   }
 
   .#{$primary-stylename}-body {
@@ -429,6 +434,7 @@ $v-table-background-color: null !default;
     content: "";
     display: block;
     position: absolute;
+    z-index: 1;
     height: $v-table-row-height + $v-table-border-width;
     left: 0;
     right: 0;
@@ -588,8 +594,16 @@ $v-table-background-color: null !default;
     height: $row-height;
   }
 
+  .#{$primary-stylename}-cell-content {
+    height: $row-height;
+  }
+
   .#{$primary-stylename}-cell-wrapper {
     padding: $vertical-padding $cell-padding-horizontal;
+
+    > .v-widget {
+      margin: round($vertical-padding / -2) round($cell-padding-horizontal / -2);
+    }
   }
 
   .#{$primary-stylename}-header-cell-asc .#{$primary-stylename}-sort-indicator,
-- 
cgit v1.2.3