From 1b188073c46c5c21bb8ddeb21674452c9bc414fd Mon Sep 17 00:00:00 2001
From: Marc Englund <marc@vaadin.com>
Date: Wed, 8 May 2013 09:31:09 +0300
Subject: Remove pre-loader element after pre-loading, fixes #10863

Change-Id: Ibd2009315aadb25e574c82f3b4b54c501d9b1395
Ticket: 10863
---
 client/src/com/vaadin/client/ResourceLoader.java | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

(limited to 'client/src')

diff --git a/client/src/com/vaadin/client/ResourceLoader.java b/client/src/com/vaadin/client/ResourceLoader.java
index b3b9ac7256..7fc8b4f9f3 100644
--- a/client/src/com/vaadin/client/ResourceLoader.java
+++ b/client/src/com/vaadin/client/ResourceLoader.java
@@ -50,8 +50,8 @@ public class ResourceLoader {
      * Event fired when a resource has been loaded.
      */
     public static class ResourceLoadEvent {
-        private ResourceLoader loader;
-        private String resourceUrl;
+        private final ResourceLoader loader;
+        private final String resourceUrl;
         private final boolean preload;
 
         /**
@@ -286,25 +286,35 @@ public class ResourceLoader {
             // Inject loader element if this is the first time this is preloaded
             // AND the resources isn't already being loaded in the normal way
 
-            Element element = getPreloadElement(url);
+            final Element element = getPreloadElement(url);
             addOnloadHandler(element, new ResourceLoadListener() {
                 @Override
                 public void onLoad(ResourceLoadEvent event) {
                     fireLoad(event);
+                    Document.get().getBody().removeChild(element);
                 }
 
                 @Override
                 public void onError(ResourceLoadEvent event) {
                     fireError(event);
+                    Document.get().getBody().removeChild(element);
                 }
             }, event);
 
-            // TODO Remove object when loaded (without causing spinner in FF)
             Document.get().getBody().appendChild(element);
         }
     }
 
     private static Element getPreloadElement(String url) {
+        /*-
+         * TODO
+         * In Chrome, FF:
+         * <object> does not fire event if resource is 404 -> eternal spinner.
+         * <img> always fires onerror -> no way to know if it loaded -> eternal spinner
+         * <script type="text/javascript> fires, but also executes -> not preloading
+         * <script type="text/cache"> does not fire events
+         *  XHR not tested - should work, probably causes other issues
+         -*/
         if (BrowserInfo.get().isIE()) {
             ScriptElement element = Document.get().createScriptElement();
             element.setSrc(url);
-- 
cgit v1.2.3


From ce9c818b8c1cd290747d841166008898187e7a58 Mon Sep 17 00:00:00 2001
From: John Alhroos <john.ahlroos@itmill.com>
Date: Tue, 30 Apr 2013 07:48:53 +0000
Subject: Instead of applying workaround to the root panel, apply it to the sub
 window content element instead to prevent scrolling of the document when a
 sub window is removed. #11713 (#10776)

svn changeset:25899/svn branch:6.8

Change-Id: Ib3cb61e024ba461bcc146b9beb4a52cb6df9ce28
---
 client/src/com/vaadin/client/ui/VWindow.java | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

(limited to 'client/src')

diff --git a/client/src/com/vaadin/client/ui/VWindow.java b/client/src/com/vaadin/client/ui/VWindow.java
index fd2a701334..51a775cb7e 100644
--- a/client/src/com/vaadin/client/ui/VWindow.java
+++ b/client/src/com/vaadin/client/ui/VWindow.java
@@ -419,14 +419,6 @@ public class VWindow extends VOverlay implements ShortcutActionHandlerOwner,
 
     @Override
     public void hide() {
-        if (vaadinModality) {
-            hideModalityCurtain();
-        }
-        super.hide();
-
-        // Remove window from windowOrder to avoid references being left
-        // hanging.
-        windowOrder.remove(this);
 
         /*
          * If the window has a RichTextArea and the RTA is focused at the time
@@ -443,20 +435,28 @@ public class VWindow extends VOverlay implements ShortcutActionHandlerOwner,
         if (BrowserInfo.get().isIE8()) {
             fixIE8FocusCaptureIssue();
         }
+
+        if (vaadinModality) {
+            hideModalityCurtain();
+        }
+        super.hide();
+
+        // Remove window from windowOrder to avoid references being left
+        // hanging.
+        windowOrder.remove(this);
     }
 
     private void fixIE8FocusCaptureIssue() {
         Element e = DOM.createInputText();
         Style elemStyle = e.getStyle();
         elemStyle.setPosition(Position.ABSOLUTE);
-        elemStyle.setLeft(-10, Unit.PX);
+        elemStyle.setTop(-10, Unit.PX);
         elemStyle.setWidth(0, Unit.PX);
         elemStyle.setHeight(0, Unit.PX);
 
-        Element rootPanel = RootPanel.getBodyElement();
-        rootPanel.appendChild(e);
+        contentPanel.getElement().appendChild(e);
         e.focus();
-        rootPanel.removeChild(e);
+        contentPanel.getElement().removeChild(e);
     }
 
     /** For internal use only. May be removed or replaced in the future. */
-- 
cgit v1.2.3


From ffd1c1bff51433440a5ea4f41fd042790b6b897a Mon Sep 17 00:00:00 2001
From: Johannes Dahlström <johannesd@vaadin.com>
Date: Mon, 6 May 2013 15:14:32 +0300
Subject: Don't ignore child component margins in AbstractOrderedLayout
 (#11553)

Change-Id: I89d8364b97bfe7d072cc7e5221b35ab3cdb3c58b
---
 .../ui/orderedlayout/VAbstractOrderedLayout.java   | 16 +---
 .../tests/layouts/MarginWithExpandRatio.html       | 27 +++++++
 .../tests/layouts/MarginWithExpandRatio.java       | 85 ++++++++++++++++++++++
 3 files changed, 116 insertions(+), 12 deletions(-)
 create mode 100644 uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html
 create mode 100644 uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java

(limited to 'client/src')

diff --git a/client/src/com/vaadin/client/ui/orderedlayout/VAbstractOrderedLayout.java b/client/src/com/vaadin/client/ui/orderedlayout/VAbstractOrderedLayout.java
index d8b0888936..b5a6262693 100644
--- a/client/src/com/vaadin/client/ui/orderedlayout/VAbstractOrderedLayout.java
+++ b/client/src/com/vaadin/client/ui/orderedlayout/VAbstractOrderedLayout.java
@@ -503,14 +503,10 @@ public class VAbstractOrderedLayout extends FlowPanel {
                         // TODO check caption position
                         if (vertical) {
                             int size = layoutManager.getOuterHeight(slot
-                                    .getWidget().getElement())
-                                    - layoutManager.getMarginHeight(slot
-                                            .getWidget().getElement());
+                                    .getWidget().getElement());
                             if (slot.hasCaption()) {
                                 size += layoutManager.getOuterHeight(slot
-                                        .getCaptionElement())
-                                        - layoutManager.getMarginHeight(slot
-                                                .getCaptionElement());
+                                        .getCaptionElement());
                             }
                             if (size > 0) {
                                 totalSize += size;
@@ -518,14 +514,10 @@ public class VAbstractOrderedLayout extends FlowPanel {
                         } else {
                             int max = -1;
                             max = layoutManager.getOuterWidth(slot.getWidget()
-                                    .getElement())
-                                    - layoutManager.getMarginWidth(slot
-                                            .getWidget().getElement());
+                                    .getElement());
                             if (slot.hasCaption()) {
                                 int max2 = layoutManager.getOuterWidth(slot
-                                        .getCaptionElement())
-                                        - layoutManager.getMarginWidth(slot
-                                                .getCaptionElement());
+                                        .getCaptionElement());
                                 max = Math.max(max, max2);
                             }
                             if (max > 0) {
diff --git a/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html
new file mode 100644
index 0000000000..3132bdd16d
--- /dev/null
+++ b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.html
@@ -0,0 +1,27 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head profile="http://selenium-ide.openqa.org/profiles/test-case">
+<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
+<link rel="selenium.base" href="http://localhost:8070/" />
+<title>MarginWithExpandRatio</title>
+</head>
+<body>
+<table cellpadding="1" cellspacing="1" border="1">
+<thead>
+<tr><td rowspan="1" colspan="3">MarginWithExpandRatio</td></tr>
+</thead><tbody>
+<tr>
+	<td>open</td>
+	<td>/run/MarginWithExpandRatio?restartApplication</td>
+	<td></td>
+</tr>
+<tr>
+	<td>screenCapture</td>
+	<td></td>
+	<td>no-overflow</td>
+</tr>
+
+</tbody></table>
+</body>
+</html>
diff --git a/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java
new file mode 100644
index 0000000000..f6ee26e86f
--- /dev/null
+++ b/uitest/src/com/vaadin/tests/layouts/MarginWithExpandRatio.java
@@ -0,0 +1,85 @@
+/*
+ * Copyright 2000-2013 Vaadin Ltd.
+ * 
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ * 
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+
+package com.vaadin.tests.layouts;
+
+import com.vaadin.server.VaadinRequest;
+import com.vaadin.tests.components.AbstractTestUI;
+import com.vaadin.tests.util.TestUtils;
+import com.vaadin.ui.GridLayout;
+import com.vaadin.ui.HorizontalLayout;
+import com.vaadin.ui.Label;
+import com.vaadin.ui.Layout;
+import com.vaadin.ui.Panel;
+import com.vaadin.ui.VerticalLayout;
+
+public class MarginWithExpandRatio extends AbstractTestUI {
+
+    @Override
+    protected void setup(VaadinRequest request) {
+        TestUtils.injectCSS(this,
+                ".hugemargin { margin: 10px 20px !important; }");
+
+        HorizontalLayout hl = new HorizontalLayout();
+        addLayoutTest(hl);
+        hl.setExpandRatio(hl.getComponent(0), 1.0f);
+        hl.setExpandRatio(hl.getComponent(2), 0.5f);
+        VerticalLayout vl = new VerticalLayout();
+        addLayoutTest(vl);
+        vl.setExpandRatio(vl.getComponent(0), 1.0f);
+        vl.setExpandRatio(vl.getComponent(2), 0.5f);
+
+        GridLayout gl = new GridLayout(2, 1);
+        addLayoutTest(gl);
+        gl.setColumnExpandRatio(0, 1.0f);
+        gl.setRowExpandRatio(0, 1.0f);
+        gl.setColumnExpandRatio(1, 0.5f);
+        gl.setRowExpandRatio(1, 0.5f);
+    }
+
+    @Override
+    protected String getTestDescription() {
+        return "Layout content overflows if CSS margin used with expand ratio";
+    }
+
+    @Override
+    protected Integer getTicketNumber() {
+        return 11553;
+    }
+
+    private void addLayoutTest(Layout l) {
+        l.setSizeFull();
+
+        Label lbl = new Label("First (expand ratio 1)");
+        lbl.setSizeUndefined();
+        l.addComponent(lbl);
+
+        lbl = new Label("Second (margin 10px)");
+        lbl.setSizeUndefined();
+        lbl.addStyleName("hugemargin");
+        l.addComponent(lbl);
+
+        lbl = new Label("Third (margin+xr)");
+        lbl.setSizeUndefined();
+        lbl.addStyleName("hugemargin");
+        l.addComponent(lbl);
+
+        Panel p = new Panel(l.getClass().getSimpleName(), l);
+        p.setWidth("600px");
+        p.setHeight("200px");
+        addComponent(p);
+    }
+}
-- 
cgit v1.2.3


From 21d9b67d8bf5841aee0116fef031f549b3417af9 Mon Sep 17 00:00:00 2001
From: Henri Sara <hesara@vaadin.com>
Date: Fri, 10 May 2013 13:17:56 +0300
Subject: Add a large number of debug calls to VFilterSelect (disabled by
 default)

Change-Id: Idd2d20ad01d4715a9f4693af8a7c293786dbae4b
---
 client/src/com/vaadin/client/ui/VFilterSelect.java | 85 ++++++++++++++++++++--
 1 file changed, 80 insertions(+), 5 deletions(-)

(limited to 'client/src')

diff --git a/client/src/com/vaadin/client/ui/VFilterSelect.java b/client/src/com/vaadin/client/ui/VFilterSelect.java
index cea3489b42..cd6ca290cc 100644
--- a/client/src/com/vaadin/client/ui/VFilterSelect.java
+++ b/client/src/com/vaadin/client/ui/VFilterSelect.java
@@ -199,6 +199,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          */
         SuggestionPopup() {
             super(true, false, true);
+            debug("VFS.SP: constructor()");
             setOwner(VFilterSelect.this);
             menu = new SuggestionMenu();
             setWidget(menu);
@@ -235,6 +236,11 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
                 final Collection<FilterSelectSuggestion> currentSuggestions,
                 final int currentPage, final int totalSuggestions) {
 
+            if (enableDebug) {
+                debug("VFS.SP: showSuggestions(" + currentSuggestions + ", "
+                        + currentPage + ", " + totalSuggestions + ")");
+            }
+
             /*
              * We need to defer the opening of the popup so that the parent DOM
              * has stabilized so we can calculate an absolute top and left
@@ -302,6 +308,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * @param active
          */
         private void setNextButtonActive(boolean active) {
+            if (enableDebug) {
+                debug("VFS.SP: setNextButtonActive(" + active + ")");
+            }
             if (active) {
                 DOM.sinkEvents(down, Event.ONCLICK);
                 down.setClassName(VFilterSelect.this.getStylePrimaryName()
@@ -319,6 +328,10 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * @param active
          */
         private void setPrevButtonActive(boolean active) {
+            if (enableDebug) {
+                debug("VFS.SP: setPrevButtonActive(" + active + ")");
+            }
+
             if (active) {
                 DOM.sinkEvents(up, Event.ONCLICK);
                 up.setClassName(VFilterSelect.this.getStylePrimaryName()
@@ -335,6 +348,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * Selects the next item in the filtered selections
          */
         public void selectNextItem() {
+            debug("VFS.SP: selectNextItem()");
             final MenuItem cur = menu.getSelectedItem();
             final int index = 1 + menu.getItems().indexOf(cur);
             if (menu.getItems().size() > index) {
@@ -354,6 +368,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * Selects the previous item in the filtered selections
          */
         public void selectPrevItem() {
+            debug("VFS.SP: selectPrevItem()");
             final MenuItem cur = menu.getSelectedItem();
             final int index = -1 + menu.getItems().indexOf(cur);
             if (index > -1) {
@@ -388,6 +403,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
             @Override
             public void run() {
+                debug("VFS.SP.LPS: run()");
                 if (pagesToScroll != 0) {
                     if (!waitingForFilteringResponse) {
                         /*
@@ -408,6 +424,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
             }
 
             public void scrollUp() {
+                debug("VFS.SP.LPS: scrollUp()");
                 if (currentPage + pagesToScroll > 0) {
                     pagesToScroll--;
                     cancel();
@@ -416,6 +433,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
             }
 
             public void scrollDown() {
+                debug("VFS.SP.LPS: scrollDown()");
                 if (totalMatches > (currentPage + pagesToScroll + 1)
                         * pageLength) {
                     pagesToScroll++;
@@ -435,6 +453,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
         @Override
         public void onBrowserEvent(Event event) {
+            debug("VFS.SP: onBrowserEvent()");
             if (event.getTypeInt() == Event.ONCLICK) {
                 final Element target = DOM.eventGetTarget(event);
                 if (target == up || target == DOM.getChild(up, 0)) {
@@ -468,6 +487,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          *            Should the paging be turned on?
          */
         public void setPagingEnabled(boolean paging) {
+            debug("VFS.SP: setPagingEnabled(" + paging + ")");
             if (isPagingEnabled == paging) {
                 return;
             }
@@ -493,6 +513,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
         @Override
         public void setPosition(int offsetWidth, int offsetHeight) {
+            debug("VFS.SP: setPosition()");
 
             int top = -1;
             int left = -1;
@@ -571,6 +592,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * @return true if popup was just closed
          */
         public boolean isJustClosed() {
+            debug("VFS.SP: justClosed()");
             final long now = (new Date()).getTime();
             return (lastAutoClosed > 0 && (now - lastAutoClosed) < 200);
         }
@@ -585,6 +607,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
         @Override
         public void onClose(CloseEvent<PopupPanel> event) {
+            if (enableDebug) {
+                debug("VFS.SP: onClose(" + event.isAutoClosed() + ")");
+            }
             if (event.isAutoClosed()) {
                 lastAutoClosed = (new Date()).getTime();
             }
@@ -600,6 +625,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          */
         public void updateStyleNames(UIDL uidl,
                 AbstractComponentState componentState) {
+            debug("VFS.SP: updateStyleNames()");
             setStyleName(VFilterSelect.this.getStylePrimaryName()
                     + "-suggestpopup");
             menu.setStyleName(VFilterSelect.this.getStylePrimaryName()
@@ -635,6 +661,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
                     @Override
                     public void execute() {
+                        debug("VFS.SM: delayedImageLoadExecutioner()");
                         if (suggestionPopup.isVisible()
                                 && suggestionPopup.isAttached()) {
                             setWidth("");
@@ -652,6 +679,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          */
         SuggestionMenu() {
             super(true);
+            debug("VFS.SM: constructor()");
             addDomHandler(this, LoadEvent.getType());
         }
 
@@ -675,6 +703,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          */
         public void setSuggestions(
                 Collection<FilterSelectSuggestion> suggestions) {
+            if (enableDebug) {
+                debug("VFS.SM: setSuggestions(" + suggestions + ")");
+            }
             // Reset keyboard selection when contents is updated to avoid
             // reusing old, invalid data
             setKeyboardSelectedItem(null);
@@ -699,6 +730,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * is made or on a blur event.
          */
         public void doSelectedItemAction() {
+            debug("VFS.SM: doSelectedItemAction()");
             // do not send a value change event if null was and stays selected
             final String enteredItemValue = tb.getText();
             if (nullSelectionAllowed && "".equals(enteredItemValue)
@@ -728,6 +760,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
          * Triggered after a selection has been made
          */
         public void doPostFilterSelectedItemAction() {
+            debug("VFS.SM: doPostFilterSelectedItemAction()");
             final MenuItem item = getSelectedItem();
             final String enteredItemValue = tb.getText();
 
@@ -824,6 +857,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
         @Override
         public void onLoad(LoadEvent event) {
+            debug("VFS.SM: onLoad()");
             // Handle icon onload events to ensure shadow is resized
             // correctly
             delayedImageLoadExecutioner.trigger();
@@ -831,6 +865,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
         }
 
         public void selectFirstItem() {
+            debug("VFS.SM: selectFirstItem()");
             MenuItem firstItem = getItems().get(0);
             selectItem(firstItem);
         }
@@ -844,6 +879,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
         }
 
         public void selectLastItem() {
+            debug("VFS.SM: selectLastItem()");
             List<MenuItem> items = getItems();
             MenuItem lastItem = items.get(items.size() - 1);
             selectItem(lastItem);
@@ -1130,6 +1166,10 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      *            Whether to send the options request immediately
      */
     private void filterOptions(int page, String filter, boolean immediate) {
+        if (enableDebug) {
+            debug("VFS: filterOptions(" + page + ", " + filter + ", "
+                    + immediate + ")");
+        }
         if (filter.equals(lastFilter) && currentPage == page) {
             if (!suggestionPopup.isAttached()) {
                 suggestionPopup.showSuggestions(currentSuggestions,
@@ -1156,10 +1196,12 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
     /** For internal use only. May be removed or replaced in the future. */
     public void updateReadOnly() {
+        debug("VFS: updateReadOnly()");
         tb.setReadOnly(readonly || !textInputEnabled);
     }
 
     public void setTextInputEnabled(boolean textInputEnabled) {
+        debug("VFS: setTextInputEnabled()");
         // Always update styles as they might have been overwritten
         if (textInputEnabled) {
             removeStyleDependentName(STYLE_NO_INPUT);
@@ -1182,6 +1224,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      *            the text to set in the text box
      */
     public void setTextboxText(final String text) {
+        if (enableDebug) {
+            debug("VFS: setTextboxText(" + text + ")");
+        }
         tb.setText(text);
     }
 
@@ -1190,6 +1235,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      * in the text box if nothing has been entered.
      */
     public void setPromptingOn() {
+        debug("VFS: setPromptingOn()");
         if (!prompting) {
             prompting = true;
             addStyleDependentName(CLASSNAME_PROMPT);
@@ -1207,6 +1253,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      *            The text the text box should contain.
      */
     public void setPromptingOff(String text) {
+        debug("VFS: setPromptingOff()");
         setTextboxText(text);
         if (prompting) {
             prompting = false;
@@ -1221,6 +1268,10 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      *            The suggestion that just got selected.
      */
     public void onSuggestionSelected(FilterSelectSuggestion suggestion) {
+        if (enableDebug) {
+            debug("VFS: onSuggestionSelected(" + suggestion.caption + ": "
+                    + suggestion.key + ")");
+        }
         updateSelectionWhenReponseIsReceived = false;
 
         currentSuggestion = suggestion;
@@ -1316,7 +1367,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
         if (enabled && !readonly) {
             int keyCode = event.getNativeKeyCode();
 
-            debug("key down: " + keyCode);
+            if (enableDebug) {
+                debug("VFS: key down: " + keyCode);
+            }
             if (waitingForFilteringResponse
                     && navigationKeyCodes.contains(keyCode)) {
                 /*
@@ -1324,18 +1377,25 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
                  * waiting for a response. This avoids flickering, disappearing
                  * items, wrongly interpreted responses and more.
                  */
-                debug("Ignoring " + keyCode
-                        + " because we are waiting for a filtering response");
+                if (enableDebug) {
+                    debug("Ignoring "
+                            + keyCode
+                            + " because we are waiting for a filtering response");
+                }
                 DOM.eventPreventDefault(DOM.eventGetCurrentEvent());
                 event.stopPropagation();
                 return;
             }
 
             if (suggestionPopup.isAttached()) {
-                debug("Keycode " + keyCode + " target is popup");
+                if (enableDebug) {
+                    debug("Keycode " + keyCode + " target is popup");
+                }
                 popupKeyDown(event);
             } else {
-                debug("Keycode " + keyCode + " target is text field");
+                if (enableDebug) {
+                    debug("Keycode " + keyCode + " target is text field");
+                }
                 inputFieldKeyDown(event);
             }
         }
@@ -1354,6 +1414,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      *            The KeyDownEvent
      */
     private void inputFieldKeyDown(KeyDownEvent event) {
+        if (enableDebug) {
+            debug("VFS: inputFieldKeyDown(" + event.getNativeKeyCode() + ")");
+        }
         switch (event.getNativeKeyCode()) {
         case KeyCodes.KEY_DOWN:
         case KeyCodes.KEY_UP:
@@ -1396,6 +1459,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      *            The KeyDownEvent of the key
      */
     private void popupKeyDown(KeyDownEvent event) {
+        if (enableDebug) {
+            debug("VFS: popupKeyDown(" + event.getNativeKeyCode() + ")");
+        }
         // Propagation of handled events is stopped so other handlers such as
         // shortcut key handlers do not also handle the same events.
         switch (event.getNativeKeyCode()) {
@@ -1476,6 +1542,9 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
     @Override
     public void onKeyUp(KeyUpEvent event) {
+        if (enableDebug) {
+            debug("VFS: onKeyUp(" + event.getNativeKeyCode() + ")");
+        }
         if (enabled && !readonly) {
             switch (event.getNativeKeyCode()) {
             case KeyCodes.KEY_ENTER:
@@ -1503,6 +1572,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
      * Resets the Select to its initial state
      */
     private void reset() {
+        debug("VFS: reset()");
         if (currentSuggestion != null) {
             String text = currentSuggestion.getReplacementString();
             setPromptingOff(text);
@@ -1525,6 +1595,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
     @Override
     public void onClick(ClickEvent event) {
+        debug("VFS: onClick()");
         if (textInputEnabled
                 && event.getNativeEvent().getEventTarget().cast() == tb
                         .getElement()) {
@@ -1592,6 +1663,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
     @Override
     public void onFocus(FocusEvent event) {
+        debug("VFS: onFocus()");
 
         /*
          * When we disable a blur event in ie we need to refocus the textfield.
@@ -1630,6 +1702,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
     @Override
     public void onBlur(BlurEvent event) {
+        debug("VFS: onBlur()");
 
         if (BrowserInfo.get().isIE() && preventNextBlurEventInIE) {
             /*
@@ -1690,6 +1763,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
 
     @Override
     public void focus() {
+        debug("VFS: focus()");
         focused = true;
         if (prompting && !readonly) {
             setPromptingOff("");
@@ -1789,6 +1863,7 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
              */
             if (BrowserInfo.get().isIE() && focused) {
                 preventNextBlurEventInIE = true;
+                debug("VFS: Going to prevent next blur event on IE");
             }
         }
     }
-- 
cgit v1.2.3


From 19e27a15ca765de477fbe929a1cb6a7412c523f7 Mon Sep 17 00:00:00 2001
From: Henri Sara <hesara@vaadin.com>
Date: Fri, 10 May 2013 13:39:17 +0300
Subject: Move suggestion popup width calculation from connector to
 VFilterSelect

Change-Id: I846b71c453524ecc525c6ab6c528dffcc7715558
---
 client/src/com/vaadin/client/ui/VFilterSelect.java | 23 ++++++++++++++++++++++
 .../client/ui/combobox/ComboBoxConnector.java      | 14 ++-----------
 2 files changed, 25 insertions(+), 12 deletions(-)

(limited to 'client/src')

diff --git a/client/src/com/vaadin/client/ui/VFilterSelect.java b/client/src/com/vaadin/client/ui/VFilterSelect.java
index cd6ca290cc..b83197ed2d 100644
--- a/client/src/com/vaadin/client/ui/VFilterSelect.java
+++ b/client/src/com/vaadin/client/ui/VFilterSelect.java
@@ -1621,6 +1621,29 @@ public class VFilterSelect extends Composite implements Field, KeyDownHandler,
         }
     }
 
+    /**
+     * Update minimum width for FilterSelect textarea based on input prompt and
+     * suggestions.
+     * <p>
+     * For internal use only. May be removed or replaced in the future.
+     */
+    public void updateSuggestionPopupMinWidth() {
+        // used only to calculate minimum width
+        String captions = Util.escapeHTML(inputPrompt);
+
+        for (FilterSelectSuggestion suggestion : currentSuggestions) {
+            // Collect captions so we can calculate minimum width for
+            // textarea
+            if (captions.length() > 0) {
+                captions += "|";
+            }
+            captions += Util.escapeHTML(suggestion.getReplacementString());
+        }
+
+        // Calculate minimum textarea width
+        suggestionPopupMinWidth = minWidth(captions);
+    }
+
     /**
      * Calculate minimum width for FilterSelect textarea.
      * <p>
diff --git a/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java b/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
index 98d2651849..e96d27032b 100644
--- a/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
+++ b/client/src/com/vaadin/client/ui/combobox/ComboBoxConnector.java
@@ -20,7 +20,6 @@ import java.util.Iterator;
 import com.vaadin.client.ApplicationConnection;
 import com.vaadin.client.Paintable;
 import com.vaadin.client.UIDL;
-import com.vaadin.client.Util;
 import com.vaadin.client.ui.AbstractFieldConnector;
 import com.vaadin.client.ui.SimpleManagedLayout;
 import com.vaadin.client.ui.VFilterSelect;
@@ -124,9 +123,6 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
             getWidget().totalMatches = 0;
         }
 
-        // used only to calculate minimum popup width
-        String captions = Util.escapeHTML(getWidget().inputPrompt);
-
         for (final Iterator<?> i = options.getChildIterator(); i.hasNext();) {
             final UIDL optionUidl = (UIDL) i.next();
             final FilterSelectSuggestion suggestion = getWidget().new FilterSelectSuggestion(
@@ -152,12 +148,6 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
                 getWidget().currentSuggestion = suggestion;
                 getWidget().setSelectedItemIcon(suggestion.getIconUri());
             }
-
-            // Collect captions so we can calculate minimum width for textarea
-            if (captions.length() > 0) {
-                captions += "|";
-            }
-            captions += Util.escapeHTML(suggestion.getReplacementString());
         }
 
         if ((!getWidget().waitingForFilteringResponse || getWidget().popupOpenerClicked)
@@ -222,8 +212,8 @@ public class ComboBoxConnector extends AbstractFieldConnector implements
             }
         }
 
-        // Calculate minumum textarea width
-        getWidget().suggestionPopupMinWidth = getWidget().minWidth(captions);
+        // Calculate minimum textarea width
+        getWidget().updateSuggestionPopupMinWidth();
 
         getWidget().popupOpenerClicked = false;
 
-- 
cgit v1.2.3