From 7e44bb38e1c4b0166e78697da74f33517cd1e4f3 Mon Sep 17 00:00:00 2001 From: Anna Koskinen Date: Wed, 30 Oct 2019 12:26:32 +0200 Subject: Switch from an assert to logging and return in Grid.onBrowserEvent (#11778) - If the Grid has frozen columns zooming can cause the regular column cells to be ever so slightly out of sync with their corresponding rows. This difference is not noticeable to naked eye but is big enough that it's possible to hover over the row instead of the cell, which causes an assertion error and a big ugly error popup. Switching to logging retains the information delivered by the assertion error for developer purposes but makes the end user experience smoother. - Can be tested manually with GridColumnFrozenColumn test UI. Fixes #11198 --- client/src/main/java/com/vaadin/client/widgets/Grid.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'client/src') diff --git a/client/src/main/java/com/vaadin/client/widgets/Grid.java b/client/src/main/java/com/vaadin/client/widgets/Grid.java index 2cbeb9cd21..977935c9bf 100755 --- a/client/src/main/java/com/vaadin/client/widgets/Grid.java +++ b/client/src/main/java/com/vaadin/client/widgets/Grid.java @@ -7809,8 +7809,11 @@ public class Grid extends ResizeComposite implements HasSelectionHandlers, } } - assert cell != null : "received " + eventType - + "-event with a null cell target"; + if (cell == null) { + getLogger().log(Level.WARNING, + "received " + eventType + "-event with a null cell target"); + return; + } eventCell.set(cell, getSectionFromContainer(container)); GridEvent gridEvent = new GridEvent<>(event, eventCell); -- cgit v1.2.3