From 7fd440d2448587f7e9958e84c84ec2bfd30ba8a0 Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Thu, 28 Sep 2017 07:45:09 +0200 Subject: Use single character for StringBuilder.append (#10102) --- .../java/com/vaadin/client/extensions/ResponsiveConnector.java | 8 ++++---- client/src/main/java/com/vaadin/client/ui/VEmbedded.java | 4 ++-- client/src/main/java/com/vaadin/client/ui/VFlash.java | 4 ++-- .../java/com/vaadin/client/ui/popupview/PopupViewConnector.java | 8 ++++---- 4 files changed, 12 insertions(+), 12 deletions(-) (limited to 'client/src') diff --git a/client/src/main/java/com/vaadin/client/extensions/ResponsiveConnector.java b/client/src/main/java/com/vaadin/client/extensions/ResponsiveConnector.java index f18ecb0711..17b37da617 100644 --- a/client/src/main/java/com/vaadin/client/extensions/ResponsiveConnector.java +++ b/client/src/main/java/com/vaadin/client/extensions/ResponsiveConnector.java @@ -104,17 +104,17 @@ public class ResponsiveConnector extends AbstractExtensionConnector protected String constructSelectorsForTarget() { String primaryStyle = target.getState().primaryStyleName; StringBuilder selectors = new StringBuilder(); - selectors.append(".").append(primaryStyle); + selectors.append('.').append(primaryStyle); if (target.getState().styles != null && target.getState().styles.size() > 0) { for (String style : target.getState().styles) { selectors.append(",.").append(style); - selectors.append(",.").append(primaryStyle).append(".") + selectors.append(",.").append(primaryStyle).append('.') .append(style); - selectors.append(",.").append(style).append(".") + selectors.append(",.").append(style).append('.') .append(primaryStyle); - selectors.append(",.").append(primaryStyle).append("-") + selectors.append(",.").append(primaryStyle).append('-') .append(style); } } diff --git a/client/src/main/java/com/vaadin/client/ui/VEmbedded.java b/client/src/main/java/com/vaadin/client/ui/VEmbedded.java index 5f4e801a44..54f3fdcf4e 100644 --- a/client/src/main/java/com/vaadin/client/ui/VEmbedded.java +++ b/client/src/main/java/com/vaadin/client/ui/VEmbedded.java @@ -138,7 +138,7 @@ public class VEmbedded extends HTML { } // End object tag - html.append(">"); + html.append('>'); // Ensure we have an movie parameter Map parameters = state.parameters; @@ -166,7 +166,7 @@ public class VEmbedded extends HTML { // Add the parameters to the Embed for (String name : parameters.keySet()) { html.append(WidgetUtil.escapeAttribute(name)); - html.append("="); + html.append('='); html.append("\"" + WidgetUtil.escapeAttribute(parameters.get(name)) + "\""); } diff --git a/client/src/main/java/com/vaadin/client/ui/VFlash.java b/client/src/main/java/com/vaadin/client/ui/VFlash.java index 6c45cf52ac..40f089428d 100644 --- a/client/src/main/java/com/vaadin/client/ui/VFlash.java +++ b/client/src/main/java/com/vaadin/client/ui/VFlash.java @@ -225,7 +225,7 @@ public class VFlash extends HTML { } // End object tag - html.append(">"); + html.append('>'); // Ensure we have an movie parameter if (embedParams.get("movie") == null) { @@ -263,7 +263,7 @@ public class VFlash extends HTML { // Add the parameters to the Embed for (String name : embedParams.keySet()) { html.append(WidgetUtil.escapeAttribute(name)); - html.append("="); + html.append('='); html.append("\"" + WidgetUtil.escapeAttribute(embedParams.get(name)) + "\""); } diff --git a/client/src/main/java/com/vaadin/client/ui/popupview/PopupViewConnector.java b/client/src/main/java/com/vaadin/client/ui/popupview/PopupViewConnector.java index f0b42f76d9..5e4fdb4d7d 100644 --- a/client/src/main/java/com/vaadin/client/ui/popupview/PopupViewConnector.java +++ b/client/src/main/java/com/vaadin/client/ui/popupview/PopupViewConnector.java @@ -111,17 +111,17 @@ public class PopupViewConnector extends AbstractHasComponentsConnector .contains(VOverlay.ADDITIONAL_CLASSNAME_ANIMATE_IN); if (isAnimatingIn) { - styleBuf.append(" "); + styleBuf.append(' '); styleBuf.append(primaryName); - styleBuf.append("-"); + styleBuf.append('-'); styleBuf.append(VOverlay.ADDITIONAL_CLASSNAME_ANIMATE_IN); } if (ComponentStateUtil.hasStyles(getState())) { for (String style : getState().styles) { - styleBuf.append(" "); + styleBuf.append(' '); styleBuf.append(primaryName); - styleBuf.append("-"); + styleBuf.append('-'); styleBuf.append(style); } } -- cgit v1.2.3