From 0b627f975ddae79d4d9d1cf4b12e6c31eb31eb7a Mon Sep 17 00:00:00 2001 From: Anna Koskinen Date: Mon, 4 Nov 2019 13:26:32 +0200 Subject: Check actual Grid selection instead of relying on allSelected flag. (#11787) The checkbox for selecting all rows only selects all the rows that have not been filtered out. Changing the filtering does not change the selection or the checkbox state so assuming that all rows are selected simply because the checkbox has been checked cannot work. Fixes #11479 --- .../com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'client') diff --git a/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java b/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java index 7bbc66d271..de003e6daf 100644 --- a/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java +++ b/client/src/main/java/com/vaadin/client/connectors/grid/MultiSelectionModelConnector.java @@ -250,7 +250,7 @@ public class MultiSelectionModelConnector @Override protected boolean isSelected(JsonObject item) { - return getState().allSelected || super.isSelected(item); + return super.isSelected(item); } /** -- cgit v1.2.3