From 1408272f7736ca1ac0e2114da9221543cb9e2a82 Mon Sep 17 00:00:00 2001 From: Teemu Suo-Anttila Date: Tue, 12 Jan 2016 17:29:44 +0200 Subject: Add clarifying comment to CustomDetailsGenerator Change-Id: I9e6668b1fbc0a956bf34b48b75df59279005d097 --- client/src/com/vaadin/client/connectors/GridConnector.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'client') diff --git a/client/src/com/vaadin/client/connectors/GridConnector.java b/client/src/com/vaadin/client/connectors/GridConnector.java index c6075d3bd4..90d9d71088 100644 --- a/client/src/com/vaadin/client/connectors/GridConnector.java +++ b/client/src/com/vaadin/client/connectors/GridConnector.java @@ -56,9 +56,9 @@ import com.vaadin.client.widget.grid.CellReference; import com.vaadin.client.widget.grid.CellStyleGenerator; import com.vaadin.client.widget.grid.EditorHandler; import com.vaadin.client.widget.grid.EventCellReference; +import com.vaadin.client.widget.grid.HeightAwareDetailsGenerator; import com.vaadin.client.widget.grid.RowReference; import com.vaadin.client.widget.grid.RowStyleGenerator; -import com.vaadin.client.widget.grid.HeightAwareDetailsGenerator; import com.vaadin.client.widget.grid.events.BodyClickHandler; import com.vaadin.client.widget.grid.events.BodyDoubleClickHandler; import com.vaadin.client.widget.grid.events.ColumnReorderEvent; @@ -508,6 +508,8 @@ public class GridConnector extends AbstractHasComponentsConnector implements @Override public double getDetailsHeight(int rowIndex) { + // Case of null is handled in the getDetails method and this method + // will not called if it returns null. String id = getId(rowIndex); ComponentConnector componentConnector = idToDetailsMap.get(id); -- cgit v1.2.3