From 92c20d47b0ab867e3819ad2a0baeb7238c18f565 Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Sat, 16 Jan 2016 13:02:45 +0200 Subject: Do not process click events for disabled optiongroups (#19433) This removes the warning logged on the server side when the RPC reaches it for the disabled component. As this is more of a cosmetic change, there is no automatic test. Change-Id: I8bfa83bd0a26c585e1614d821ac3b598294db09d --- client/src/com/vaadin/client/ui/VOptionGroup.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'client') diff --git a/client/src/com/vaadin/client/ui/VOptionGroup.java b/client/src/com/vaadin/client/ui/VOptionGroup.java index d429752069..9a28111dc5 100644 --- a/client/src/com/vaadin/client/ui/VOptionGroup.java +++ b/client/src/com/vaadin/client/ui/VOptionGroup.java @@ -207,7 +207,11 @@ public class VOptionGroup extends VOptionGroupBase implements FocusHandler, super.onClick(event); if (event.getSource() instanceof CheckBox) { CheckBox source = (CheckBox) event.getSource(); - + if (!source.isEnabled()) { + // Click events on the text are received even though the + // checkbox is disabled + return; + } if (BrowserInfo.get().isWebkit()) { // Webkit does not focus non-text input elements on click // (#11854) -- cgit v1.2.3