From b49b8c2fc5112c21aaf4d3562bdbfa8eb3fee9a9 Mon Sep 17 00:00:00 2001
From: Teemu Suo-Anttila <teemusa@vaadin.com>
Date: Fri, 7 Oct 2016 11:37:42 +0300
Subject: Use identifiers for Grid Columns

Change-Id: Id229e533fc4ff58bdd2ce3862481f72210ed9e89
---
 .../client/connectors/grid/ColumnConnector.java    | 24 ++++++++++++++++------
 .../client/connectors/grid/GridConnector.java      | 19 +++++++++--------
 2 files changed, 28 insertions(+), 15 deletions(-)

(limited to 'client')

diff --git a/client/src/main/java/com/vaadin/client/connectors/grid/ColumnConnector.java b/client/src/main/java/com/vaadin/client/connectors/grid/ColumnConnector.java
index cc3dff651d..c3aa4fe5d2 100644
--- a/client/src/main/java/com/vaadin/client/connectors/grid/ColumnConnector.java
+++ b/client/src/main/java/com/vaadin/client/connectors/grid/ColumnConnector.java
@@ -36,7 +36,20 @@ import elemental.json.JsonValue;
 @Connect(com.vaadin.ui.Grid.Column.class)
 public class ColumnConnector extends AbstractExtensionConnector {
 
-    private Column<Object, JsonObject> column;
+    static abstract class CustomColumn extends Column<Object, JsonObject> {
+
+        private final String connectorId;
+
+        CustomColumn(String connectorId) {
+            this.connectorId = connectorId;
+        }
+
+        public String getConnectorId() {
+            return connectorId;
+        }
+    }
+
+    private CustomColumn column;
 
     /* This parent is needed because it's no longer available in onUnregister */
     private GridConnector parent;
@@ -44,16 +57,15 @@ public class ColumnConnector extends AbstractExtensionConnector {
     @Override
     protected void extend(ServerConnector target) {
         parent = getParent();
-        String columnId = getState().id;
-        column = new Column<Object, JsonObject>() {
+        column = new CustomColumn(getConnectorId()) {
 
             @Override
             public Object getValue(JsonObject row) {
                 final JsonObject rowData = row
                         .getObject(DataCommunicatorConstants.DATA);
 
-                if (rowData.hasKey(columnId)) {
-                    final JsonValue columnValue = rowData.get(columnId);
+                if (rowData.hasKey(getConnectorId())) {
+                    final JsonValue columnValue = rowData.get(getConnectorId());
 
                     return getRendererConnector().decode(columnValue);
                 }
@@ -62,7 +74,7 @@ public class ColumnConnector extends AbstractExtensionConnector {
             }
         };
         column.setRenderer(getRendererConnector().getRenderer());
-        getParent().addColumn(column, columnId);
+        getParent().addColumn(column, getState().id);
     }
 
     @SuppressWarnings("unchecked")
diff --git a/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java b/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java
index 02909e1fc3..4686b3bd21 100644
--- a/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java
+++ b/client/src/main/java/com/vaadin/client/connectors/grid/GridConnector.java
@@ -38,6 +38,7 @@ import com.vaadin.client.TooltipInfo;
 import com.vaadin.client.WidgetUtil;
 import com.vaadin.client.annotations.OnStateChange;
 import com.vaadin.client.connectors.AbstractListingConnector;
+import com.vaadin.client.connectors.grid.ColumnConnector.CustomColumn;
 import com.vaadin.client.data.DataSource;
 import com.vaadin.client.ui.SimpleManagedLayout;
 import com.vaadin.client.widget.grid.CellReference;
@@ -107,8 +108,8 @@ public class GridConnector
     }
 
     /* Map to keep track of all added columns */
-    private Map<Column<?, JsonObject>, String> columnToIdMap = new HashMap<>();
-    private Map<String, Column<?, JsonObject>> idToColumn = new HashMap<>();
+    private Map<CustomColumn, String> columnToIdMap = new HashMap<>();
+    private Map<String, CustomColumn> idToColumn = new HashMap<>();
 
     /* Child component list for HasComponentsConnector */
     private List<ComponentConnector> childComponents;
@@ -134,7 +135,7 @@ public class GridConnector
      *            the id of the column to get
      * @return the column with the given id
      */
-    public Column<?, JsonObject> getColumn(String columnId) {
+    public CustomColumn getColumn(String columnId) {
         return idToColumn.get(columnId);
     }
 
@@ -164,8 +165,8 @@ public class GridConnector
             }
 
             Column<?, JsonObject> column = cellRef.getColumn();
-            if (columnToIdMap.containsKey(column)) {
-                String id = columnToIdMap.get(column);
+            if (column instanceof CustomColumn) {
+                String id = ((CustomColumn) column).getConnectorId();
                 JsonObject cellStyles = row
                         .getObject(GridState.JSONKEY_CELLSTYLES);
                 if (cellStyles.hasKey(id)) {
@@ -284,7 +285,7 @@ public class GridConnector
      * @param id
      *            communication id
      */
-    public void addColumn(Column<?, JsonObject> column, String id) {
+    public void addColumn(CustomColumn column, String id) {
         assert !columnToIdMap.containsKey(column) && !columnToIdMap
                 .containsValue(id) : "Column with given id already exists.";
         getWidget().addColumn(column);
@@ -299,7 +300,7 @@ public class GridConnector
      * @param column
      *            column to remove
      */
-    public void removeColumn(Column<?, JsonObject> column) {
+    public void removeColumn(CustomColumn column) {
         assert columnToIdMap
                 .containsKey(column) : "Given Column does not exist.";
         getWidget().removeColumn(column);
@@ -407,11 +408,11 @@ public class GridConnector
                     || row.hasKey(GridState.JSONKEY_CELLDESCRIPTION))) {
 
                 Column<?, JsonObject> column = cell.getColumn();
-                if (columnToIdMap.containsKey(column)) {
+                if (column instanceof CustomColumn) {
                     JsonObject cellDescriptions = row
                             .getObject(GridState.JSONKEY_CELLDESCRIPTION);
 
-                    String id = columnToIdMap.get(column);
+                    String id = ((CustomColumn) column).getConnectorId();
                     if (cellDescriptions != null
                             && cellDescriptions.hasKey(id)) {
                         return new TooltipInfo(cellDescriptions.getString(id));
-- 
cgit v1.2.3