From 7b1e48f4698971179d773ee6d9ae413ac8dccce1 Mon Sep 17 00:00:00 2001 From: Knoobie Date: Thu, 11 May 2017 08:04:43 +0200 Subject: Make clicking checkbox label call focus listeners (#9271) Fixes the remaining issue from #3944 for Firefox so that a click on the checkbox label calls the focus listener. Fixes #9290 --- .../src/main/java/com/vaadin/v7/client/ui/VCheckBox.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'compatibility-client/src') diff --git a/compatibility-client/src/main/java/com/vaadin/v7/client/ui/VCheckBox.java b/compatibility-client/src/main/java/com/vaadin/v7/client/ui/VCheckBox.java index 60a0d06821..37308001a1 100644 --- a/compatibility-client/src/main/java/com/vaadin/v7/client/ui/VCheckBox.java +++ b/compatibility-client/src/main/java/com/vaadin/v7/client/ui/VCheckBox.java @@ -60,9 +60,9 @@ public class VCheckBox extends com.google.gwt.user.client.ui.CheckBox el = DOM.getNextSibling(el); } - if (BrowserInfo.get().isWebkit()) { - // Webkit does not focus non-text input elements on click - // (#11854) + if (BrowserInfo.get().isWebkit() || BrowserInfo.get().isFirefox()) { + // Webkit and Firefox do not focus non-text input elements on click + // (#3944) addClickHandler(new ClickHandler() { @Override public void onClick(ClickEvent event) { -- cgit v1.2.3