From 252ef116342a6b0363b48d157de33a932d44752f Mon Sep 17 00:00:00 2001 From: Tatu Lund Date: Mon, 2 Dec 2019 11:08:01 +0200 Subject: Make asRequired conditional on binding.setAsRequiredEnabled(..) (#11834) It is a very common use case in complex form that whether a field is required or not, it depends on input on other fields. Hypothetical use case sample could be that we have form for a Product and price of the product is needed except in case the Product's type is Sample. So in that kind of scenarios it would be needed to turn off asRequired() validation easily. The purpose of this enhancement and new binding.setAsRequiredEnabled(..) API is to help implementation of this kind of use cases more easily. https://github.com/vaadin/framework/issues/10709 --- server/src/test/java/com/vaadin/data/BinderTest.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'server/src/test/java') diff --git a/server/src/test/java/com/vaadin/data/BinderTest.java b/server/src/test/java/com/vaadin/data/BinderTest.java index 401cc07017..b3fe5a8194 100644 --- a/server/src/test/java/com/vaadin/data/BinderTest.java +++ b/server/src/test/java/com/vaadin/data/BinderTest.java @@ -473,13 +473,13 @@ public class BinderTest extends BinderTestBase, Person> { TextField textField = new TextField(); assertFalse(textField.isRequiredIndicatorVisible()); - BindingBuilder binding = binder.forField(textField); + BindingBuilder bindingBuilder = binder.forField(textField); assertFalse(textField.isRequiredIndicatorVisible()); - binding.asRequired("foobar"); + bindingBuilder.asRequired("foobar"); assertTrue(textField.isRequiredIndicatorVisible()); - binding.bind(Person::getFirstName, Person::setFirstName); + Binding binding = bindingBuilder.bind(Person::getFirstName, Person::setFirstName); binder.setBean(item); assertNull(textField.getErrorMessage()); @@ -491,6 +491,9 @@ public class BinderTest extends BinderTestBase, Person> { textField.setValue("value"); assertNull(textField.getErrorMessage()); assertTrue(textField.isRequiredIndicatorVisible()); + + binding.setAsRequiredEnabled(false); + assertFalse(textField.isRequiredIndicatorVisible()); } @Test -- cgit v1.2.3