From b2e3aa2acf99e98dc3e5ac3c96ec829fe3896c47 Mon Sep 17 00:00:00 2001 From: Leif Åstrand Date: Wed, 14 Dec 2016 14:32:07 +0200 Subject: Rename setRequired to asRequired since it's logically not a setter (#7986) --- server/src/test/java/com/vaadin/data/BinderTest.java | 4 ++-- .../test/java/com/vaadin/data/validator/NotEmptyValidator.java | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) (limited to 'server/src/test/java') diff --git a/server/src/test/java/com/vaadin/data/BinderTest.java b/server/src/test/java/com/vaadin/data/BinderTest.java index 397676c062..b0d16bd9e7 100644 --- a/server/src/test/java/com/vaadin/data/BinderTest.java +++ b/server/src/test/java/com/vaadin/data/BinderTest.java @@ -334,7 +334,7 @@ public class BinderTest extends BinderTestBase, Person> { BindingBuilder binding = binder.forField(textField); Assert.assertFalse(textField.isRequiredIndicatorVisible()); - binding.setRequired("foobar"); + binding.asRequired("foobar"); Assert.assertTrue(textField.isRequiredIndicatorVisible()); binding.bind(Person::getFirstName, Person::setFirstName); @@ -361,7 +361,7 @@ public class BinderTest extends BinderTestBase, Person> { Assert.assertFalse(textField.isRequiredIndicatorVisible()); AtomicInteger invokes = new AtomicInteger(); - binding.setRequired(context -> { + binding.asRequired(context -> { invokes.incrementAndGet(); Assert.assertSame(Locale.CANADA, context.getLocale().get()); return "foobar"; diff --git a/server/src/test/java/com/vaadin/data/validator/NotEmptyValidator.java b/server/src/test/java/com/vaadin/data/validator/NotEmptyValidator.java index 3a358b7097..faa37367b0 100644 --- a/server/src/test/java/com/vaadin/data/validator/NotEmptyValidator.java +++ b/server/src/test/java/com/vaadin/data/validator/NotEmptyValidator.java @@ -33,13 +33,14 @@ import com.vaadin.data.util.converter.ValueContext; * This validator can be suitable for fields that have been marked as required * with {@link HasValue#setRequiredIndicatorVisible(boolean)}. *

- * Note that {@link BindingBuilder#setRequired(com.vaadin.data.ErrorMessageProvider)} - * does almost the same thing, but verifies against the value NOT being equal to - * what {@link HasValue#getEmptyValue()} returns and sets the required indicator + * Note that + * {@link BindingBuilder#asRequired(com.vaadin.data.ErrorMessageProvider)} does + * almost the same thing, but verifies against the value NOT being equal to what + * {@link HasValue#getEmptyValue()} returns and sets the required indicator * visible with {@link HasValue#setRequiredIndicatorVisible(boolean)}. * * @see HasValue#setRequiredIndicatorVisible(boolean) - * @see BindingBuilder#setRequired(com.vaadin.data.ErrorMessageProvider) + * @see BindingBuilder#asRequired(com.vaadin.data.ErrorMessageProvider) * @author Vaadin Ltd * @since 8.0 * -- cgit v1.2.3