From 91590e9f6c91de1fcfd9534263a2e270d973d384 Mon Sep 17 00:00:00 2001 From: Teemu Suo-Anttila Date: Tue, 28 Mar 2017 10:07:00 +0300 Subject: Fix data not being sent again when adding DataGenerators (#8947) * Fix data not being sent again when adding DataGenerators * Fix header component detaching, revert early header cleanup --- server/src/main/java/com/vaadin/data/provider/DataCommunicator.java | 3 +++ server/src/main/java/com/vaadin/ui/components/grid/StaticSection.java | 1 + 2 files changed, 4 insertions(+) (limited to 'server/src') diff --git a/server/src/main/java/com/vaadin/data/provider/DataCommunicator.java b/server/src/main/java/com/vaadin/data/provider/DataCommunicator.java index 566c7c732f..ae3c6f4cc1 100644 --- a/server/src/main/java/com/vaadin/data/provider/DataCommunicator.java +++ b/server/src/main/java/com/vaadin/data/provider/DataCommunicator.java @@ -366,6 +366,9 @@ public class DataCommunicator extends AbstractExtension { public void addDataGenerator(DataGenerator generator) { Objects.requireNonNull(generator, "generator cannot be null"); generators.add(generator); + + // Make sure data gets generated when adding data generators. + reset(); } /** diff --git a/server/src/main/java/com/vaadin/ui/components/grid/StaticSection.java b/server/src/main/java/com/vaadin/ui/components/grid/StaticSection.java index dcf27fb357..947be8f522 100644 --- a/server/src/main/java/com/vaadin/ui/components/grid/StaticSection.java +++ b/server/src/main/java/com/vaadin/ui/components/grid/StaticSection.java @@ -158,6 +158,7 @@ public abstract class StaticSection> iterator.remove(); } } + cell.detach(); } } -- cgit v1.2.3