From 9bef3d136c63d3eded2dec1ffdb0af6b69b9c011 Mon Sep 17 00:00:00 2001 From: Per-Åke Minborg Date: Fri, 28 Oct 2016 08:32:15 -0700 Subject: Remove Boolean constructor invocation and add foreach Change-Id: I80b73b653e97904605dc62484a7448f3bfbf7219 --- server/src/main/java/com/vaadin/server/CompositeErrorMessage.java | 4 ++-- .../java/com/vaadin/ui/components/colorpicker/ColorPickerPopup.java | 4 ++-- .../java/com/vaadin/util/ReflectToolsGetFieldValueByTypeTest.java | 2 +- .../java/com/vaadin/util/ReflectToolsGetPrimitiveFieldValueTest.java | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) (limited to 'server/src') diff --git a/server/src/main/java/com/vaadin/server/CompositeErrorMessage.java b/server/src/main/java/com/vaadin/server/CompositeErrorMessage.java index 429694a04f..6e37a94c5e 100644 --- a/server/src/main/java/com/vaadin/server/CompositeErrorMessage.java +++ b/server/src/main/java/com/vaadin/server/CompositeErrorMessage.java @@ -39,8 +39,8 @@ public class CompositeErrorMessage extends AbstractErrorMessage { super(null); setErrorLevel(ErrorLevel.INFORMATION); - for (int i = 0; i < errorMessages.length; i++) { - addErrorMessage(errorMessages[i]); + for (ErrorMessage errorMessage : errorMessages) { + addErrorMessage(errorMessage); } if (getCauses().size() == 0) { diff --git a/server/src/main/java/com/vaadin/ui/components/colorpicker/ColorPickerPopup.java b/server/src/main/java/com/vaadin/ui/components/colorpicker/ColorPickerPopup.java index c86b139520..521a131c4c 100644 --- a/server/src/main/java/com/vaadin/ui/components/colorpicker/ColorPickerPopup.java +++ b/server/src/main/java/com/vaadin/ui/components/colorpicker/ColorPickerPopup.java @@ -218,7 +218,7 @@ public class ColorPickerPopup extends Window implements HasValue { // Add the resize button for the history resize.addClickListener(this::resizeButtonClick); - resize.setData(new Boolean(false)); + resize.setData(false); resize.setWidth("100%"); resize.setHeight("10px"); resize.setPrimaryStyleName("resize-button"); @@ -437,7 +437,7 @@ public class ColorPickerPopup extends Window implements HasValue { history.setHeight("85px"); } - resize.setData(new Boolean(!minimize)); + resize.setData(!minimize); } private void okButtonClick(ClickEvent event) { diff --git a/server/src/test/java/com/vaadin/util/ReflectToolsGetFieldValueByTypeTest.java b/server/src/test/java/com/vaadin/util/ReflectToolsGetFieldValueByTypeTest.java index 7d15bcfc68..8972bbb66f 100644 --- a/server/src/test/java/com/vaadin/util/ReflectToolsGetFieldValueByTypeTest.java +++ b/server/src/test/java/com/vaadin/util/ReflectToolsGetFieldValueByTypeTest.java @@ -24,7 +24,7 @@ public class ReflectToolsGetFieldValueByTypeTest { MySubClass myInstance = new MySubClass(); java.lang.reflect.Field memberField; - Object fieldValue = new Boolean(false); + Object fieldValue = false; try { memberField = myInstance.getClass().getField("field"); // Should get a String value. Without the third parameter (calling diff --git a/server/src/test/java/com/vaadin/util/ReflectToolsGetPrimitiveFieldValueTest.java b/server/src/test/java/com/vaadin/util/ReflectToolsGetPrimitiveFieldValueTest.java index d6362395da..167ab774f2 100644 --- a/server/src/test/java/com/vaadin/util/ReflectToolsGetPrimitiveFieldValueTest.java +++ b/server/src/test/java/com/vaadin/util/ReflectToolsGetPrimitiveFieldValueTest.java @@ -14,7 +14,7 @@ public class ReflectToolsGetPrimitiveFieldValueTest { MyClass myInstance = new MyClass(); java.lang.reflect.Field memberField; - Object fieldValue = new Boolean(false); + Object fieldValue = false; try { memberField = myInstance.getClass().getField("field"); fieldValue = ReflectTools.getJavaFieldValue(myInstance, -- cgit v1.2.3