From 3929d0ac6f8e3d7370412d1d181db1b2361d13e3 Mon Sep 17 00:00:00 2001 From: Ahmed Ashour Date: Fri, 20 Oct 2017 10:54:25 +0200 Subject: AbstractDateField.formatDate() to be abstract (#10186) * AbstractDateField.formatDate to be abstract Remove invalidDateString paramter, as it can be deduced * Fix test * Remove AbstractDateField.getResolutionVariable VAbstractTextualDate: rename updateDateVariables() to updateBufferedResolutions() * Revert to use fixed value of MONDAY. * release notes * updateAndSendBufferedValues() * Missed call to updateAndSendBufferedValues(); * release note --- .../shared/ui/datefield/AbstractDateFieldServerRpc.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'shared/src') diff --git a/shared/src/main/java/com/vaadin/shared/ui/datefield/AbstractDateFieldServerRpc.java b/shared/src/main/java/com/vaadin/shared/ui/datefield/AbstractDateFieldServerRpc.java index 2ef8993fb6..cdd8e30815 100644 --- a/shared/src/main/java/com/vaadin/shared/ui/datefield/AbstractDateFieldServerRpc.java +++ b/shared/src/main/java/com/vaadin/shared/ui/datefield/AbstractDateFieldServerRpc.java @@ -33,15 +33,13 @@ public interface AbstractDateFieldServerRpc extends ServerRpc { * the value of the text field part. It enables analyzing invalid * input on the server. {@code null} if the date was chosen with * popup calendar or contains user-typed string - * @param invalidDateString - * Whether the last date string is invalid or not * @param resolutions - * map of time unit (resolution) name and value, name is the - * lower-case resolution name e.g. "hour", "minute", and value - * can be {@code null} + * map of time unit (resolution) name and value, the key is the + * resolution name e.g. "HOUR", "MINUTE", the value can be + * {@code null}. If the map is empty, that means the + * {@code newDateString} is invalid */ - void update(String newDateString, boolean invalidDateString, - Map resolutions); + void update(String newDateString, Map resolutions); /** * Indicates to the server that the client-side has lost focus. -- cgit v1.2.3