From 925ea628e656de350abca5c9da06092a80c563bf Mon Sep 17 00:00:00 2001
From: Teemu Suo-Anttila <teemusa@vaadin.com>
Date: Mon, 20 Jul 2015 09:21:39 +0300
Subject: Fix DetailsRow communication use connector IDs (#18493)

Details are now initialized when they are made visible. The old way of
requesting when seen caused a lot of problems when moving stuff around.
Now uses less communication, but reserves a bit extra resources due to
all details components being in the hierarchy.

Change-Id: If94e8df76254816aeb2fd681624fc82e7718cbb8
---
 shared/src/com/vaadin/shared/ui/grid/GridClientRpc.java | 17 -----------------
 shared/src/com/vaadin/shared/ui/grid/GridServerRpc.java | 17 -----------------
 2 files changed, 34 deletions(-)

(limited to 'shared')

diff --git a/shared/src/com/vaadin/shared/ui/grid/GridClientRpc.java b/shared/src/com/vaadin/shared/ui/grid/GridClientRpc.java
index 3c6d993482..ac1b1d5a78 100644
--- a/shared/src/com/vaadin/shared/ui/grid/GridClientRpc.java
+++ b/shared/src/com/vaadin/shared/ui/grid/GridClientRpc.java
@@ -15,8 +15,6 @@
  */
 package com.vaadin.shared.ui.grid;
 
-import java.util.Set;
-
 import com.vaadin.shared.communication.ClientRpc;
 
 /**
@@ -57,19 +55,4 @@ public interface GridClientRpc extends ClientRpc {
      * Command client Grid to recalculate column widths.
      */
     public void recalculateColumnWidths();
-
-    /**
-     * Informs the GridConnector on how the indexing of details connectors has
-     * changed.
-     * 
-     * @since 7.5.0
-     * @param connectorChanges
-     *            the indexing changes of details connectors
-     * @param fetchId
-     *            the id of the request for fetching the changes. A negative
-     *            number indicates a push (not requested by the client side)
-     */
-    public void setDetailsConnectorChanges(
-            Set<DetailsConnectorChange> connectorChanges, int fetchId);
-
 }
diff --git a/shared/src/com/vaadin/shared/ui/grid/GridServerRpc.java b/shared/src/com/vaadin/shared/ui/grid/GridServerRpc.java
index dca55c11c4..5c91f2b746 100644
--- a/shared/src/com/vaadin/shared/ui/grid/GridServerRpc.java
+++ b/shared/src/com/vaadin/shared/ui/grid/GridServerRpc.java
@@ -60,23 +60,6 @@ public interface GridServerRpc extends ServerRpc {
     void columnsReordered(List<String> newColumnOrder,
             List<String> oldColumnOrder);
 
-    /**
-     * This is a trigger for Grid to send whatever has changed regarding the
-     * details components.
-     * <p>
-     * The components can't be sent eagerly, since they are generated as a side
-     * effect in
-     * {@link com.vaadin.data.RpcDataProviderExtension#beforeClientResponse(boolean)}
-     * , and that is too late to change the hierarchy. So we need this
-     * round-trip to work around that limitation.
-     * 
-     * @since 7.5.0
-     * @param fetchId
-     *            an unique identifier for the request
-     * @see com.vaadin.ui.Grid#setDetailsVisible(Object, boolean)
-     */
-    void sendDetailsComponents(int fetchId);
-
     /**
      * Informs the server that the column's visibility has been changed.
      * 
-- 
cgit v1.2.3