From f299c7a31b00d614c1f248d97a54796ce385fcf2 Mon Sep 17 00:00:00 2001 From: Aleksi Hietanen Date: Tue, 21 Nov 2017 14:25:42 +0200 Subject: Fix issues from API review for 8.2 (#10342) * Rename HierarchicalDataCommunicator#getMapper to getHierarchyMapper * Make rpc field in Notification private * Change DropIndexCalculator.ALWAYS_DROP_TO_END to a generic static method * Move EditorImpl#editRow documentation to the interface level * Correct GridDragEndEvent, GridDragStartEvent constructor javadocs * Revert SharedState.registeredEventListeners to a Set * Rename GridDropTarget dropAllowedOnSortedGridRows * Rename ColumnState.contentMode to tooltipContentMode --- .../main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java | 4 ++-- .../java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'uitest/src') diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java b/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java index b68866c727..9130914baa 100644 --- a/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java +++ b/uitest/src/main/java/com/vaadin/tests/components/grid/AbstractGridDnD.java @@ -66,9 +66,9 @@ public abstract class AbstractGridDnD extends AbstractTestUIWithLog { } }); CheckBox dropOnSortedGridRows = new CheckBox("Drop on Sorted Grid Rows", - dropTarget.isDropAllowedOnSortedGridRows()); + dropTarget.isDropAllowedOnRowsWhenSorted()); dropOnSortedGridRows.addValueChangeListener(event -> { - dropTarget.setDropAllowedOnSortedGridRows(event.getValue()); + dropTarget.setDropAllowedOnRowsWhenSorted(event.getValue()); }); RadioButtonGroup frozenColumnSelect = new RadioButtonGroup<>( diff --git a/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java b/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java index b0c630a3a8..70d3d12277 100644 --- a/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java +++ b/uitest/src/main/java/com/vaadin/tests/components/grid/GridRowDraggerTwoGrids.java @@ -44,7 +44,7 @@ public class GridRowDraggerTwoGrids extends AbstractGridDnD { CheckBox addItemsToEnd = new CheckBox("Add Items To End", false); addItemsToEnd.addValueChangeListener( event -> gridDragger.setDropIndexCalculator(event.getValue() - ? DropIndexCalculator.ALWAYS_DROP_TO_END : null)); + ? DropIndexCalculator.alwaysDropToEnd() : null)); CheckBox removeItemsFromSource = new CheckBox( "Remove items from source grid", true); removeItemsFromSource.addValueChangeListener(event -> gridDragger -- cgit v1.2.3