From 7d9f544d584edb90b1c9231987e356dfaf0b7b35 Mon Sep 17 00:00:00 2001 From: Henri Sara Date: Mon, 29 Apr 2013 13:44:18 +0300 Subject: Test for #11396 (merged from 6.8 branch). Depends on a blur event so cannot be autotested with TB. svn changeset:25882/svn branch:6.8 Change-Id: I2db788e60397162a29f7802f772609e65a832d3f --- .../components/textarea/TextDisappearsOnBlur.java | 29 ++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 uitest/src/com/vaadin/tests/components/textarea/TextDisappearsOnBlur.java (limited to 'uitest') diff --git a/uitest/src/com/vaadin/tests/components/textarea/TextDisappearsOnBlur.java b/uitest/src/com/vaadin/tests/components/textarea/TextDisappearsOnBlur.java new file mode 100644 index 0000000000..2d2cf29e9e --- /dev/null +++ b/uitest/src/com/vaadin/tests/components/textarea/TextDisappearsOnBlur.java @@ -0,0 +1,29 @@ +package com.vaadin.tests.components.textarea; + +import com.vaadin.tests.components.TestBase; +import com.vaadin.ui.TextArea; + +public class TextDisappearsOnBlur extends TestBase { + + @Override + protected void setup() { + TextArea ta = new TextArea(); + addComponent(ta); + + // All three are required for the bug to manifest + ta.setMaxLength(50); + ta.setImmediate(true); + ta.setRequired(true); + } + + @Override + protected String getDescription() { + return "Text disappears from TextArea in IE 6-8 when focus changes"; + } + + @Override + protected Integer getTicketNumber() { + return 11396; + } + +} -- cgit v1.2.3 From 1b188073c46c5c21bb8ddeb21674452c9bc414fd Mon Sep 17 00:00:00 2001 From: Marc Englund Date: Wed, 8 May 2013 09:31:09 +0300 Subject: Remove pre-loader element after pre-loading, fixes #10863 Change-Id: Ibd2009315aadb25e574c82f3b4b54c501d9b1395 Ticket: 10863 --- client/src/com/vaadin/client/ResourceLoader.java | 18 +++- .../vaadin/launcher/DevelopmentServerLauncher.java | 109 +++++++++++++++++++++ 2 files changed, 123 insertions(+), 4 deletions(-) (limited to 'uitest') diff --git a/client/src/com/vaadin/client/ResourceLoader.java b/client/src/com/vaadin/client/ResourceLoader.java index b3b9ac7256..7fc8b4f9f3 100644 --- a/client/src/com/vaadin/client/ResourceLoader.java +++ b/client/src/com/vaadin/client/ResourceLoader.java @@ -50,8 +50,8 @@ public class ResourceLoader { * Event fired when a resource has been loaded. */ public static class ResourceLoadEvent { - private ResourceLoader loader; - private String resourceUrl; + private final ResourceLoader loader; + private final String resourceUrl; private final boolean preload; /** @@ -286,25 +286,35 @@ public class ResourceLoader { // Inject loader element if this is the first time this is preloaded // AND the resources isn't already being loaded in the normal way - Element element = getPreloadElement(url); + final Element element = getPreloadElement(url); addOnloadHandler(element, new ResourceLoadListener() { @Override public void onLoad(ResourceLoadEvent event) { fireLoad(event); + Document.get().getBody().removeChild(element); } @Override public void onError(ResourceLoadEvent event) { fireError(event); + Document.get().getBody().removeChild(element); } }, event); - // TODO Remove object when loaded (without causing spinner in FF) Document.get().getBody().appendChild(element); } } private static Element getPreloadElement(String url) { + /*- + * TODO + * In Chrome, FF: + * does not fire event if resource is 404 -> eternal spinner. + * always fires onerror -> no way to know if it loaded -> eternal spinner + *