From 5df70b4594691f2048bd329daed8998f36b3a141 Mon Sep 17 00:00:00 2001 From: Anna Koskinen Date: Tue, 6 Feb 2018 16:51:25 +0200 Subject: Fix GridLayout spacing if first row/column empty and set to be hidden (#10593) --- .../tests/components/gridlayout/GridLayoutExtraSpacingTest.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'uitest') diff --git a/uitest/src/test/java/com/vaadin/tests/components/gridlayout/GridLayoutExtraSpacingTest.java b/uitest/src/test/java/com/vaadin/tests/components/gridlayout/GridLayoutExtraSpacingTest.java index 15b4f9c507..22cbddd4c4 100644 --- a/uitest/src/test/java/com/vaadin/tests/components/gridlayout/GridLayoutExtraSpacingTest.java +++ b/uitest/src/test/java/com/vaadin/tests/components/gridlayout/GridLayoutExtraSpacingTest.java @@ -49,6 +49,7 @@ public class GridLayoutExtraSpacingTest extends MultiBrowserTest { // Spacing off, not hiding empty rows/columns // There should not be any spacing (red) above the csslayout verifySpacingAbove(0, gridLayout, component); + verifySpacingBelow(0, gridLayout, component); CheckBoxElement hideRowsColumnsCheckbox = $(CheckBoxElement.class) .caption("hide empty rows/columns").first(); @@ -57,16 +58,14 @@ public class GridLayoutExtraSpacingTest extends MultiBrowserTest { // Spacing off, hiding empty rows/columns // There should not be any spacing (red) above the csslayout verifySpacingAbove(0, gridLayout, component); + verifySpacingBelow(0, gridLayout, component); check(spacingCheckbox); // Spacing on, hiding empty rows/columns // There should not be any spacing (red) above or below the csslayout - // Oh PhantomJs... - sleep(100); - // FIXME: This should be 0 but there is a bug somewhere - // verifySpacingAbove(0, gridLayout, component); - verifySpacingBelow(6, gridLayout, component); + verifySpacingAbove(0, gridLayout, component); + verifySpacingBelow(0, gridLayout, component); } -- cgit v1.2.3