aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorAndreas L. Delmelle <adelmelle@apache.org>2011-03-26 23:08:43 +0000
committerAndreas L. Delmelle <adelmelle@apache.org>2011-03-26 23:08:43 +0000
commit8c443ea8862b9a8258829f9c80790151d06fd2b0 (patch)
tree95440ae8646a327d1d64aff5a497f69c049f77c9 /src
parent767b2ba1cc657aa1f974836f6e5f1d5d9558fd18 (diff)
downloadxmlgraphics-fop-8c443ea8862b9a8258829f9c80790151d06fd2b0.tar.gz
xmlgraphics-fop-8c443ea8862b9a8258829f9c80790151d06fd2b0.zip
Fixed regression introduced by Bugzilla 50593: bookmarks pointing to a non-existing internal destination should just trigger a warning.
git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1085824 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'src')
-rw-r--r--src/java/org/apache/fop/area/AreaTreeHandler.java2
-rw-r--r--src/java/org/apache/fop/render/intermediate/IFSerializer.java8
2 files changed, 7 insertions, 3 deletions
diff --git a/src/java/org/apache/fop/area/AreaTreeHandler.java b/src/java/org/apache/fop/area/AreaTreeHandler.java
index 0e2b8bf71..f45245bfe 100644
--- a/src/java/org/apache/fop/area/AreaTreeHandler.java
+++ b/src/java/org/apache/fop/area/AreaTreeHandler.java
@@ -336,7 +336,7 @@ public class AreaTreeHandler extends FOEventHandler {
String[] ids = res.getIDRefs();
for (String id : ids) {
List<PageViewport> pageVPList = idTracker.getPageViewportsContainingID(id);
- if (pageVPList != null) {
+ if (pageVPList != null && !pageVPList.isEmpty()) {
res.resolveIDRef(id, pageVPList);
} else {
AreaEventProducer eventProducer = AreaEventProducer.Provider.get(
diff --git a/src/java/org/apache/fop/render/intermediate/IFSerializer.java b/src/java/org/apache/fop/render/intermediate/IFSerializer.java
index 3e178d3cb..64bae054c 100644
--- a/src/java/org/apache/fop/render/intermediate/IFSerializer.java
+++ b/src/java/org/apache/fop/render/intermediate/IFSerializer.java
@@ -718,14 +718,18 @@ public class IFSerializer extends AbstractXMLWritingIFDocumentHandler
}
private void serializeBookmark(Bookmark bookmark) throws SAXException, IFException {
- noteAction(bookmark.getAction());
+ if (bookmark.getAction() != null) {
+ noteAction(bookmark.getAction());
+ }
AttributesImpl atts = new AttributesImpl();
atts.addAttribute(null, "title", "title", XMLUtil.CDATA, bookmark.getTitle());
atts.addAttribute(null, "starting-state", "starting-state",
XMLUtil.CDATA, bookmark.isShown() ? "show" : "hide");
handler.startElement(DocumentNavigationExtensionConstants.BOOKMARK, atts);
- serializeXMLizable(bookmark.getAction());
+ if (bookmark.getAction() != null) {
+ serializeXMLizable(bookmark.getAction());
+ }
Iterator iter = bookmark.getChildBookmarks().iterator();
while (iter.hasNext()) {
Bookmark b = (Bookmark)iter.next();