From a9531b0195bdc26185baddfba219a0987fe8c912 Mon Sep 17 00:00:00 2001 From: Vincent Hennebert Date: Fri, 8 Feb 2013 20:25:31 +0000 Subject: FOP-2148: make page-position="only" work git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/trunk@1444217 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/fop/layoutmgr/PageBreaker.java | 3 +- .../org/apache/fop/layoutmgr/PageProvider.java | 10 +++ .../fop/layoutmgr/PageSequenceLayoutManager.java | 9 +++ .../page-position_only_elastic.xml | 61 +++++++++++++++++ .../page-position_only_simple.xml | 77 ++++++++++++++++++++++ .../page-position_only_too-small.xml | 58 ++++++++++++++++ 6 files changed, 217 insertions(+), 1 deletion(-) create mode 100644 test/layoutengine/standard-testcases/page-position_only_elastic.xml create mode 100644 test/layoutengine/standard-testcases/page-position_only_simple.xml create mode 100644 test/layoutengine/standard-testcases/page-position_only_too-small.xml diff --git a/src/java/org/apache/fop/layoutmgr/PageBreaker.java b/src/java/org/apache/fop/layoutmgr/PageBreaker.java index 309f4e32f..6a10fa22f 100644 --- a/src/java/org/apache/fop/layoutmgr/PageBreaker.java +++ b/src/java/org/apache/fop/layoutmgr/PageBreaker.java @@ -298,7 +298,8 @@ public class PageBreaker extends AbstractBreaker { return; } - boolean lastPageMasterDefined = pslm.getPageSequence().hasPagePositionLast(); + boolean lastPageMasterDefined = pslm.getPageSequence().hasPagePositionLast() + || pslm.getPageSequence().hasPagePositionOnly() && pslm.isOnFirstPage(partCount - 1); if (!hasMoreContent()) { //last part is reached if (lastPageMasterDefined) { diff --git a/src/java/org/apache/fop/layoutmgr/PageProvider.java b/src/java/org/apache/fop/layoutmgr/PageProvider.java index 8117d547d..1cb6251d9 100644 --- a/src/java/org/apache/fop/layoutmgr/PageProvider.java +++ b/src/java/org/apache/fop/layoutmgr/PageProvider.java @@ -339,4 +339,14 @@ public class PageProvider implements Constants { return page; } + /** + * Indicates whether the column/page at the given index is on the first page of the page sequence. + * + * @return {@code true} if the given part is on the first page of the sequence + */ + boolean isOnFirstPage(int partIndex) { + Column column = getColumn(partIndex); + return startPageOfCurrentElementList + column.pageIndex == startPageOfPageSequence; + } + } diff --git a/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java b/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java index 577f172eb..b5e21aa63 100644 --- a/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java +++ b/src/java/org/apache/fop/layoutmgr/PageSequenceLayoutManager.java @@ -210,4 +210,13 @@ public class PageSequenceLayoutManager extends AbstractPageSequenceLayoutManager return forcedLastPageNum; } + /** + * Indicates whether the column/page at the given index is on the first page of this page sequence. + * + * @return {@code true} if the given part is on the first page of the sequence + */ + boolean isOnFirstPage(int partIndex) { + return pageProvider.isOnFirstPage(partIndex); + } + } diff --git a/test/layoutengine/standard-testcases/page-position_only_elastic.xml b/test/layoutengine/standard-testcases/page-position_only_elastic.xml new file mode 100644 index 000000000..bc6cd3f5b --- /dev/null +++ b/test/layoutengine/standard-testcases/page-position_only_elastic.xml @@ -0,0 +1,61 @@ + + + + + +

There is a possibility to lay out this document on two pages by stretching the elastic + spaces. The best layout though is a one-page layout, and despite the presence of the two-page + possibility, the page-master for page-position="only" must still be chosen.

+
+ + + + + + + + + + + + + + + + + + + + Only page + Only page + Only page + Only page + Only page + + + + + + + + + +
diff --git a/test/layoutengine/standard-testcases/page-position_only_simple.xml b/test/layoutengine/standard-testcases/page-position_only_simple.xml new file mode 100644 index 000000000..2bf3c798f --- /dev/null +++ b/test/layoutengine/standard-testcases/page-position_only_simple.xml @@ -0,0 +1,77 @@ + + + + + +

Basic test for page-position="only".

+
+ + + + + + + + + + + + + + + + + + + + Only page + Only page + Only page + Only page + + + + + + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + Two pages + + + + + + + + + + + + +
diff --git a/test/layoutengine/standard-testcases/page-position_only_too-small.xml b/test/layoutengine/standard-testcases/page-position_only_too-small.xml new file mode 100644 index 000000000..589c3a21f --- /dev/null +++ b/test/layoutengine/standard-testcases/page-position_only_too-small.xml @@ -0,0 +1,58 @@ + + + + + +

When the page-master for page-position="only" cannot accommodate the content, two default + pages must be used instead.

+
+ + + + + + + + + + + + + + + + + + + + Too big for only page + Too big for only page + Too big for only page + + + + + + + + + + +
-- cgit v1.2.3