From f8dd309bf637ecd62762fdfd889be1e7b210b755 Mon Sep 17 00:00:00 2001 From: Vincent Hennebert Date: Fri, 18 Jul 2014 13:49:05 +0000 Subject: Added more complete tests Keep floats for bounds instead of converting them to doubles git-svn-id: https://svn.apache.org/repos/asf/xmlgraphics/fop/branches/FOP-2393_gradient-rendering@1611653 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/fop/render/gradient/Function.java | 6 +++--- .../org/apache/fop/render/gradient/GradientMaker.java | 16 ++++++++-------- 2 files changed, 11 insertions(+), 11 deletions(-) (limited to 'src/java') diff --git a/src/java/org/apache/fop/render/gradient/Function.java b/src/java/org/apache/fop/render/gradient/Function.java index e0dc210d0..38aec8064 100644 --- a/src/java/org/apache/fop/render/gradient/Function.java +++ b/src/java/org/apache/fop/render/gradient/Function.java @@ -143,7 +143,7 @@ public class Function { * This makes each function responsible for an equal amount of the stitching function. * It makes the gradient even. */ - private List bounds; + private List bounds; /** * create an complete Function object of Type 2, an Exponential Interpolation function. @@ -211,7 +211,7 @@ public class Function { * See page 270 in the PDF 1.3 spec. */ public Function(List domain, List range, List functions, - List bounds, List encode) { + List bounds, List encode) { this(3, domain, range); this.functions = functions; this.bounds = bounds; @@ -247,7 +247,7 @@ public class Function { /** * Gets the function bounds */ - public List getBounds() { + public List getBounds() { return bounds; } diff --git a/src/java/org/apache/fop/render/gradient/GradientMaker.java b/src/java/org/apache/fop/render/gradient/GradientMaker.java index d8307c300..4c8734d9f 100644 --- a/src/java/org/apache/fop/render/gradient/GradientMaker.java +++ b/src/java/org/apache/fop/render/gradient/GradientMaker.java @@ -82,7 +82,7 @@ public final class GradientMaker { private static Pattern makeGradient(MultipleGradientPaint gradient, List coords, AffineTransform baseTransform, AffineTransform transform) { List matrix = makeTransform(gradient, baseTransform, transform); - List bounds = makeBounds(gradient); + List bounds = makeBounds(gradient); List functions = makeFunctions(gradient); // Gradients are currently restricted to sRGB PDFDeviceColorSpace colorSpace = new PDFDeviceColorSpace(PDFDeviceColorSpace.DEVICE_RGB); @@ -112,13 +112,12 @@ public final class GradientMaker { return c.getColorSpace().isCS_sRGB() ? c : ColorUtil.toSRGBColor(c); } - private static List makeBounds(MultipleGradientPaint gradient) { - // TODO is the conversion to double necessary? + private static List makeBounds(MultipleGradientPaint gradient) { float[] fractions = gradient.getFractions(); - List bounds = new java.util.ArrayList(fractions.length); + List bounds = new java.util.ArrayList(fractions.length); for (float offset : fractions) { if (0f < offset && offset < 1f) { - bounds.add(Double.valueOf(offset)); + bounds.add(offset); } } return bounds; @@ -156,10 +155,11 @@ public final class GradientMaker { return gradientColors; } - static void outputDoubles(StringBuilder out, DoubleFormatter doubleFormatter, List doubles) { + static void outputDoubles(StringBuilder out, DoubleFormatter doubleFormatter, + List numbers) { out.append("[ "); - for (Double d : doubles) { - out.append(doubleFormatter.formatDouble(d)); + for (Number n : numbers) { + out.append(doubleFormatter.formatDouble(n.doubleValue())); out.append(" "); } out.append("]"); -- cgit v1.2.3