fix: Do not allow border to grow row height (#12254)
* fix: Do not allow border to grow row height
If css grows row height the VSrollTable rowHeight logic does not work allways
Fixes: https://github.com/vaadin/framework/issues/12251
* Compensate change in default row height
* Merge branch '7.7' into fix12251
* Replace calc with round
* Make fix more pin-point
* The first row does not have border thus regular height
* Fix drag-drop styles
* Further fix in drag-and-drop style
* Update TableDropIndicatorValoTest-indicator_ANY_Chrome__indicator.png
- Properly init client-side data in GridDataChangeHandlerTest
- Update Chrome version
- Separate and refactor ComboboxMenuBarAutoopenTest test cases to match
test description
- Update screenshot for ResponsiveStylesTest
- Refactor TextAreaEventPropagationTest to better match expected
behavior
- Add delay to GridDetailsClientTest and EscalatorSpacerTest for
stability
- Add delay and retries to TreeItemDoubleClickTest for stability
Co-authored-by: Teemu Suo-Anttila <teemusa@vaadin.com>
Clear out ClientCache when UI is detached to prevent a minor memory leak (#12200)
Implemented with a listener rather than direct call from UI.detach() in
order to avoid new public API, since the whole feature has been marked
for removal. This doesn't yet prevent the cache or the type map from
getting slightly bloated during the UI's lifetime.
See: #3705
Cherry-picked from: #12199
fix: use time-constant comparison for CSRF tokens (#12190)
This hardens the framework against a theoretical timing attack based on
comparing how quickly a request with an invalid CSRF token is rejected.
Backporting of #12188
fix: use time-constant comparison for security tokens (#12192)
This is the same as #12190, but also applied for the upload security key
and the push id since both of those are also used to protect against
cross-site attacks. In addition, documentation for the push id is
clarified to point out its role.
Backporting of #12189
- Updated Chrome version
- Added leeway to ComboBox popup following along while scrolling
- Added workarounds to timing issues that aren't relevant for the tests
- Added delays for stability
Fix IndexOutOfBoundsException when adding columns in Grid (#12095)
There is regression in Vaadin 7.7.16 and later, which is due patch eafd446726 that can lead to IndexOutOfBoundsException when there is hidden columns while adding new columns, which is similiar issue than earlier reported in https://github.com/vaadin/framework/issues/6784. Essentially the performance improvement patch overwrite some of the fix logic of 8453305743 This fix bring overwriten escalator index compensation back.
* Updated browsers' screenshots
* Update browsers' screenshots
* Update chrome version to 83
Co-authored-by: Anna Koskinen <Ansku@users.noreply.github.com>
Fix incorrect position of column selector in MPR (#11946)
* Change ContextMenu position from absolute to fixed
* Use getBoundingClientRect to get the coordinates of columnSelector in
VScrollTable when the context menu is being opened
* Update TableTooManyColumnsTest screenshot
* Upgrade Chrome version in VerifyBrowserVersionTest
* Update ValoThemeUITest-sliders screenshot
Use APPLICATION_SCOPE for the session lock (#11804)
* Use APPLICATION_SCOPE for the session lock
To be able to do this, relevant methods in VaadinService are made protected so
that VaadinPortletService can override them.
The Vaadin session itself is also stored in APPLICATION_SCOPE. The default
scope is PORTLET_SCOPE, so lock would otherwise not be in sync with
the session.