]> source.dussan.org Git - gitea.git/commit
projects / gitea.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 24ed1b5) | patch
Prevent NPE on commenting on lines with invalidated comments (#12549) (#12550)
authorzeripath <art27@cantab.net>
Fri, 21 Aug 2020 07:52:20 +0000 (08:52 +0100)
committerGitHub <noreply@github.com>
Fri, 21 Aug 2020 07:52:20 +0000 (10:52 +0300)
commit03ba12aabf95ced8398c7859deff76780a4577cd
treeffa081b5aec4e160279f81e2284588201cdee19etree | snapshot
parent24ed1b5feb8c7417f3780e43ef0fe8b0c5517c27commit | diff
Prevent NPE on commenting on lines with invalidated comments (#12549) (#12550)

* Prevent NPE on commenting on lines with invalidated comments

Only check for a review if we are replying to a previous review.

Prevent the NPE in #12239 by assuming that a comment without a Review is
non-pending.

Fix #12239

Signed-off-by: Andrew Thornton <art27@cantab.net>
* Add hack around to show the broken comments

Signed-off-by: Andrew Thornton <art27@cantab.net>
services/pull/review.go diff | blob | history
templates/repo/diff/box.tmpl diff | blob | history
templates/repo/diff/section_unified.tmpl diff | blob | history
templates/repo/issue/view_content/comments.tmpl diff | blob | history
Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD: https://github.com/go-gitea/gitea