- Java 94.6%
- AspectJ 3.7%
- HTML 1.4%
- Shell 0.2%
1df213a520
**Root Cause** The `ClassCastException` occurs in `ClassFile.generateLocalVariableTableAttribute()` where JDT unconditionally casts `MethodBinding.declaringClass` to `SourceTypeBinding`. For synthetic methods generated by `pertypewithin` aspects (and potentially other per-clause variants), AspectJ's `EclipseFactory.makeMethodBinding()` resolves the declaring type via `makeTypeBinding(member.getDeclaringType())`. In a Java module context, this resolution can produce a `ProblemReferenceBinding` instead of a `SourceTypeBinding`, due to module visibility constraints. When JDT then attempts the cast during class file generation, it fails with the reported `ClassCastException`. This was exposed by upstream changes in Eclipse JDT that added the stricter cast in `ClassFile.java` (the cast was not present in earlier JDT versions that AspectJ was built against). **Fix** In `AspectDeclaration.generateMethod(ClassFile, ResolvedMember, BodyGenerator)`, after creating the `MethodBinding` via `EclipseFactory.makeMethodBinding()`, we check whether `mb.declaringClass` is a `SourceTypeBinding`. If it isn't (i.e. it resolved to a `ProblemReferenceBinding`), we replace it with the aspect's own `binding` (which is always the correct `SourceTypeBinding` for these synthetic methods). This ensures the `MethodBinding` passed into JDT's class file generation always has the expected type. **Testing** Added test cases for all per-clause variants (`pertypewithin`, `persingleton`, `percflow`, `pertarget`, `perthis`) compiled inside a Java module. The `pertypewithin` case reproduces the original `ClassCastException`; the others verify no similar issue exists for other per-clause types. All tests pass after the fix, and existing module tests (`Ajc190Tests`) and `PerTypeWithinTests` show no regressions. ai-in-use: Fix and tests developed in conjunction with AI: Cursor using claude-4.6-opus model Fixes #344 |
||
|---|---|---|
| .github | ||
| .mvn/wrapper | ||
| ajde | ||
| ajde.core | ||
| ajdoc | ||
| asm | ||
| aspectjmatcher | ||
| aspectjrt | ||
| aspectjtools | ||
| aspectjweaver | ||
| bcel-builder | ||
| bridge | ||
| build | ||
| docs | ||
| installer | ||
| lib | ||
| loadtime | ||
| org.aspectj.ajdt.core | ||
| org.aspectj.matcher | ||
| run-all-junit-tests | ||
| runtime | ||
| scripts | ||
| src/assembly | ||
| taskdefs | ||
| testing | ||
| testing-client | ||
| testing-drivers | ||
| testing-util | ||
| tests | ||
| util | ||
| weaver | ||
| .editorconfig | ||
| .gitignore | ||
| .mailmap | ||
| CODE_OF_CONDUCT.md | ||
| CONTRIBUTING.md | ||
| LICENSE | ||
| mvnw | ||
| mvnw.cmd | ||
| pom.xml | ||
| README.md | ||
AspectJ
AspectJ is:
- a seamless aspect-oriented extension to the Java programming language
- Java platform compatible
- easy to learn and use
AspectJ enables:
- clean modularization of crosscutting concerns, such as error checking and handling, synchronization, context-sensitive behavior, performance optimizations, monitoring and logging, debugging support, and multi-object protocols
Building
AspectJ has a multi-module Maven build. Although various modules produce intermediate results, the key artifacts at the end of the build are:
aspectjrt- the AspectJ runtimeaspectjweaver- the AspectJ weaveraspectjtools- the AspectJ compileraspectjmatcher- the AspectJ matcher
These are the artifacts published to Maven Central for each release. In addition, there is an installer that can be run with java -jar to install AspectJ onto Windows/Mac/Linux. This installer is produced by the installer sub-module.
In the root of a cloned AspectJ simply run:
./mvnw clean install
Please make sure that your project root directory name is either aspectj (default for git clone) or org.aspectj (case-insensitive), if you wish to run the build with tests.
Some integration tests rely on this name when dynamically searching up the current path for the root folder.
You can also use a reasonably recent (3.6.3+), locally installed Maven installation instead of the Maven wrapper script.
This will build all the modules, run all the tests and install the key artifacts in your local repository. Once built, access the Maven dependencies from your local repository or run the installer to install AspectJ locally:
java -jar installer/target/aspectj-<VERSION>.jar
Running the tests in Eclipse
Once you have imported all the projects using m2e, there is a special module called run-all-junit-tests and within that a RunTheseBeforeYouCommitTests class that can be run with the JUnit launcher to execute thousands of tests.
Ensure you run this with a JDK - the more recent the better since some tests will not execute on older JDKs - tests that verify language features that only exist in the more up to date JDK version.
Documentation for AspectJ users
- Eclipse project page
- AspectJ website
- AspectJ documentation overview
- Setting up a development environment
- Getting started with AspectJ
- Programming Guide
- AspectJ 5 Developer’s Notebook
- READMEs for each version of AspectJ
- AspectJ Java version compatibility
Documentation for AspectJ developers
Maven releases
AspectJ is published to Maven Central under group ID org.aspectj.